[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1033211: marked as done (clp: configure script misdetects tons of things)



Your message dated Sun, 21 Jan 2024 21:19:01 +0000
with message-id <E1rRfDZ-002rA4-9b@fasolo.debian.org>
and subject line Bug#1033211: fixed in clp 1.17.9+ds-1
has caused the Debian Bug report #1033211,
regarding clp: configure script misdetects tons of things
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1033211: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1033211
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Source: clp
Version: 1.17.6-3
Severity: important
User: debian-cross@lists.debian.org
Usertags: ftcbfs

Hi,

I happened to look into a clp cross build failure, but what I found was
more problems. If you look at configure output, you see this:

| checking whether the compiler supports GNU C... no
| checking whether gcc accepts -g... no
| checking for gcc option to enable C11 features... unsupported
| checking for gcc option to enable C99 features... unsupported
| checking for gcc option to enable C89 features... unsupported

Quite obviously, this is all wrong and autoconf will turn on quite a bit
of barely tested workarounds due to these misdetections.

So I looked into why this happens and ultimately, all of these use
ac_fn_c_try_compile and they all say "$? = 0" followed by "failed
program" in config.log. So compilation was successful, but it was
treated as failure, because conftest.$ac_objext didn't exist. As it
happens, ac_objext is undefined, because _AC_COMPILER_OBJEXT hasn't been
run yet. It gets run later and then ac_fn_c_try_compile actually works,
but when these tests are rerun, their cached values are used.

I looked into the m4 files to see why this would happen, but I ended up
not identifying the cause. However, if you export ac_objext=o,
ac_fn_c_try_compile actually works and these things get correctly
detected. As it happens, this also fixes cross compilation, but really
the misdetections are a problem and should be fixed even for native
builds. I'm attaching a patch that works around the issue by setting
ac_objext, but I hope you can find a better solution.

Helmut
diff --minimal -Nru clp-1.17.6/debian/changelog clp-1.17.6/debian/changelog
--- clp-1.17.6/debian/changelog	2022-11-27 05:27:26.000000000 +0100
+++ clp-1.17.6/debian/changelog	2023-03-19 19:40:11.000000000 +0100
@@ -1,3 +1,9 @@
+clp (1.17.6-4) UNRELEASED; urgency=medium
+
+  * Work around severe configure misdetections. (Closes: #-1)
+
+ -- Helmut Grohne <helmut@subdivi.de>  Sun, 19 Mar 2023 19:40:11 +0100
+
 clp (1.17.6-3) unstable; urgency=medium
 
   * QA upload.
diff --minimal -Nru clp-1.17.6/debian/rules clp-1.17.6/debian/rules
--- clp-1.17.6/debian/rules	2022-11-27 05:27:26.000000000 +0100
+++ clp-1.17.6/debian/rules	2023-03-19 19:40:11.000000000 +0100
@@ -9,7 +9,10 @@
 	dh_autoreconf autoreconf -- --force --install --no-recursive --include=BuildTools
 
 override_dh_auto_configure:
-	dh_auto_configure -- --enable-static --enable-dot --enable-dependency-linking
+	# The configure script is broken as it uses ac_fn_c_try_compile before
+	# having run _AC_COMPILER_OBJEXT, so supply ac_objext to make it barely
+	# work.
+	ac_objext=o dh_auto_configure -- --enable-static --enable-dot --enable-dependency-linking
 
 override_dh_auto_build:
 	dh_auto_build

--- End Message ---
--- Begin Message ---
Source: clp
Source-Version: 1.17.9+ds-1
Done: Pierre Gruet <pgt@debian.org>

We believe that the bug you reported is fixed in the latest version of
clp, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1033211@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Pierre Gruet <pgt@debian.org> (supplier of updated clp package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sun, 21 Jan 2024 21:42:16 +0100
Source: clp
Architecture: source
Version: 1.17.9+ds-1
Distribution: unstable
Urgency: medium
Maintainer: Debian Science Maintainers <debian-science-maintainers@lists.alioth.debian.org>
Changed-By: Pierre Gruet <pgt@debian.org>
Closes: 934083 1014561 1033211 1043929
Changes:
 clp (1.17.9+ds-1) unstable; urgency=medium
 .
   * New upstream version 1.17.9+ds
   * Raising Standards version to 4.6.2
     - Rules-Requires-Root: no
   * Adopting the package (Closes: #934083)
   * Refreshing d/copyright
   * Depending on debhelper-compat 13
   * Removing unneeded versioned (build-)dependencies
   * Updating the list of files to exclude when repacking
   * Rewriting d/rules without autoreconf (Closes: #1033211)
     - Also listing files that should not be installed in d/not-installed
   * Removing embedded build path from Makefile and generated HTML files
     (Closes: #1014561)
   * Overriding the clean target so that package can be built twice in a row
     (Closes: #1043929)
   * Building with NDEBUG to disable asserts
   * Adding a Lintian override for shared libs' package name
   * Fixing a minor spelling mistake in the code
Checksums-Sha1:
 8b889e5db323deaec56f725ac031aca26a9c4011 2286 clp_1.17.9+ds-1.dsc
 bf497200754c7aeecab19c43bf92e95311276532 1349972 clp_1.17.9+ds.orig.tar.xz
 ae7e0567c91a359ff876223b9b6f5393fdced4ae 14940 clp_1.17.9+ds-1.debian.tar.xz
 2730d9f0f9feecee91b0ec99b98bdf8645c027e4 10156 clp_1.17.9+ds-1_amd64.buildinfo
Checksums-Sha256:
 0c7aca5bdf91739e3585f72645855e3bda17b4a8c77d09ad3b982547bbf11174 2286 clp_1.17.9+ds-1.dsc
 7f48047691debcf0a134e54b3a443e53d33571f99ecc4680ed6ef5784c3fb7bf 1349972 clp_1.17.9+ds.orig.tar.xz
 4783abe4b93904ad556cee73a4161fd44ca9f048932f554264d872c933d53f3f 14940 clp_1.17.9+ds-1.debian.tar.xz
 0446d4e52c437ea4430b5ac661ebe58e04001f2c4073911fbc9e478a73645d05 10156 clp_1.17.9+ds-1_amd64.buildinfo
Files:
 eb2aec6c0d99806bf76847a6adbb627a 2286 science optional clp_1.17.9+ds-1.dsc
 552740d3917826a24848de4ae370d8e9 1349972 science optional clp_1.17.9+ds.orig.tar.xz
 bdf420b8cc626f80aa4b7535015837ea 14940 science optional clp_1.17.9+ds-1.debian.tar.xz
 54812c9f69219c8fe13f9c13d0c36ed0 10156 science optional clp_1.17.9+ds-1_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEM8soQxPpC9J9y0UjYAMWptwndHYFAmWthSgACgkQYAMWptwn
dHYwZxAAs+xM0qHMrZ4E3+wHiVhotkA/UyyVhT7CQLIUfVJhP6thmb6GwK3641vH
eDnTj2CFG1SrI/UEdOf8AU5xfPrSNYuwdV5apdbtG2wenTm+bK12UC8Sn2Qvba7e
xKyCcKZmpoDClFr6/QaZIkF8zHNG7bCkYW7mUZgpc8Po7gZcyJjb1rrmibUEqSNY
iFBmuRfy3iU2DPPy1MU5l1Cj3geVNyhCyvyYb3iCH7fbG10vcJqclpKBfkN6BJgV
Ig9oTu4BXK5oP8VJ1Mehp3cJJ2Gskb4NrotipSDm6uD6QLsCna4WnGcegPzdh5TX
Awn3fr9kvr3xzz6pBu+M7dQNUigKSchmQpBL4sniSrxHFoaSugFBwf7Dm2SWlKWd
CDwASoDuQeCpwN9NBgsIWLzUANXRzwwxhapgoyr/qeNgRQLaAWUvXug+uXpGMgsq
C3iQCQlisjwavrKoJ5wTBywvFf5MiMISJhuhxChxI15EXp3zPj7VTceoEVNHDo4P
fDecaDAc0rOcxAsk5AFrfLAV7tuP3fvkbGOrplMdAkGrJvThytu4p4SKpVrSJEbS
8l9f/MBa+fNW88dLyAKikkxV3NfVCdBTsdF/BajHQ43xYTefdHOp7zTCCI4Dh67b
ilrbD4HNjwpCFZEOphna68uXjdrIsIOQzRp5n7MpPF/WOkDAaWA=
=YKCI
-----END PGP SIGNATURE-----

--- End Message ---

Reply to: