[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1024286: marked as done (lcm: reproducible-builds: Embedded build path and usrmerge paths in Makefile)

Your message dated Wed, 06 Dec 2023 21:36:49 +0000
with message-id <E1rAzZZ-006tLa-7D@fasolo.debian.org>
and subject line Bug#1024286: fixed in lcm 1.3.1+repack1-7
has caused the Debian Bug report #1024286,
regarding lcm: reproducible-builds: Embedded build path and usrmerge paths in Makefile
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1024286: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1024286
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: lcm
Severity: normal
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: buildpath usrmerge
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

The build path and binary paths are embedded in
/usr/share/doc/lcm-doc/examples/Makefile:

  https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/diffoscope-results/lcm.html

  ACLOCAL·=·${SHELL}·'/build/1st/lcm-1.3.1+repack1/missing'·aclocal-1.16
  vs.
  ACLOCAL·=·${SHELL}·'/build/2/lcm-1.3.1+repack1/2nd/missing'·aclocal-1.16

  EGREP·=·/bin/grep·-E
  vs.
  EGREP·=·/usr/bin/grep·-E

The attached patch fixes this by removing the example Makefile, which
would have to be regenerated anyways to match the system to run it on.

If removing the example Makefile is not viable, it might be possible to
sanitize the build paths, and all relevent arguments to configure
(e.g. EGREP='/bin/grep -e') to use the specified paths.

According to my local tests, With this patch applied lcm should build
reproducibly on tests.reproducible-builds.org!

Thanks for maintaining lcm!

live well,
  vagrant

From 65bc199c9a7bdb9f8a7fde7dc3aad441105394cf Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@reproducible-builds.org>
Date: Thu, 17 Nov 2022 00:25:41 +0000
Subject: [PATCH] debian/rules: Remove example Makefile that embedded build
 paths and binary paths.

---
 debian/rules | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/debian/rules b/debian/rules
index f29f30d..c9efc4e 100755
--- a/debian/rules
+++ b/debian/rules
@@ -13,6 +13,12 @@ override_dh_auto_install:
 # I build the docs after the 'make install' because the python docs require an installed lcm
 	cd docs; ./build-docs.sh
 
+override_dh_installdocs:
+	dh_installdocs
+	# Remove example makefile which contains build paths and
+	# binary paths
+	rm -vf debian/liblcm-doc/usr/share/doc/liblcm-doc/examples/Makefile
+
 override_dh_auto_clean:
 	dh_auto_clean
 	rm -rf docs/html
-- 
2.38.1

Attachment: signature.asc
Description: PGP signature


--- End Message ---
--- Begin Message --- 
Source: lcm
Source-Version: 1.3.1+repack1-7
Done: Vagrant Cascadian <vagrant@reproducible-builds.org>

We believe that the bug you reported is fixed in the latest version of
lcm, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1024286@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Vagrant Cascadian <vagrant@reproducible-builds.org> (supplier of updated lcm package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Wed, 06 Dec 2023 12:48:38 -0800
Source: lcm
Architecture: source
Version: 1.3.1+repack1-7
Distribution: unstable
Urgency: medium
Maintainer: Debian QA Group <packages@qa.debian.org>
Changed-By: Vagrant Cascadian <vagrant@reproducible-builds.org>
Closes: 1024286
Changes:
 lcm (1.3.1+repack1-7) unstable; urgency=medium
 .
   * QA upload.
   * debian/rules: Fix removal of Makefile that contains embedded build
     paths and binary paths. (Closes: #1024286)
   * debian/copyright: Update Source URL.
Checksums-Sha1:
 bc9bc67f1a8773fbc4793bdc9d6d5eabf9e365b8 1589 lcm_1.3.1+repack1-7.dsc
 dfed443eba486a844fd1e2897cf4fde33aeae000 5692 lcm_1.3.1+repack1-7.debian.tar.xz
 151a82ea0864eb9e69ed96b3615e07842b69bc66 9834 lcm_1.3.1+repack1-7_arm64.buildinfo
Checksums-Sha256:
 20b09b0d2c82d01833170d316e9e0be74ba8caf5d717dac46f22567fce4cfac1 1589 lcm_1.3.1+repack1-7.dsc
 f8868b54a95c28f8ef9cbc974aa2a229cd0fee753bdb48bcbc021abe5fde6777 5692 lcm_1.3.1+repack1-7.debian.tar.xz
 6a92ad8644fbc4b7e3483417aece909529d411fd68a815b9de7074692449dba1 9834 lcm_1.3.1+repack1-7_arm64.buildinfo
Files:
 2fca4031c1f3bd8e6aba42e9912f9664 1589 libs optional lcm_1.3.1+repack1-7.dsc
 5038c0352c00f71721f91f1484b482fe 5692 libs optional lcm_1.3.1+repack1-7.debian.tar.xz
 7dd712b052d19909c111d4a2b0afca0b 9834 libs optional lcm_1.3.1+repack1-7_arm64.buildinfo

-----BEGIN PGP SIGNATURE-----

iJYEARYKAD4WIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCZXDjFCAcdmFncmFudEBy
ZXByb2R1Y2libGUtYnVpbGRzLm9yZwAKCRDcUY/If5cWqly3AQDUoDQx5OG1KmF/
TMe8OtvQoqRU5W6i+OEHmnUDKJX0HAD/ZxlTA6dr4q/1aQ0p3NSZouLcXVy4w/+3
WXuTpOE6JAs=
=737y
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: