[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1034223: powerman: dh_installsystemd doesn't handle files in /usr/lib/systemd/system



Control: tag -1 patch pending

Laurent Bigonville <bigon@debian.org> (2023-04-20):
> I think severity can be downgraded (to "important"?), this is still a
> problem as systemctl daemon-reload is not called, but at least there
> will be surprise after a reboot.

It seems simple enough to fix, see attached source debdiff.

This results in the following debdiff on the binary side:

    [The following lists of changes regard files as different if they have
    different names, permissions or owners.]
    
    Files in second .deb but not in first
    -------------------------------------
    -rwxr-xr-x  root/root   /lib/systemd/system/powerman.service
    
    Files in first .deb but not in second
    -------------------------------------
    -rwxr-xr-x  root/root   /usr/lib/systemd/system/powerman.service
    
    No differences were encountered between the conffiles files
    
    Control files: lines which differ (wdiff format)
    ------------------------------------------------
    Installed-Size: [-500-] {+502+}
    Version: [-2.3.27-2-] {+2.3.27-3+}
    
    Postinst files: lines which differ (wdiff format)
    -------------------------------------------------
    {+# Automatically added by dh_installsystemd/13.11.4+}
    {+if [ "$1" = "configure" ] || [ "$1" = "abort-upgrade" ] || [ "$1" = "abort-deconfigure" ] || [ "$1" = "abort-remove" ] ; then+}
    {+	if deb-systemd-helper debian-installed 'powerman.service'; then+}
    {+		# The following line should be removed in trixie or trixie+1+}
    {+		deb-systemd-helper unmask 'powerman.service' >/dev/null || true+}
    {++}
    {+		if deb-systemd-helper --quiet was-enabled 'powerman.service'; then+}
    {+			# Create new symlinks, if any.+}
    {+			deb-systemd-helper enable 'powerman.service' >/dev/null || true+}
    {+		fi+}
    {+	fi+}
    {++}
    {+	# Update the statefile to add new symlinks (if any), which need to be cleaned+}
    {+	# up on purge. Also remove old symlinks.+}
    {+	deb-systemd-helper update-state 'powerman.service' >/dev/null || true+}
    {+fi+}
    {+# End automatically added section+}
    
    Postrm files: lines which differ (wdiff format)
    -----------------------------------------------
    {+# Automatically added by dh_installsystemd/13.11.4+}
    {+if [ "$1" = remove ] && [ -d /run/systemd/system ] ; then+}
    {+	systemctl --system daemon-reload >/dev/null || true+}
    {+fi+}
    {+# End automatically added section+}
    {+# Automatically added by dh_installsystemd/13.11.4+}
    {+if [ "$1" = "purge" ]; then+}
    {+	if [ -x "/usr/bin/deb-systemd-helper" ]; then+}
    {+		deb-systemd-helper purge 'powerman.service' >/dev/null || true+}
    {+	fi+}
    {+fi+}
    {+# End automatically added section+}
    
    Preinst files: lines which differ (wdiff format)
    ------------------------------------------------
    {+# Automatically added by dh_installsystemd/13.11.4+}
    {+if [ -z "${DPKG_ROOT:-}" ] && [ "$1" = upgrade ] && [ -d /run/systemd/system ] ; then+}
    {+	deb-systemd-invoke stop 'powerman.service' >/dev/null || true+}
    {+fi+}
    {+# End automatically added section+}
    
    No differences were encountered between the prerm files


I've left the following lintian warnings unaddressed (and haven't
touched tmpfiles.d at all):

    W: powerman: executable-not-elf-or-script [lib/systemd/system/powerman.service]
    W: powerman: executable-not-elf-or-script [usr/lib/tmpfiles.d/powerman.conf]
    W: powerman: systemd-service-file-refers-to-obsolete-target syslog.target [lib/systemd/system/powerman.service]


Upload on the way.


Cheers,
-- 
Cyril Brulebois (kibi@debian.org)            <https://debamax.com/>
D-I release manager -- Release team member -- Freelance Consultant
diff -Nru powerman-2.3.27/debian/changelog powerman-2.3.27/debian/changelog
--- powerman-2.3.27/debian/changelog	2022-11-21 01:12:27.000000000 +0100
+++ powerman-2.3.27/debian/changelog	2023-04-25 18:42:32.000000000 +0200
@@ -1,3 +1,11 @@
+powerman (2.3.27-3) unstable; urgency=medium
+
+  * QA upload.
+  * Ship systemd unit under /lib/systemd/system so that it can get picked
+    up by dh_installsystemd. (Closes: #1034223).
+
+ -- Cyril Brulebois <kibi@debian.org>  Tue, 25 Apr 2023 16:42:32 +0000
+
 powerman (2.3.27-2) unstable; urgency=medium
 
   * QA upload.
diff -Nru powerman-2.3.27/debian/powerman.install powerman-2.3.27/debian/powerman.install
--- powerman-2.3.27/debian/powerman.install	2022-11-21 01:12:27.000000000 +0100
+++ powerman-2.3.27/debian/powerman.install	2023-04-25 18:41:44.000000000 +0200
@@ -1,5 +1,5 @@
 #! /usr/bin/dh-exec
-[linux-any] debian/tmp/usr/lib/systemd/system/powerman.service
+[linux-any] debian/tmp/usr/lib/systemd/system/powerman.service /lib/systemd/system/
 debian/tmp/etc/powerman/*
 debian/tmp/usr/bin/*
 debian/tmp/usr/lib/tmpfiles.d/powerman.conf

Attachment: signature.asc
Description: PGP signature


Reply to: