[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1021463: marked as done (rdist: reproducible-builds: build path embedded in /usr/bin/rdist)

Your message dated Fri, 24 Feb 2023 21:23:09 +0000
with message-id <[🔎] E1pVfX3-008Fnp-CG@fasolo.debian.org>
and subject line Bug#1031841: Removed package(s) from unstable
has caused the Debian Bug report #1021463,
regarding rdist: reproducible-builds: build path embedded in /usr/bin/rdist
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1021463: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1021463
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: rdist
Severity: normal
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: buildpath
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

The build path is embedded in /usr/bin/rdist:

  https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/diffoscope-results/rdist.html

  /build/1st/rdist-6.1.5/src/rdist.c:105
  vs.
  /build/2/rdist-6.1.5/2nd/src/rdist.c:105

The attached patch fixes this by passing the default CFLAGS via the
CFLAGS_OS variable when calling make.

According to my local tests, with this patch applied, rdist should build
reproducibly on tests.reproducible-builds.org!

Thanks for maintaining rdist!

live well,
  vagrant

From 1ae2591af6070578468777e64d31435875b040d5 Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@reproducible-builds.org>
Date: Sat, 8 Oct 2022 23:20:06 +0000
Subject: [PATCH] debian/rules: Pass CFLAGS via the CFLAGS_OS variable to avoid
 embedding build paths.

https://reproducible-builds.org/docs/build-path/
---
 debian/rules | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/debian/rules b/debian/rules
index 3b32a29..32a9a9d 100755
--- a/debian/rules
+++ b/debian/rules
@@ -13,7 +13,7 @@ build-arch: build-stamp
 build-indep: build-stamp
 build-stamp:
 	dh_testdir
-	DEFS_LOCAL=-D_PATH_OLDRDIST=\\\"/usr/bin/oldrdist\\\" LIB_SYS="$(LDFLAGS)" $(MAKE)
+	DEFS_LOCAL=-D_PATH_OLDRDIST=\\\"/usr/bin/oldrdist\\\" LIB_SYS="$(LDFLAGS)" $(MAKE) CFLAGS_OS="$(CFLAGS)"
 	touch build-stamp
 
 clean:
-- 
2.37.2

Attachment: signature.asc
Description: PGP signature


--- End Message ---
--- Begin Message --- 
Version: 6.1.5-21+rm

Dear submitter,

as the package rdist has just been removed from the Debian archive
unstable we hereby close the associated bug reports.  We are sorry
that we couldn't deal with your issue properly.

For details on the removal, please see https://bugs.debian.org/1031841

The version of this package that was in Debian prior to this removal
can still be found using https://snapshot.debian.org/.

Please note that the changes have been done on the master archive and
will not propagate to any mirrors until the next dinstall run at the
earliest.

This message was generated automatically; if you believe that there is
a problem with it please contact the archive administrators by mailing
ftpmaster@ftp-master.debian.org.

Debian distribution maintenance software
pp.
Scott Kitterman (the ftpmaster behind the curtain)

--- End Message ---
Reply to: