[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#929612: marked as done (sispmctl: support EG-PMS2 aka usb-id 04b4:fd15)

Your message dated Mon, 06 Feb 2023 03:34:39 +0000
with message-id <E1pOsH9-00ExKQ-Ov@fasolo.debian.org>
and subject line Bug#929612: fixed in sispmctl 3.1-3
has caused the Debian Bug report #929612,
regarding sispmctl: support EG-PMS2 aka usb-id 04b4:fd15
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
929612: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=929612
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: sispmctl
Version: 3.1-1
Severity: important
Tags: patch upstream fixed-upstream
Forwarded: https://sourceforge.net/p/sispmctl/git/ci/bdd3c5006c07a801dd2e29162368ac407ac756b4

More recent devices use a USB ID of 04b4:fd15. The present sispmctl is
unable to talk to such devices. This is fixed upstream in version 4.1.
Please update to that version or cherry pick the relevant git commit.
For your convenience, I backported the commit to version 3.1-1. I think
it would be useful to fix this in buster as these devices will become
more widespread.

Helmut

commit bdd3c5006c07a801dd2e29162368ac407ac756b4
Author: Heinrich Schuchardt <xypron.glpk@gmx.de>
Date:   Sat Oct 13 12:58:50 2018 +0200

    Add new device idVendor=04b4, idProduct=fd15
    
    New Gembird EG-PMS2 uses a 0xFD15 as product ID.
    
    Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
    Tested-by: Matthias84 <notifications@github.com>

Index: sispmctl-3.1/src/main.c
===================================================================
--- sispmctl-3.1.orig/src/main.c
+++ sispmctl-3.1/src/main.c
@@ -490,7 +490,9 @@ void parse_command_line(int argc, char*
               printf("%d %s %s\n", status,
                      dev[status]->bus->dirname, dev[status]->filename);
             id = get_id(dev[status]);
-            if ((id == PRODUCT_ID_SISPM) || (id == PRODUCT_ID_SISPM_FLASH_NEW))
+            if ((id == PRODUCT_ID_SISPM) ||
+                (id == PRODUCT_ID_SISPM_FLASH_NEW) ||
+                (id == PRODUCT_ID_SISPM_EG_PMS2))
               if (numeric == 0)
                 printf("device type:      4-socket SiS-PM\n");
               else
@@ -789,7 +791,8 @@ int main(int argc, char** argv)
       if ((dev->descriptor.idVendor == VENDOR_ID) && ((dev->descriptor.idProduct == PRODUCT_ID_SISPM) ||
                                                       (dev->descriptor.idProduct == PRODUCT_ID_MSISPM_OLD) ||
                                                       (dev->descriptor.idProduct == PRODUCT_ID_MSISPM_FLASH) ||
-                                                      (dev->descriptor.idProduct == PRODUCT_ID_SISPM_FLASH_NEW))) {
+                                                      (dev->descriptor.idProduct == PRODUCT_ID_SISPM_FLASH_NEW) ||
+                                                      (dev->descriptor.idProduct == PRODUCT_ID_SISPM_EG_PMS2))) {
 	usbdev[count++] = dev;
       }
       if (count == MAXGEMBIRD) {
Index: sispmctl-3.1/src/sispm_ctl.c
===================================================================
--- sispmctl-3.1.orig/src/sispm_ctl.c
+++ sispmctl-3.1/src/sispm_ctl.c
@@ -3,6 +3,7 @@
 
   Controls the GEMBIRD Silver Shield PM USB outlet device
 
+  (C) 2015-2018, Heinrich Schuchardt <xypron.glpk@gmx.de>
   (C) 2004,2005,2006 Mondrian Nuessle, Computer Architecture Group, University of Mannheim, Germany
   (C) 2005, Andreas Neuper, Germany
   (C) 2010, Olivier Matheret, France, for the plannification part
@@ -164,7 +165,9 @@ int check_outlet_number(int id, int outl
         fprintf(stderr,"mSIS-PM devices only feature one outlet. Number changed from %d to 1\n", outlet);
     outlet = 1;
   }
-  if (id == PRODUCT_ID_SISPM || id == PRODUCT_ID_SISPM_FLASH_NEW) {
+  if ((id == PRODUCT_ID_SISPM) ||
+      (id == PRODUCT_ID_SISPM_FLASH_NEW) ||
+      (id == PRODUCT_ID_SISPM_EG_PMS2)) {
     if (outlet < 1 || outlet > 4) {
       if (verbose == 1)
         fprintf(stderr,"SIS-PM devices only feature 4 outlets. Number changed from %d to 1\n", outlet);
Index: sispmctl-3.1/src/sispm_ctl.h
===================================================================
--- sispmctl-3.1.orig/src/sispm_ctl.h
+++ sispmctl-3.1/src/sispm_ctl.h
@@ -39,8 +39,7 @@
 #define PRODUCT_ID_MSISPM_OLD		 0xFD10
 #define PRODUCT_ID_MSISPM_FLASH		 0xFD12
 #define PRODUCT_ID_SISPM_FLASH_NEW		 0xFD13
-
-
+#define PRODUCT_ID_SISPM_EG_PMS2	0xFD15
 
 #define USB_DIR_IN                       0x80            /* to host */
 #define USB_DIR_OUT                      0               /* to device */

--- End Message ---
--- Begin Message --- 
Source: sispmctl
Source-Version: 3.1-3
Done: Cyril Brulebois <kibi@debian.org>

We believe that the bug you reported is fixed in the latest version of
sispmctl, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 929612@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Cyril Brulebois <kibi@debian.org> (supplier of updated sispmctl package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Mon, 06 Feb 2023 04:11:25 +0100
Source: sispmctl
Architecture: source
Version: 3.1-3
Distribution: unstable
Urgency: medium
Maintainer: Debian QA Group <packages@qa.debian.org>
Changed-By: Cyril Brulebois <kibi@debian.org>
Closes: 929612
Changes:
 sispmctl (3.1-3) unstable; urgency=medium
 .
   * QA upload.
   * Add support for EnerGenie EG-PMS2 (Closes: #929612).
Checksums-Sha1:
 cdf8e05a9189025ea460c9cadcd775ac0d7847fd 1768 sispmctl_3.1-3.dsc
 02b9074b3ecb76d41c0edca781bd790cee3dccd8 2808 sispmctl_3.1-3.debian.tar.xz
 f6f371534d461fc53a239acd3c2a00435bf97f3b 6458 sispmctl_3.1-3_source.buildinfo
Checksums-Sha256:
 e08f5c9bb97a9af98ed01e93a5d8184fc90217894ed0b509cfc5a18523f0c8e3 1768 sispmctl_3.1-3.dsc
 193b948a84e11cc71aed1bfee60927322768a8f9e0f80a4fd36568c1549aeaf1 2808 sispmctl_3.1-3.debian.tar.xz
 fb9c6c91b4d5611afc2428a8e86870189c505595bff34515c52e794eec81eac2 6458 sispmctl_3.1-3_source.buildinfo
Files:
 6df003ccaf99eb4d30533b7dd4c90259 1768 admin extra sispmctl_3.1-3.dsc
 2de39a899ee591550aa60000123da079 2808 admin extra sispmctl_3.1-3.debian.tar.xz
 0878081a130ba108c0017a50e4890401 6458 admin extra sispmctl_3.1-3_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJEBAEBCgAuFiEEtg6/KYRFPHDXTPR4/5FK8MKzVSAFAmPgcLwQHGtpYmlAZGVi
aWFuLm9yZwAKCRD/kUrwwrNVIA7nD/9sQC5OtZBLb5PzUCHCXV1tWKYo+h8bJ5k3
xljiosH8d9oNcxSXT8v7N79PCZTwnPFWKmjsPBc1PHYYIvG5M76uNbUvPOWgVz2z
OrlBji3nB9xBFXSdJWx472YOT/Cd8TZcpdE6sKNs3zkn6EhdOFvScdBnTncgxZ7o
1W5vOt6R7X7FoM9QCwtSLJFPrRxFcR9W/NTKf+fJcMtTDxg978lJ1Gm0HNYl/fga
y5s9uS2kydmzD0bYjRxbhlWaXCyq1TfUQED//BOpJuMZL+vAp2Js5PCUNwB0hj/4
lUUxIJpyZQjRcAs0S872W0/CekCMs/lvOWoqdM6z2Csz6TIP6Vu1E4yqu+ticOKr
oFtLvyWX1HC+KyIOaGwpriBwvHIzsc+9pm7CABld/H7E9M2irU8ao53bSWzUrclP
Q7lzOOd2V/3PG14bPhr0l4hzttKuBK4/2NVSSVtWDhWbbA9tNEXzGc7vsjTDGoMH
rNBYR3Lu5TN3DGBwUdlQiQ4QmX0GeneIuXA1TLcCCpaK87EJN/X0v+ZODYUYTTmM
Esge/izeVmOHSqepKjIzr52YJ4OBLw5gmcrXzbNX81o6N9TIbaKmeUlEmAC886Sb
e+CxTHzDnPUwaqB5rjvXe5itppPI1JwycPFsLSYY0ZWoLnOlA2bxnsd5z/gXWMzL
vrBUNff4tg==
=gsqY
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: