[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1020798: marked as done (netkit-rsh: reproducible-builds: Embedded build paths in binaries)

Your message dated Sat, 21 Jan 2023 23:35:33 +0000
with message-id <E1pJNOX-00Agen-7j@fasolo.debian.org>
and subject line Bug#1020798: fixed in netkit-rsh 0.17-24
has caused the Debian Bug report #1020798,
regarding netkit-rsh: reproducible-builds: Embedded build paths in binaries
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1020798: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1020798
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: netkit-rsh
Severity: normal
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: buildpath
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

The build path is embedded in various binaries:

  https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/diffoscope-results/netkit-rsh.html

  /usr/sbin/in.rlogind

  /build/1st/netkit-rsh-0.17/rlogind/network.c
  vs.
  /build/2/netkit-rsh-0.17/2nd/rlogind/network.c

The attached patch to debian/rules fixes this by adding
-ffile-prefix-map to CFLAGS.

Alternately, updating to use dh and a recent debhelper compat version
might also fix this.

According to my local tests, with this patch applied netkit-rsh should
build reproducibly on tests.reproducible-builds.org!

Thanks for maintaining netkit-rsh!

live well,
  vagrant

From 6529f07eacdf749b1a5390933f8ac3a91093b664 Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@reproducible-builds.org>
Date: Mon, 26 Sep 2022 21:40:41 +0000
Subject: [PATCH] debian/rules: Add -ffile-prefix-map to CFLAGS to avoid
 embedding the build path.

https://reproducible-builds.org/docs/build-path/
---
 debian/rules | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/debian/rules b/debian/rules
index 8049402..42ca247 100755
--- a/debian/rules
+++ b/debian/rules
@@ -1,6 +1,6 @@
 #!/usr/bin/make -f
 
-export CFLAGS += -Ddebian -DFSUID_HACK -D_GNU_SOURCE
+export CFLAGS += -Ddebian -DFSUID_HACK -D_GNU_SOURCE -ffile-prefix-map=$(CURDIR)=.
 
 %:
 	dh $@ --buildsystem=cmake
-- 
2.37.2

Attachment: signature.asc
Description: PGP signature


--- End Message ---
--- Begin Message --- 
Source: netkit-rsh
Source-Version: 0.17-24
Done: Holger Levsen <holger@debian.org>

We believe that the bug you reported is fixed in the latest version of
netkit-rsh, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1020798@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Holger Levsen <holger@debian.org> (supplier of updated netkit-rsh package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Wed, 11 Jan 2023 23:52:56 +0100
Source: netkit-rsh
Architecture: source
Version: 0.17-24
Distribution: unstable
Urgency: medium
Maintainer: Debian QA Group <packages@qa.debian.org>
Changed-By: Holger Levsen <holger@debian.org>
Closes: 1020798
Changes:
 netkit-rsh (0.17-24) unstable; urgency=medium
 .
   * QA upload by the Reproducible Builds team.
   * d/rules: Add -ffile-prefix-map to CFLAGS to avoid embedding the build
     path, thanks to Vagrant Cascadian. Closes: #1020798
Checksums-Sha1:
 84f237cacc028088678eb6e6588cd90c39b97b7b 1753 netkit-rsh_0.17-24.dsc
 30ea194bdc6b25ad123cb76ce3131f91e5a618e1 23972 netkit-rsh_0.17-24.debian.tar.xz
 ef70525736f22d2607cdb2d1f2afc181e2a2892a 6690 netkit-rsh_0.17-24_source.buildinfo
Checksums-Sha256:
 3696ef44f7f3dfcccfabe473873a06896df2beb0eb3459c263fd6ab5ef6a3aea 1753 netkit-rsh_0.17-24.dsc
 fc3c82184c2069f4f586f21cee9f7958b552dd5cc1efc213289945f532b6ddaa 23972 netkit-rsh_0.17-24.debian.tar.xz
 ed3d292e90e7cf242e708d4ba280bec79dc80ec3f2c686f981458de66175a58b 6690 netkit-rsh_0.17-24_source.buildinfo
Files:
 fc1ae1915af24f32436b84eb771d660b 1753 net optional netkit-rsh_0.17-24.dsc
 ebc676e0d8b14075636cfefadec14c2b 23972 net optional netkit-rsh_0.17-24.debian.tar.xz
 24b2443a548132fc07969d51cb56f964 6690 net optional netkit-rsh_0.17-24_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEuL9UE3sJ01zwJv6dCRq4VgaaqhwFAmO/Pn0ACgkQCRq4Vgaa
qhwLdhAAqu0XJiZkOa2DqGG1AUq+OLCe8mCQZv+4RSmDxVsok+lB8wv3W6sC7bVJ
yAnKOJLb5nlk3Mty/R2YauUgdVXm4OFUdXYa2C01AUL/Dt2HBM9v0Syw92ZhJCSw
PR++t3XNws0/pSYWMRaIPVQOWx/FGAqf3zeBw7hxlFujxJfw9IY1yyzB3nIpr4Cx
n+ORgvIll8I3EPFOIBL582PEs5FHG2g6yHth4+K22p+MuPLSJBgpkATA2EHmOWOy
6vn0XrS4MYO6g4oXM/+10DFrXsk8SAw5cCXiMrzG441JOX1Go3DOi0RlVeZwv0Zp
OCbAka0CXxcRvJfJoIZgDwQGtMCuj4+t5Zl06EFn9wDqdoQRvBVxAJrACGpOaaIH
dlw43TR6K1v67lHLOBmI32zJyUQmZm1JiWVd2ocrNXOi5mzvnS2XnDdjxVScu+tW
v9crVkHy00LZlx5SmFXgx4DSSs+LNmYCbPIyn/9tHehRl3RrWwQgVoHXsa9VjGXG
cPPwxbEtwkb5jlqsfkm1TTmyo9qw/GIwxcHSxQDOHWv8lizmmh1G7piPgEB/dykm
y8wlC/gbvPl0i5tejvFpEMN/acD4kAUMl8Eh1h8FXytnMbyFBtNtbluGlAMBNFVw
CmOd2FDgulafTxJcp/IfdfS/Pz1+tMfCuURn/kN94CVAbRLYLU8=
=/Zl1
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: