[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1034235: ceph-iscsi: dh_installsystemd doesn't handle files in /usr/lib/systemd/system



Control: tag -1 patch pending

bigon@debian.org <bigon@debian.org> (2023-04-11):
> It seems that your package ceph-iscsi is shipping files (.service, .socket or
> .timer) in /usr/lib/systemd/system.
> 
> This is not supported by the version of dh_installsystemd/debhelper currently
> in unstable and bookworm (See: #1031695). That means that currently your
> service might not be enabled at boot and/or started as expected.

Source and binary debdiffs attached. Since that's an orphaned package,
an upload will follow.


Cheers,
-- 
Cyril Brulebois (kibi@debian.org)            <https://debamax.com/>
D-I release manager -- Release team member -- Freelance Consultant
diff -Nru ceph-iscsi-3.5/debian/ceph-iscsi.install ceph-iscsi-3.5/debian/ceph-iscsi.install
--- ceph-iscsi-3.5/debian/ceph-iscsi.install	2021-09-24 12:45:45.000000000 +0000
+++ ceph-iscsi-3.5/debian/ceph-iscsi.install	2023-04-25 15:25:07.000000000 +0000
@@ -1 +1 @@
-usr/lib/systemd/system/*.service
+usr/lib/systemd/system/*.service /lib/systemd/system
diff -Nru ceph-iscsi-3.5/debian/changelog ceph-iscsi-3.5/debian/changelog
--- ceph-iscsi-3.5/debian/changelog	2021-09-24 12:45:45.000000000 +0000
+++ ceph-iscsi-3.5/debian/changelog	2023-04-25 15:26:14.000000000 +0000
@@ -1,3 +1,11 @@
+ceph-iscsi (3.5-3) unstable; urgency=medium
+
+  * QA upload.
+  * Ship systemd units under /lib/systemd/system so that they can get
+    picked up by dh_installsystemd (Closes: #1034235).
+
+ -- Cyril Brulebois <kibi@debian.org>  Tue, 25 Apr 2023 15:26:14 +0000
+
 ceph-iscsi (3.5-2) unstable; urgency=medium
 
   * QA upload.
[The following lists of changes regard files as different if they have
different names, permissions or owners.]

Files in second .changes but not in first
-----------------------------------------
-rw-r--r--  root/root   /lib/systemd/system/rbd-target-api.service
-rw-r--r--  root/root   /lib/systemd/system/rbd-target-gw.service

Files in first .changes but not in second
-----------------------------------------
-rw-r--r--  root/root   /usr/lib/systemd/system/rbd-target-api.service
-rw-r--r--  root/root   /usr/lib/systemd/system/rbd-target-gw.service

No differences were encountered between the conffiles files

Control files: lines which differ (wdiff format)
------------------------------------------------
Installed-Size: [-557-] {+562+}
Version: [-3.5-2-] {+3.5-2.1+}

Postinst files: lines which differ (wdiff format)
-------------------------------------------------
{+# Automatically added by dh_installsystemd/13.11.4+}
{+if [ "$1" = "configure" ] || [ "$1" = "abort-upgrade" ] || [ "$1" = "abort-deconfigure" ] || [ "$1" = "abort-remove" ] ; then+}
{+	# The following line should be removed in trixie or trixie+1+}
{+	deb-systemd-helper unmask 'rbd-target-api.service' >/dev/null || true+}
{++}
{+	# was-enabled defaults to true, so new installations run enable.+}
{+	if deb-systemd-helper --quiet was-enabled 'rbd-target-api.service'; then+}
{+		# Enables the unit on first installation, creates new+}
{+		# symlinks on upgrades if the unit file has changed.+}
{+		deb-systemd-helper enable 'rbd-target-api.service' >/dev/null || true+}
{+	else+}
{+		# Update the statefile to add new symlinks (if any), which need to be+}
{+		# cleaned up on purge. Also remove old symlinks.+}
{+		deb-systemd-helper update-state 'rbd-target-api.service' >/dev/null || true+}
{+	fi+}
{+fi+}
{+# End automatically added section+}
{+# Automatically added by dh_installsystemd/13.11.4+}
{+if [ "$1" = "configure" ] || [ "$1" = "abort-upgrade" ] || [ "$1" = "abort-deconfigure" ] || [ "$1" = "abort-remove" ] ; then+}
{+	# The following line should be removed in trixie or trixie+1+}
{+	deb-systemd-helper unmask 'rbd-target-gw.service' >/dev/null || true+}
{++}
{+	# was-enabled defaults to true, so new installations run enable.+}
{+	if deb-systemd-helper --quiet was-enabled 'rbd-target-gw.service'; then+}
{+		# Enables the unit on first installation, creates new+}
{+		# symlinks on upgrades if the unit file has changed.+}
{+		deb-systemd-helper enable 'rbd-target-gw.service' >/dev/null || true+}
{+	else+}
{+		# Update the statefile to add new symlinks (if any), which need to be+}
{+		# cleaned up on purge. Also remove old symlinks.+}
{+		deb-systemd-helper update-state 'rbd-target-gw.service' >/dev/null || true+}
{+	fi+}
{+fi+}
{+# End automatically added section+}
{+# Automatically added by dh_installsystemd/13.11.4+}
{+if [ "$1" = "configure" ] || [ "$1" = "abort-upgrade" ] || [ "$1" = "abort-deconfigure" ] || [ "$1" = "abort-remove" ] ; then+}
{+	if [ -d /run/systemd/system ]; then+}
{+		systemctl --system daemon-reload >/dev/null || true+}
{+		if [ -n "$2" ]; then+}
{+			_dh_action=restart+}
{+		else+}
{+			_dh_action=start+}
{+		fi+}
{+		deb-systemd-invoke $_dh_action 'rbd-target-api.service' 'rbd-target-gw.service' >/dev/null || true+}
{+	fi+}
{+fi+}
{+# End automatically added section+}

Postrm files: lines which differ (wdiff format)
-----------------------------------------------
{+# Automatically added by dh_installsystemd/13.11.4+}
{+if [ "$1" = remove ] && [ -d /run/systemd/system ] ; then+}
{+	systemctl --system daemon-reload >/dev/null || true+}
{+fi+}
{+# End automatically added section+}
{+# Automatically added by dh_installsystemd/13.11.4+}
{+if [ "$1" = "purge" ]; then+}
{+	if [ -x "/usr/bin/deb-systemd-helper" ]; then+}
{+		deb-systemd-helper purge 'rbd-target-api.service' 'rbd-target-gw.service' >/dev/null || true+}
{+	fi+}
{+fi+}
{+# End automatically added section+}

No differences were encountered between the preinst files

Prerm files: lines which differ (wdiff format)
----------------------------------------------
# Automatically added by {+dh_installsystemd/13.11.4+}
{+if [ -z "${DPKG_ROOT:-}" ] && [ "$1" = remove ] && [ -d /run/systemd/system ] ; then+}
{+	deb-systemd-invoke stop 'rbd-target-api.service' 'rbd-target-gw.service' >/dev/null || true+}
{+fi+}
{+# End automatically added section+}
{+# Automatically added by+} dh_installinit/13.11.4

Attachment: signature.asc
Description: PGP signature


Reply to: