[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1011428: marked as done (cdbackup: reproducible-builds: embedded build paths in various binaries)

Your message dated Thu, 08 Dec 2022 17:49:14 +0000
with message-id <E1p3L1G-0079zB-RC@fasolo.debian.org>
and subject line Bug#1011428: fixed in cdbackup 0.7.1-2
has caused the Debian Bug report #1011428,
regarding cdbackup: reproducible-builds: embedded build paths in various binaries
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1011428: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1011428
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: cdbackup
Severity: normal
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: buildpath
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

The build path is embedded in /usr/bin/cdbackup and /usr/bin/cdrestore:

  https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/diffoscope-results/cdbackup.html

  /build/1st/cdbackup-0.7.1/cdbackup.c:421
  vs.
  /build/2/cdbackup-0.7.1/2nd/cdbackup.c:421

The attached patch fixes this by explicitly passing CFLAGS to
dh_auto_build in debian/rules, which includes the -ffile-prefix-map
argument to avoid embedding the absolute path in compiled files.


With this patch applied, cdbackup should build reproducibly on
tests.reproducible-builds.org!


live well,
  vagrant

From 5cc4d882ffe7bd447c315e43ced64bbee1b9a4ac Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@reproducible-builds.org>
Date: Sun, 22 May 2022 17:40:35 +0000
Subject: [PATCH] debian/rules: Explicitly pass CFLAGS to dh_auto_build.

---
 debian/rules | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/debian/rules b/debian/rules
index 123ed55..4618c51 100755
--- a/debian/rules
+++ b/debian/rules
@@ -6,6 +6,9 @@
 %:
 	dh  $@
 
+override_dh_auto_build:
+	dh_auto_build -- CFLAGS="$(CFLAGS)"
+
 # Use override_dh_* targets to customize this.
 # ---------------------------------------------------
 # Followings are the old debian/rules
-- 
2.36.1

Attachment: signature.asc
Description: PGP signature


--- End Message ---
--- Begin Message --- 
Source: cdbackup
Source-Version: 0.7.1-2
Done: Chris Lamb <lamby@debian.org>

We believe that the bug you reported is fixed in the latest version of
cdbackup, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1011428@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Chris Lamb <lamby@debian.org> (supplier of updated cdbackup package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Thu, 08 Dec 2022 17:42:51 +0000
Source: cdbackup
Binary: cdbackup cdbackup-dbgsym
Architecture: source amd64
Version: 0.7.1-2
Distribution: unstable
Urgency: medium
Maintainer: Debian QA Group <packages@qa.debian.org>
Changed-By: Chris Lamb <lamby@debian.org>
Description:
 cdbackup   - CD-R(W) backup utility
Closes: 1011428
Changes:
 cdbackup (0.7.1-2) unstable; urgency=medium
 .
   * QA upload.
   * Apply a patch by Vagrant Cascadian to make the build reproducible.
     binaries. (Closes: #1011428)
Checksums-Sha1:
 ca669c3e0aeb102c4f52cbc8e4cfebb9b2016a7b 1695 cdbackup_0.7.1-2.dsc
 64d4a647a1ba248e727dc93f3410c757f8e17d96 22710 cdbackup_0.7.1.orig.tar.gz
 1bd18a8bca0ceb307518cf80ced44d5de67df3ca 5688 cdbackup_0.7.1-2.debian.tar.xz
 43fd721adcf82cd8eff68b87c3bba7f46c544bc7 40444 cdbackup-dbgsym_0.7.1-2_amd64.deb
 702a666390e6cf2040745052a59c847deb596f6c 5966 cdbackup_0.7.1-2_amd64.buildinfo
 7717adbefcd9a7e458e179baf2db855aa71f3b1c 30048 cdbackup_0.7.1-2_amd64.deb
Checksums-Sha256:
 83cd7ffa5e301d01cf16ce93e73acdbb851ed6feee3ce5c42e6b22426dd0f646 1695 cdbackup_0.7.1-2.dsc
 b9d94acd0065c243b2a9d5a47af768ddae003f81a181a61155065a11bb59449c 22710 cdbackup_0.7.1.orig.tar.gz
 4d1a47c79f07cd344aab9ac4b1ca1745b93c8bc9476f18630e2c3cfaa20d4ae0 5688 cdbackup_0.7.1-2.debian.tar.xz
 8f7b9acc325e0d89d88ebbcf0b97ff2558958eb6d527a0d38b5f2e48866254e1 40444 cdbackup-dbgsym_0.7.1-2_amd64.deb
 9868d04491fd9a7cec671f7944dba4ffdf35c61b9799d9083d95b59f017cc734 5966 cdbackup_0.7.1-2_amd64.buildinfo
 5fb9899ae4d08bc2ca19f2858e585eecd7ae37b0dd0fc4f7449cf3cc1cfbb8b0 30048 cdbackup_0.7.1-2_amd64.deb
Files:
 8aa9d905c07378020b831eff6ba80734 1695 admin extra cdbackup_0.7.1-2.dsc
 92913f7c8850ae38cce86da4014e967c 22710 admin extra cdbackup_0.7.1.orig.tar.gz
 799cb430d3603c411f293e93fe8e1a78 5688 admin extra cdbackup_0.7.1-2.debian.tar.xz
 0018363f72d5bb01813fcbd2ff42ce51 40444 debug optional cdbackup-dbgsym_0.7.1-2_amd64.deb
 3a71021c281660c2d598064b8decd84a 5966 admin extra cdbackup_0.7.1-2_amd64.buildinfo
 a05f2d3e2b26a774c73576822d90831b 30048 admin extra cdbackup_0.7.1-2_amd64.deb

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEwv5L0nHBObhsUz5GHpU+J9QxHlgFAmOSIn8ACgkQHpU+J9Qx
HlhVYg//WgQqRZKt1yRRzNWGBylIo0oyAo0dXfbbNXu5ACihb/aPZQyIrNjipNBn
mAFYBHkhNovJiFbKW6ZQ90rYZMFYAN0Sn92Dr6ps8uhMBkUjLuHK81C1pMrK3fEo
U0inAZ+qu7DnvwHO32dU/rKd7AMatfS0hO0PQ7nQCVJ+5kIwWBMy8IB2o9gxLS5b
CFWw0OXu9Q1Uc1YvNd70p2Nfza4pWxpsMBNLHSLz234KSANW0TLmAYclpRES1c0z
mYTr5TPOYd4UMLgF0zCCh4vP/C0ISbfRW0ENwTGgi8S76HLcNrvtPC8BOPmNgCuh
U4C7BCKaubz6FJz8if3PMwgfmk6IVfrQyniHL6zVXrgiszqyuKqY3pHH1xa1vzd1
womDj95lqi0mKvLfPTfEexJsc0o39zJroKKHlz+Nk8om44p80IfjbvLlGjD7176Y
hmd12l8NaqnEsi6Th2ijkwWeO7AIvI1G4RKd6yfZSqqS6GLoRnoJ55kh01GMjUU8
+wuczx8OzNkiHVRMLSPlId7SOAnxU9mV+2TnSuW7hjAIa6Ez9g0w3yC4x0lUwOVk
MVnOqEAstza4lVc4i3GQjxUmtN6hJ069msi+btcSyx1JQ2kRQthRKirU7lRAXMLt
cVryoJ4w/OtJuaJmL4P3BYNZwJzORxOKdihzFBUF3cFBC/ZQXKU=
=8YXA
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: