[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1011471: marked as done (mgdiff: reproducible-builds: embedded build paths in /usr/bin/mgdiff)

Your message dated Mon, 07 Nov 2022 22:22:14 +0000
with message-id <E1osAVS-009K6t-8e@fasolo.debian.org>
and subject line Bug#1011471: fixed in mgdiff 1.0+debian1-1
has caused the Debian Bug report #1011471,
regarding mgdiff: reproducible-builds: embedded build paths in /usr/bin/mgdiff
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1011471: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1011471
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: mgdiff
Severity: normal
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: buildpath
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

The build path is embedded in /usr/bin/mgdiff:

  https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/diffoscope-results/mgdiff.html

  /build/1st/mgdiff-1.0/mgdiff.c:1057
  vs.
  /build/2/mgdiff-1.0/2nd/mgdiff.c:1057

The attached patch fixes this by explicitly passing CFLAGS to
make in debian/rules, which includes the -ffile-prefix-map
argument to avoid embedding the absolute path in compiled files.


With this patch applied, mgdiff should build reproducibly on
tests.reproducible-builds.org!


live well,
  vagrant

From 4aa0b48b924de1a73b5cbe541b4adfafe832e013 Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@reproducible-builds.org>
Date: Mon, 23 May 2022 17:06:51 +0000
Subject: [PATCH] debian/rules: Explicitly pass CFLAGS to make.

---
 debian/rules | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/debian/rules b/debian/rules
index 1df2c00..152626e 100755
--- a/debian/rules
+++ b/debian/rules
@@ -9,7 +9,7 @@ build-arch:
 	dh_testdir
 	xmkmf
 	make depend XMULIBONLY=""
-	make XMULIBONLY=""
+	make XMULIBONLY="" CFLAGS="$(CFLAGS)"
 	touch build
 
 clean:
-- 
2.36.1

Attachment: signature.asc
Description: PGP signature


--- End Message ---
--- Begin Message --- 
Source: mgdiff
Source-Version: 1.0+debian1-1
Done: Boyuan Yang <byang@debian.org>

We believe that the bug you reported is fixed in the latest version of
mgdiff, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1011471@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Boyuan Yang <byang@debian.org> (supplier of updated mgdiff package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Mon, 07 Nov 2022 17:01:15 -0500
Source: mgdiff
Architecture: source
Version: 1.0+debian1-1
Distribution: unstable
Urgency: medium
Maintainer: Debian QA Group <packages@qa.debian.org>
Changed-By: Boyuan Yang <byang@debian.org>
Closes: 1011471
Changes:
 mgdiff (1.0+debian1-1) unstable; urgency=medium
 .
   * QA upload.
   * Bump version string to use proper "3.0 (quilt)" format.
   * debian/: Apply wrap-and-sort -abst.
   * debian/control: Move Vcs-* back to Debian Salsa.
   * debian/rules: Specify CFLAGS during make. (Closes: #1011471)
   * debian/: Use 3.0 (quilt) format and debhelper compat v13.
   * Bump Standards-Version to 4.6.1.
Checksums-Sha1:
 99021b6254c4a8d20b0f98ea2914369ecb1d2f0e 1853 mgdiff_1.0+debian1-1.dsc
 52fcb9f55e9d00a8189b4fab0c54c094a0311427 54772 mgdiff_1.0+debian1.orig.tar.gz
 a5f64c54923c52cd6d5942983c05dc94d280dbc8 18924 mgdiff_1.0+debian1-1.debian.tar.xz
 32504eaa75a45150c0003d701f7f60765294828f 7769 mgdiff_1.0+debian1-1_amd64.buildinfo
Checksums-Sha256:
 7a5c5337dd65ceb65afacde1f5ec4abf1f4ac581afd4bc99c9bf5ad374b0ed88 1853 mgdiff_1.0+debian1-1.dsc
 1bf2f42a591c7fdbd04015b0c8137f82baecd560d7cfe9f86f1cbb15620cec37 54772 mgdiff_1.0+debian1.orig.tar.gz
 ffdc8007220b04a62c075dc981e543b6dff3f1e10b586aab0b96cfc0e39bad2d 18924 mgdiff_1.0+debian1-1.debian.tar.xz
 0469840f1d8a473bdc9576390e7cbe24082d8faa62b076ae2ce6d245a044bdb9 7769 mgdiff_1.0+debian1-1_amd64.buildinfo
Files:
 cec695efe0fbc4a94460f3b49cacdf63 1853 text optional mgdiff_1.0+debian1-1.dsc
 3b6c4d85b360ba639a6f7c568dd30083 54772 text optional mgdiff_1.0+debian1.orig.tar.gz
 828c10350dde357a74fde8a3a7fa33d0 18924 text optional mgdiff_1.0+debian1-1.debian.tar.xz
 f393db9163ee1383781dde969fc83543 7769 text optional mgdiff_1.0+debian1-1_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEfncpR22H1vEdkazLwpPntGGCWs4FAmNpgUYACgkQwpPntGGC
Ws5FpQ/9HS20DNLk1P/syyRHQV1MiAhzAdua0kUERnECSjZRgRt1GmWxXHF+hSAm
WGvkRsnNEpmD+lL4GJ6Pbl3XWzGV0Yd0dN/qwBbty2dpapkcu96DYzoBTop+fIHg
c9AZeackZHrwdrbLAqlAlrKv/qS/aGbVRTZ82Ch12EOCfVUVuVNze/CM6l93Qr9X
dQu77E9qp+Sj81YutwesxrfTE97kU6VU47Tk+EzWpTn3qTUvK99Il7kUyhlHz5XF
RjIlShwmJp5NdXXt9bc53vv5hPoMx5VWm7/HjvsVW7YZQS1X6OIRe64nEM9vB0d7
ChtArYyP4vqGOnKvAff+SYVMGw0c0/8HpR4RGZAksE6+HLASbH3uRZxtqI3TYar7
M9uH8AOjdTkrLEDMWy69BZefkaCjuhJMjxTbXRZEiU+S6tXUKT6C8a2ngvXpXHfp
3tt8VWBUXnmk15SIa3ur7d1P9VDpbmeJUZeHVtsBe4O567iGbHEMFAhKgEPDECtN
lEJ41TWDzKDPk6OMDlVpWJypZji3vYp4V0RcsHBOsQnVGMlYZ0qc5EXBFERvAdfr
ZnAlBq/M4cdqKnDmcKzY5Wezi4kLYrF4MimITpIEijj6wdtNoLP33lLQ065qdqEr
TgOZN3BSJIBfFCPPAE5gByx5EMMYhYQSf902+QqqNPAeHVibJL0=
=trQ1
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: