[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#990428: marked as done (ifenslave: Bonding not working on bullseye (using bond-slaves config))

Your message dated Mon, 29 Aug 2022 18:17:08 +0000
with message-id <E1oSjJs-004MnR-J7@fasolo.debian.org>
and subject line Bug#990428: fixed in ifenslave 2.13~deb11u1
has caused the Debian Bug report #990428,
regarding ifenslave: Bonding not working on bullseye (using bond-slaves config)
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
990428: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=990428
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: ifenslave
Version: 2.12
Severity: important

Dear Maintainer,

Bonding on Debian 11 Bullseye is not working, when using "bond-slaves int1 int2" syntax on the bonding interface.
However it seems to work, when defining bonding the other way around using "bond-master bond1" on the interfaces which make up the bonding interface.

I came across bug #968368 and modified the ifenslave pre-up.d script, hence the changes below.

The same config (using bond-slaves) was working fine in Debian Buster. In Bullseye the bond interface stays DOWN and /proc/net/bonding/bond* also shows mii-status down.

-- System Information:
Debian Release: 11.0
  APT prefers testing-security
  APT policy: (500, 'testing-security'), (500, 'testing')
Architecture: amd64 (x86_64)

Kernel: Linux 5.10.0-7-amd64 (SMP w/24 CPU threads)
Kernel taint flags: TAINT_FIRMWARE_WORKAROUND
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE=en_US:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages ifenslave depends on:
ii  ifupdown  0.8.36
ii  iproute2  5.10.0-4

Versions of packages ifenslave recommends:
ii  net-tools  1.60+git20181103.0eebece-1

ifenslave suggests no packages.

-- Configuration Files:
/etc/network/if-pre-up.d/ifenslave changed:
[ "$VERBOSITY" = 1 ] && set -x
[ "$ADDRFAM" = meta ] && exit 0
add_master()
{
	# Return if $IFACE is already a bonding interface.
	[ -f "/sys/class/net/$IFACE/bonding/slaves" ] && return
	ip link add dev "$IFACE" type bond
}
sysfs_change_down()
{
	# Called with :
	# $1 = basename of the file in bonding/ to write to.
	# $2 = value to write. Won't write if $2 is empty.
	if [ -n "$2" ] ; then
		# If the value we plan to write is different from the current one...
		if ! grep -sq "\\<$2\\>" "/sys/class/net/$BOND_MASTER/bonding/$1" ; then
			# ...and the master is up...
			if ip link show "$BOND_MASTER" | grep -sq '[<,]UP[,>]' ; then
				# ...bring the master down.
				ip link set dev "$BOND_MASTER" down
			fi
		fi
		sysfs "$1" "$2"
	fi
}
sysfs()
{
	# Called with :
	# $1 = basename of the file in bonding/ to write to.
	# $2 = value to write. Won't write if $2 is empty.
	if [ -n "$2" ] ; then
		echo "$2" > "/sys/class/net/$BOND_MASTER/bonding/$1"
		return $?
	fi
	return 0
}
sysfs_add()
{
	#??Called with :
	# $1 = target filename.
	# $2 = values to write.
	for value in $2; do
		# Do not add $2 to $1 if already present.
		if ! grep -sq "\\<$value\\>" "/sys/class/net/$BOND_MASTER/bonding/$1"
		then
		    sysfs "$1" "+$value"
		fi
	done
}
early_setup_master()
{
	# Warning: the order in which we write into the sysfs files is important.
	# Double check in drivers/net/bonding/bond_sysfs.c in the Linux kernel source tree
	# before changing anything here.
	# fail_over_mac must be set before enslavement of any slaves.
	sysfs fail_over_mac "$IF_BOND_FAIL_OVER_MAC"
}
enslave_slaves()
{
	case "$BOND_SLAVES" in
		none)
			BOND_SLAVES=""
			;;
		all)
			BOND_SLAVES=$(sed -ne 's/ *\(eth[^:]*\):.*/\1/p' /proc/net/dev)
			;;
	esac
	[ "$VERBOSITY" = 1 ] && v=-v
	for slave in $BOND_SLAVES ; do
		export IFENSLAVE_ENV_NAME="IFUPDOWN_$slave"
		IFUPDOWN_IFACE="$(printenv "$IFENSLAVE_ENV_NAME")"
		unset IFENSLAVE_ENV_NAME
		#if ifquery --state "$slave" 2>/dev/null || [ -n "$IFUPDOWN_IFACE" ] ; then
		if ifquery --state "$slave" 2>/dev/null ; then
			# Skipping interface that's already up or being configured
			continue
		else
			# Ensure $slave is down.
			ip link set "$slave" down 2>/dev/null
			if ! sysfs_add slaves "$slave" 2>/dev/null ; then
				echo "Failed to enslave $slave to $BOND_MASTER. Is $BOND_MASTER ready and a bonding interface ?" >&2
			else
				# Bring up slave if it is the target of an allow-bondX stanza.
				# This is useful to bring up slaves that need extra setup.
				ifup $v --allow "$BOND_MASTER" "$slave"
			fi
		fi
	done
}
setup_master()
{
	# Warning: the order in which we write into the sysfs files is important.
	# Double check in drivers/net/bonding/bond_sysfs.c in the Linux kernel source tree
	# before changing anything here.
	# use_carrier can be set anytime.
	sysfs use_carrier "$IF_BOND_USE_CARRIER"
	# num_grat_arp can be set anytime.
	sysfs num_grat_arp "$IF_BOND_NUM_GRAT_ARP"
	# num_unsol_na can be set anytime.
	sysfs num_unsol_na "$IF_BOND_NUM_UNSOL_NA"
	# arp_ip_target must be set before arp_interval.
	sysfs_add arp_ip_target "$IF_BOND_ARP_IP_TARGET"
	sysfs arp_interval "$IF_BOND_ARP_INTERVAL"
	# miimon must be set before updelay and downdelay.
	sysfs miimon "$IF_BOND_MIIMON"
	sysfs downdelay "$IF_BOND_DOWNDELAY"
	sysfs updelay "$IF_BOND_UPDELAY"
	# Changing ad_select requires $BOND_MASTER to be down.
	sysfs_change_down ad_select "$IF_BOND_AD_SELECT"
	# Changing mode requires $BOND_MASTER to be down.
	# Mode should be set after miimon or arp_interval, to avoid a warning in syslog.
	sysfs_change_down mode "$IF_BOND_MODE"
	# Requires $BOND_MASTER to be down and mode to be configured
	sysfs_change_down xmit_hash_policy "$IF_BOND_XMIT_HASH_POLICY"
	sysfs_change_down tlb_dynamic_lb "$IF_BOND_TLB_DYNAMIC_LB"
	# packets_per_slave allowed for mode balance-rr only.
	sysfs packets_per_slave "$IF_BOND_PACKETS_PER_SLAVE"
	# arp_validate must be after mode (because mode must be active-backup).
	sysfs arp_validate "$IF_BOND_ARP_VALIDATE"
	# lacp_rate must be set after mode (because mode must be 802.3ad).
	# Changing lacp_rate requires $BOND_MASTER to be down.
	sysfs_change_down lacp_rate "$IF_BOND_LACP_RATE"
	# queue_id must be set after enslavement.
	for iface_queue_id in $IF_BOND_QUEUE_ID ; do
		sysfs iface_queue_id "$iface_queue_id"
	done
	# active_slave must be set after mode and after enslavement.
	# The slave must be up and the underlying link must be up too.
	# FIXME: We should have a way to write an empty string to active_slave, to set the active_slave to none.
	if [ -n "$IF_BOND_ACTIVE_SLAVE" ] ; then
		if [ "$IF_BOND_ACTIVE_SLAVE" = "none" ] ; then
			sysfs active_slave ""
		else
			# Need to force interface up before. Bonding will refuse to activate a down interface.
			if ifquery -l "$IF_BOND_ACTIVE_SLAVE" 2>/dev/null ; then
				ifup "$IF_BOND_ACTIVE_SLAVE"
			else
				ip link set "$IF_BOND_ACTIVE_SLAVE" up
			fi
			sysfs active_slave "$IF_BOND_ACTIVE_SLAVE"
		fi
	fi
}
setup_primary() {
	# primary must be set after mode (because only supported in some modes) and after enslavement.
	# The first slave in bond-primary found in current slaves becomes the primary.
	# If no slave in bond-primary is found, then the primary does not change.
	for slave in $IF_BOND_PRIMARY ; do
		slaves="/sys/class/net/$BOND_MASTER/bonding/slaves"
		if grep -sq "\\<$slave\\>" "$slaves" ; then
			sysfs primary "$slave"
			break
		fi
	done
	# primary_reselect should be set after mode (it is only supported in some modes), after enslavement
	# and after primary. This is currently (2.6.35-rc1) not enforced by the bonding driver, but it is
	# probably safer to do it in that order.
	sysfs primary_reselect "$IF_BOND_PRIMARY_RESELECT"
}
setup_master_device() {
	add_master
	early_setup_master
	setup_master
	enslave_slaves
	setup_primary
}
setup_slave_device() {
	# Require the bond master to have an iface stanza
	#if ! ifstate -l "$IF_BOND_MASTER" 2>/dev/null ; then
	if ! ifquery -l "$IF_BOND_MASTER" 2>&1 >/dev/null ; then
		echo "No iface stanza found for master $IF_BOND_MASTER" >&2
		exit 1
	fi
	# Ensure the master is up or being configured
	export IFENSLAVE_ENV_NAME="IFUPDOWN_$IF_BOND_MASTER"
	IFUPDOWN_IF_BOND_MASTER="$(printenv "$IFENSLAVE_ENV_NAME")"
	unset IFENSLAVE_ENV_NAME
	if [ -z "$IFUPDOWN_IF_BOND_MASTER" ] ; then
		#ifquery --state "$IF_BOND_MASTER" 2>/dev/null || ifup "$IF_BOND_MASTER"
		ifquery --state "$IF_BOND_MASTER" 2>&1 >/dev/null || ifup "$IF_BOND_MASTER"
	fi
	# Enslave it to the master
	#ip link set "$slave" down 2>/dev/null
	#if ! sysfs_add slaves "$slave" 2>/dev/null ; then
	#	echo "Failed to enslave $slave to $BOND_MASTER." >&2
	ip link set "$1" down 2>/dev/null
	if ! sysfs_add slaves "$1" 2>/dev/null ; then
		echo "Failed to enslave $1 to $BOND_MASTER." >&2
	fi
	setup_primary
}
IF_BOND_SLAVES=${IF_BOND_SLAVES:-$IF_SLAVES}
if [ -n "$IF_BOND_MASTER" ] ; then
	# FIXME: use function arguments instead of this variable
	BOND_MASTER="$IF_BOND_MASTER"
	setup_slave_device "$IFACE"
elif [ -n "$IF_BOND_SLAVES" ] || [ -n "$IF_BOND_MODE" ] ; then
	# FIXME: use function arguments instead of these variables
	BOND_MASTER="$IFACE"
	BOND_SLAVES="$IF_BOND_SLAVES"
	setup_master_device "$IFACE"
fi
exit 0


-- no debconf information

--- End Message ---
--- Begin Message --- 
Source: ifenslave
Source-Version: 2.13~deb11u1
Done: Salvatore Bonaccorso <carnil@debian.org>

We believe that the bug you reported is fixed in the latest version of
ifenslave, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 990428@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Salvatore Bonaccorso <carnil@debian.org> (supplier of updated ifenslave package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sat, 25 Jun 2022 09:45:37 +0200
Source: ifenslave
Architecture: source
Version: 2.13~deb11u1
Distribution: bullseye
Urgency: medium
Maintainer: Debian QA Group <packages@qa.debian.org>
Changed-By: Salvatore Bonaccorso <carnil@debian.org>
Closes: 949062 968368 990428 991930 992102
Changes:
 ifenslave (2.13~deb11u1) bullseye; urgency=medium
 .
   * Rebuild for bullseye
   * Revert "Bump Standards-Version to 4.6.0 (no changed needed)"
 .
 ifenslave (2.13) unstable; urgency=medium
 .
   * QA upload.
 .
   [ Guillem Jover ]
   * Fix MAC address setting messed up by udev for bond interfaces.
     (Closes: #949062)
   * Use ifquery instead of example contrib script ifstate. (Closes: #991930)
   * Fix ifquery redirections.
   * Bump Standards-Version to 4.6.0 (no changed needed).
   * Remove long supported Linux version requirements from Description.
 .
   [ Sami Haahtinen ]
   * Use correct argument in setup_slave_device(). (Closes: #968368)
 .
   [ Oleander Reis ]
   * Handle slave definitions of interfaces with no bond settings.
     (Closes: #990428)
   * Delete bond interfaces on ifdown -a. (Closes: #992102)
Checksums-Sha1: 
 84704a26fbd24fa9d1fbb9e9b806832a1c595026 1704 ifenslave_2.13~deb11u1.dsc
 a032e5c410d1fc200233f8a965c54be866a743e6 12736 ifenslave_2.13~deb11u1.tar.xz
Checksums-Sha256: 
 636de69f49f4272023e39539f08b13abd336177f90c15b0458c4cfa4544701a3 1704 ifenslave_2.13~deb11u1.dsc
 494b177df3220916c31dd37b40ae361cb82df0605b6eaf111f5ab33b8b99a4b5 12736 ifenslave_2.13~deb11u1.tar.xz
Files: 
 2c4a566fe41ec349d4a93db3615d0a9c 1704 net optional ifenslave_2.13~deb11u1.dsc
 a0a5d722c7d06b0ee30d6a1fb3535947 12736 net optional ifenslave_2.13~deb11u1.tar.xz

-----BEGIN PGP SIGNATURE-----

iQKmBAEBCgCQFiEERkRAmAjBceBVMd3uBUy48xNDz0QFAmK2vWJfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDQ2
NDQ0MDk4MDhDMTcxRTA1NTMxRERFRTA1NENCOEYzMTM0M0NGNDQSHGNhcm5pbEBk
ZWJpYW4ub3JnAAoJEAVMuPMTQ89E68IP/iLqEmwfdyWqaTn0stTLNm+1ATXEJd68
cdH78yvDCikFgmefRZQLgAleYDyWt6HFEO0m2aIUMeedmT3+hW/Mz2Q/AZ7Q2yaz
KYJip+smYUWVXak0gQuVtaS8caDTuxsgRLEiK3/kxuSi6bT5+oWnLMGXK9copCji
z+SHTnywcOjMD5y8Yk3PWTx1KvzC/BHC2Dh9hvMXBBc7iTztp/AiL27whbg7iUSh
g8asbCTMVSDShPN6R4NILFX4vcE1q0B8RSZt6HNs9VIiIadt/n/e2EnVuDYl6da4
1KT79HYUrD+bNiYq3QWxwMDbbafcOr9KlU8QC7V50SiRycptZ5IR/FYLdK9fHBte
uSeHzat1ZXAL01A6sI9T5B9N0+fGbCzQ8uSqEMR/opYrwqMUe3go8bxoRbtXZRiy
Xq7TrAB/I40Z9/di9EfFXlqsDKsX8HlrdtpZowTWaGotq4E2phjtdrbpzsWaENeU
KJZdfrR+0hqo30e9uCr/Y+1eE5awDEXVXZ7RlbidAWQrPsEs1muPApk1V8ZYtbBL
mSSd4M2gk2JdbzKyEoWT0s7r42S0Faqeen8pAQS5EZlpaZhmBWKcxA0CTjQwVQnJ
stAnUtqAQPgoCg9a1Zh4ZzaacHr2YDbcVdbUahm9zZWKxj5Q5tvHRXrqbFVLw5o1
PKETjN0J5Hbe
=qdaD
-----END PGP SIGNATURE-----

Attachment: pgp_zJ2mk7fw5.pgp
Description: PGP signature


--- End Message ---
Reply to: