[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1010785: gdome2: reproducible-builds: embedded build paths libgdome.so.*



Hi Vagrant,

On Wed, 15 Jun 2022 20:41:05 -0700 Vagrant Cascadian wrote:
> Control: found 1010785 0.8.1+debian-8
>
> On 2022-05-09, Vagrant Cascadian wrote:
> > The build path is embedded in /usr/lib/libgdome.so.0.8.1:
> >
> >   https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/diffoscope-results/gdome2.html
> >
> >   /build/1st/gdome2-0.8.1+debian/libgdome/gdome.c:65
> >   vs.
> >   /build/2/gdome2-0.8.1+debian/2nd/libgdome/gdome.c:65
> >
> >
> > The attached patch to debian/rules fixes this by passing
> > -ffile-prefix-map in CFLAGS and ensuring CFLAGS is passed to configure.
> >
> > Alternately, updating the packaging to use dh/debhelper at a recent
> > compat level would also likely fix this.
>
> Turns out simply switching to dh/debhelper was not sufficient...

Actually, switching to debhelper v13 was fine. The problem was the
manual CFLAGS logic in debian/rules.

With that removed and handled by debhelper, -ffile-prefix-map is
passed to the compiler correctly, along with other hardening and
security flags.

> Probably adjusting debian/rules with something like:
>
> override_dh_auto_configure:
>     CFLAGS="$(CFLAGS) -ffile-prefix-map=$(CURDIR)" dh_auto_configure
>
> I'll try and provide an updated patch and confirm the fix at some
> point... though if someone else does it first I won't complain! :)

I ran `reprotest` with the attached patch applied and the builds were
reproducible. `blhc` also had no output (meaning there were no
issues).

I've uploaded a build to Debian Mentors [1]. If you are happy to
sponsor the upload, please do. Otherwise, please apply the patch and
upload yourself.

Hugh

[1] https://mentors.debian.net/debian/pool/main/g/gdome2/gdome2_0.8.1+debian-9.dsc

Attachment: gdome2-0.8.1+debian-9.debdiff
Description: Binary data


Reply to: