[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#943752: memtest86+: Please switch source tree



Hi,

https://github.com/anphsw/memtest86 is another memtest86+ fork which
contains some interesting changes. Unlike both upstream and coreboot's fork:
* in dmi.c, it's not affected by https://bugs.debian.org/1003906 , and
it contains updated DMI struct definitions;
* in spd.c, struct pci_smbus_controller smbcontrollers[] contains ~30
additional entries for Intel hardware;
* in main.c and test.c, it has new latency analysis and Rowhammer tests;
* etc.

In config.h and lib.c , both forks have support for 4 serial ports, up
from 2.

On its side, the coreboot fork integrates multiboot changes, embeds a
much newer and larger JEDEC ID list than both upstream and anphsw's
fork, etc.

Lastly, unlike both forks, upstream 5.31b has DDR5 entries in dmi.c's
static char *memory_types[], a number of typo fixes, the beginning of a
user-space unit test program for memtest86+ (which could be used as a
starting point for fuzzing the DMI, SPD, ACPI, etc. parsing functions).

It's a mess :)


PS: I used the following mechanical changes to clean up a bit the large
diffs between memtest86+ 5.31b and the anphsw / coreboot forks:

perl -pi -e "s/v->/vv->/g" *
perl -pi -e "s/isdigit/mt86_isdigit/g" *
perl -pi -e "s/memcmp/mt86_memcmp/g" *
perl -pi -e "s/memmove/mt86_memmove/g" *
perl -pi -e "s/strncmp/mt86_strncmp/g" *
perl -pi -e "s/strstr/mt86_strstr/g" *
perl -pi -e "s/strlen/mt86_strlen/g" *
perl -pi -e "s/error\(/mt86_error(/g" *
perl -pi -e "s/print_mt86_error/print_error/g" *
+ 1 manual edition to test.h for renaming v to vv

Many whitespace changes still appear in those diffs, despite passing the
-b or -w flags to `diff`.


Reply to: