[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1003412: 9base build system always strips



Source: 9base
Version: 1:6-11
Tags: patch
User: debian-cross@lists.debian.org
Usertags: ftcbfs

The 9base build system strips binaries unconditionally. This has
multiple consequences:
 * There is no -dbgsym package.
 * DEB_BUILD_OPTIONS=nostrip produces stripped binaries.
 * It fails using the build architecture strip during cross builds.

The solution to all of these is not letting the upstream build system
strip and rely on dh_strip. Please consider applying the attached patch.

Helmut
diff --minimal -Nru 9base-6/debian/changelog 9base-6/debian/changelog
--- 9base-6/debian/changelog	2021-02-28 09:30:20.000000000 +0100
+++ 9base-6/debian/changelog	2022-01-09 18:05:44.000000000 +0100
@@ -1,3 +1,9 @@
+9base (1:6-12) UNRELEASED; urgency=medium
+
+  * Don't let the build system strip. (Closes: #-1)
+
+ -- Helmut Grohne <helmut@subdivi.de>  Sun, 09 Jan 2022 18:05:44 +0100
+
 9base (1:6-11) unstable; urgency=medium
 
   * QA upload.
diff --minimal -Nru 9base-6/debian/patches/nostrip.patch 9base-6/debian/patches/nostrip.patch
--- 9base-6/debian/patches/nostrip.patch	1970-01-01 01:00:00.000000000 +0100
+++ 9base-6/debian/patches/nostrip.patch	2022-01-09 18:05:32.000000000 +0100
@@ -0,0 +1,40 @@
+--- 9base-6.orig/config.mk
++++ 9base-6/config.mk
+@@ -22,3 +22,4 @@
+ AR          = ar rc
+ CC          = cc
+ YACC        = ../yacc/9yacc
++STRIP       = strip
+--- 9base-6.orig/diff/Makefile
++++ 9base-6/diff/Makefile
+@@ -8,7 +8,7 @@
+ include ../config.mk
+ 
+ all: ${TARG}
+-	@strip ${TARG}
++	@$(STRIP) ${TARG}
+ 	@echo built ${TARG}
+ 
+ install: ${TARG}
+--- 9base-6.orig/sam/Makefile
++++ 9base-6/sam/Makefile
+@@ -10,7 +10,7 @@
+ include ../config.mk
+ 
+ all: ${TARG}
+-	@strip ${TARG}
++	@$(STRIP) ${TARG}
+ 	@echo built ${TARG}
+ 
+ install: ${TARG}
+--- 9base-6.orig/std.mk
++++ 9base-6/std.mk
+@@ -6,7 +6,7 @@
+ include ../config.mk
+ 
+ all: ${TARG}
+-	@strip ${TARG}
++	@$(STRIP) ${TARG}
+ 	@echo built ${TARG}
+ 
+ install: install-default post-install
diff --minimal -Nru 9base-6/debian/patches/series 9base-6/debian/patches/series
--- 9base-6/debian/patches/series	2021-02-28 09:15:00.000000000 +0100
+++ 9base-6/debian/patches/series	2022-01-09 18:04:19.000000000 +0100
@@ -8,3 +8,4 @@
 0008-rc-Default-to-a-traditional-prompt.patch
 0009-fix-non-verbose-build.patch
 0010-applied-Alexander-Clouter-s-9base-sha1sum-patch.patch
+nostrip.patch
diff --minimal -Nru 9base-6/debian/rules 9base-6/debian/rules
--- 9base-6/debian/rules	2021-02-28 08:38:39.000000000 +0100
+++ 9base-6/debian/rules	2022-01-09 18:05:42.000000000 +0100
@@ -28,7 +28,7 @@
 override_dh_auto_build:
 	dh_auto_build -- \
 		CFLAGS='$(CFLAGS) $(CPPFLAGS)' LDFLAGS='$(LDFLAGS)' \
-		PREFIX=$(PREFIX) MANPREFIX=$(MANDIR)
+		PREFIX=$(PREFIX) MANPREFIX=$(MANDIR) STRIP=true
 
 override_dh_auto_install:
 	dh_auto_install -- \

Reply to: