[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#858220: marked as done (ns2: please make the build reproducible)

Your message dated Sun, 20 Nov 2022 19:10:03 +0000
with message-id <E1owphb-00Amrg-Lh@fasolo.debian.org>
and subject line Bug#858220: fixed in ns2 2.35+dfsg-5
has caused the Debian Bug report #858220,
regarding ns2: please make the build reproducible
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
858220: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=858220
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: ns2
Version: 2.35+dfsg-2.1
Severity: wishlist
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: randomness
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

Hi,

Whilst working on the Reproducible Builds effort [0], we noticed
that ns2 could not be built reproducibly.

This is due to the installation of test artifacts which contain random
and/or non-deterministic output, specially "fairflow.tr.gz".

Patch attached that simply doesn't install these files to ns2-examples.
Another approach might be to run upstream's "remove.com" shell script
that appears to clean the test suite of such things.

 [0] https://reproducible-builds.org/


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

diff --git a/debian/rules b/debian/rules
index cff3674..cf69a6a 100755
--- a/debian/rules
+++ b/debian/rules
@@ -27,6 +27,9 @@ override_dh_auto_install:
 override_dh_installchangelogs:
 	dh_installchangelogs CHANGES.html
 
+override_dh_install:
+	dh_install -Xtcl/test/
+
 override_dh_compress:
 	dh_compress -X.tcl -Xvalidate
 dfsg-orig:

--- End Message ---
--- Begin Message --- 
Source: ns2
Source-Version: 2.35+dfsg-5
Done: Marcos Talau <talau@debian.org>

We believe that the bug you reported is fixed in the latest version of
ns2, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 858220@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Marcos Talau <talau@debian.org> (supplier of updated ns2 package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sun, 20 Nov 2022 15:30:29 -0300
Source: ns2
Architecture: source
Version: 2.35+dfsg-5
Distribution: unstable
Urgency: medium
Maintainer: Debian QA Group <packages@qa.debian.org>
Changed-By: Marcos Talau <talau@debian.org>
Closes: 858220 984253
Changes:
 ns2 (2.35+dfsg-5) unstable; urgency=medium
 .
   * QA upload.
   * debian/rules: Add override_dh_install to make the build reproducible.
     Thanks to Chris Lamb. (Closes: #858220)
   * debian/patches/0008-fix-build-with-gcc11.patch: New. Fix FTBFS with gcc-11.
     (Closes: #984253)
Checksums-Sha1:
 d7cf752c70e94b6835a2a3eacd2278ffb89f52f1 2108 ns2_2.35+dfsg-5.dsc
 d11f7ed8af5e3ad8a3c4a760c77072bb1660c8eb 16692 ns2_2.35+dfsg-5.debian.tar.xz
 9bf5b01c4e4821640fcbca40eaa941810ff60834 9191 ns2_2.35+dfsg-5_source.buildinfo
Checksums-Sha256:
 7c250395a81b16e81a3a52b66b8cdcad234d90c50b90f5a5361862fcbd652cd7 2108 ns2_2.35+dfsg-5.dsc
 211547d9d46b2576949bab424f13d439c44627489ce41c7371c3585dce3323ff 16692 ns2_2.35+dfsg-5.debian.tar.xz
 49ca02f6dbe0114446cc0b3974cef6a48207f922bc120fe62ec5e561c3bd88b8 9191 ns2_2.35+dfsg-5_source.buildinfo
Files:
 821c4363ca73dd22f34cd63f67e0ae88 2108 net optional ns2_2.35+dfsg-5.dsc
 d045e5c7b9290b835a20e0aa7b6c908c 16692 net optional ns2_2.35+dfsg-5.debian.tar.xz
 71b7216af3b52c50db52ec8c62788f81 9191 net optional ns2_2.35+dfsg-5_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEtSLzkVnaB9053AsR9LqqgNsoukwFAmN6dF4ACgkQ9LqqgNso
ukxc9w//U5BdARSU+IYMJaR6s78eif1M4JdvpHYVYz0csf2ACn31JegGSkVSK+ql
QV3AVIFKXSCyMhvkD2eE+RKdvG9GvGflTzTw+j8nYirGZ5uxdv7JJPYDDupP9Y0W
fE6zggNhX4xSK41ux1xUq9wDKKb9tuIBz0a5CJbwSIqGaavT5BZ4USIwea1fxt6V
vP1sK+gqtiYRsH/lh3fWNFpfDdYlZtbPMskcihwR+Ej5qF0IsVSvEGyht+qquUn+
6Fs9lC7urkm17QdLJ0M0+K+EQ7dpJQYwQlhp1EbhpGTy/pn2WXgRcBMndfhILo1B
GDqSI+QiZA7n4CXwTCE3S7jICBzc8/oLsK2LQ9GT79HncO5bUxoaFqfvQiAnJeqB
EjsAyXIFFak1041B5r2buIoWHiSU7p8q+83edj6m0BXQgXVYZJ1FzB/kl+h29r+m
cJvAvHtNGp6ePeV5MUrn9v+9jUFSzAzajbTUbIwLOAUsIgJbrgTLe3zk8prAZjmy
0g3GvjHwCGwgn1nvd1CTnYSO7ZRCeVTJCIQr7zKmBPYgENu0hjnxXeihwEWeHq2U
qkUYoKN2nDVAYL4q/WvHX+oDJ1qd59Xq1rEDzPXYWXKiRmqCCc6d7hsip2KJU+Jx
FsGZd4SiO0ilvJJMQoqgto5ImK40ipEuRgZbWOR8k6AaWTPjm20=
=L4LM
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: