[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1024126: marked as done (hunt: reproducible-builds: build path embedded in various binaries)

Your message dated Fri, 18 Nov 2022 16:55:21 +0000
with message-id <E1ow4e9-00F96A-Dh@fasolo.debian.org>
and subject line Bug#1024126: fixed in hunt 1.5-8
has caused the Debian Bug report #1024126,
regarding hunt: reproducible-builds: build path embedded in various binaries
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1024126: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1024126
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: hunt
Severity: normal
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: buildpath
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

The build path is embedded in various binaries:

  https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/diffoscope-results/hunt.html

  /usr/sbin/hunt

  /build/1st/hunt-1.5/main.c:461
  vs.
  /build/2/hunt-1.5/2nd/main.c:461

The attached patch to upstream Makefiles fixes this by adding the
-ffile-prefix-map argument to CFLAGS, which avoids embedding the full
build path.

According to my local tests, with this patch applied hunt should build
reproducibly on tests.reproducible-builds.org!

Thanks for maintaining hunt!

live well,
  vagrant

From 928b51d50a0d756ef3ca77a42c6e9df5b8a8341e Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@reproducible-builds.org>
Date: Tue, 15 Nov 2022 02:34:43 +0000
Subject: [PATCH] Makefile, tpserv/Makefile: Add -ffile-prefix-map to CFLAGS to
 avoid embedding build paths.

https://reproducible-builds.org/docs/build-path/
---
 Makefile        | 2 +-
 tpserv/Makefile | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/Makefile b/Makefile
index 1631984..98b5af1 100644
--- a/Makefile
+++ b/Makefile
@@ -1,4 +1,4 @@
-CFLAGS=-Wall -O2 -g -D_REENTRANT -std=gnu89
+CFLAGS=-Wall -O2 -g -D_REENTRANT -std=gnu89 -ffile-prefix-map=$(CURDIR)=.
 #CFLAGS+=-DSYNC_FAST
 #CFLAGS+=-D_WITH_LINUX_KERNEL_HDR
 
diff --git a/tpserv/Makefile b/tpserv/Makefile
index a24cf4c..751be46 100644
--- a/tpserv/Makefile
+++ b/tpserv/Makefile
@@ -1,4 +1,4 @@
-CFLAGS=-Wall -O2 -g
+CFLAGS=-Wall -O2 -g -ffile-prefix-map=$(CURDIR)=.
 
 all: tpserv
 
-- 
2.38.1

Attachment: signature.asc
Description: PGP signature


--- End Message ---
--- Begin Message --- 
Source: hunt
Source-Version: 1.5-8
Done: Braulio Henrique Marques Souto <braulio@disroot.org>

We believe that the bug you reported is fixed in the latest version of
hunt, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1024126@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Braulio Henrique Marques Souto <braulio@disroot.org> (supplier of updated hunt package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Thu, 17 Nov 2022 22:28:19 -0300
Source: hunt
Architecture: source
Version: 1.5-8
Distribution: unstable
Urgency: medium
Maintainer: Debian QA Group <packages@qa.debian.org>
Changed-By: Braulio Henrique Marques Souto <braulio@disroot.org>
Closes: 929647 1024126
Changes:
 hunt (1.5-8) unstable; urgency=medium
 .
   * QA upload.
   * Ran wrap-and-sort.
   * Migrations:
       - debian format from 1.0 to 3.0.
       - debian/copyright to 1.0 format.
       - debian/rules to new (reduced) format.
   * debian/control:
       - Added a Homepage field.
       - Added iptables to Suggests field.
       - Added Rules-Requires-Root field.
       - Added the Vcs-* fields.
       - Bumped Standards-Version to 4.6.1.
       - Improved the long description.
   * debian/docs: created from migrations as a result of the new (reduced)
     format debian/rules to install the upstream README, README.tp and TODO
     files.
   * debian/manpage/*: created files to produce the manpages tpserv.8 and
     transproxy.8.
   * debian/manpages: created to install the manpages.
   * debian/patches/:
       - 000_old.patch: created from migrations debian format from 1.0 to 3.0.
       - 010_fix-manpage.patch: created to change section to 8, fixed macro '..)'
         not define and remove trailing whitespaces.
       - 020_fix-GCC-hardening-hunt.patch: created to add GCC hardening.
       - 030_add-GCC-hardening-tpserv.patch: created to add GCC hardening. Thanks
         to Vagrant Cascadian <vagrant@reproducible-builds.org>.
         (Closes: #1024126)
       - 040_fix-arguments-synchijack.patch: created to fix some strings without
         required arguments.
       - 050_fix-spelling-rstd.patch: created to fix spelling error in source
         code.
   * debian/rules: created override_dh_auto_build to make tpserv binary and fix
     FTCBFS. Thanks to Helmut Grohne <helmut@subdivi.de>. (Closes: #929647)
   * debian/salsa-ci.yml: added to provide CI tests for Salsa.
   * debian/source/lintian-overrides: created to override a message about
     the manpage because it was already sent to upstream. This override
     was requested by lintian.
   * debian/tests/control: created to provide CI tests.
   * debian/upstream/metadata: created.
   * debian/watch: added a fake site to explain about the current status
     of the original upstream homepage.
Checksums-Sha1:
 7c8a459895acd6aebe88e7741349a40b7e47d9b3 1792 hunt_1.5-8.dsc
 d36fe14e8011ba525c8d734f10608e80387b33b8 19308 hunt_1.5-8.debian.tar.xz
 f16996ffdb1bcbba48fb126b1276086611efe32c 5862 hunt_1.5-8_source.buildinfo
Checksums-Sha256:
 053764f19243f9606f80db136cdb46b87dda3820ee1b7dbee152410a613106f6 1792 hunt_1.5-8.dsc
 d7730f4f8c45434c872e4d35c90b1d8523d8958e9f9f0a0ee001f748d91d8e69 19308 hunt_1.5-8.debian.tar.xz
 dc05471fbd718adbe1fea6e145a15b81e181d14d73ec0c6c2dbe02987b928eca 5862 hunt_1.5-8_source.buildinfo
Files:
 6d16a4b261ea3648a761892f1b4c1cae 1792 net optional hunt_1.5-8.dsc
 98f3e4646831f73d80053e49ccdcf160 19308 net optional hunt_1.5-8.debian.tar.xz
 9c99fe71ae03411791ab9485b47ad2fb 5862 net optional hunt_1.5-8_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEENX3LDuyVoBrrofDS3mO5xwTr6e8FAmN3sWsACgkQ3mO5xwTr
6e9ffA/+MVtz2/S7YWmYBWoDA5D1bbPDv4p2tfZ/TIQgZZQVR8x7DrGdOvMil5ui
4/YbvhCyeqtanbinJNmmEUs5tiAtIc02yDAIdZww6KBrpPDAU6oGWXvmabo9j/rf
KV3r3yGhB+Az5Tas0QSAYVodTJHz4l+KenTFGXP1WEPHtYvbzEwLyBJBwVVW+f1k
rnSbnIQD5tt2NhLqGQ1w4nwfqa2zDwnuXTVATI7c3H+nC5q9p0nMq4bfriVE1mBx
yw5doiQF26/KSP2R51V8p8Weg/9dhUWP3YpmDLKqSBhflqgfThKkeFpMm0C4NJav
QjsdJadEVDqkwZ9R/Ov+89Fqyxe3ceWYAEU99NATAPScs7TH91dPfEVDJkaOqlnt
Qy7doCSPCBwciYBM9Remi2jBf9nTQ5eAvyFxGXJYDaO7RsVXlQXWdsZgFYRxXXeb
ggt77e8ZjF7RiIzLEMUyOzGir1Xb2yK0ducuK2sN5mPl8CsQfKv0+uVLYJkYG5rC
IZ3yAgKNsyom99eark02dY0Mgt30LiIEuWLWkiQ8SpQGT7nr0XSk7TinrmEryvgI
cx4m09PKeiT+XyToQ6BrXWMgjzPbeUH8cDnFF/v++zjjqNI9a7hXEmFXs/hg6Fcj
3+6tR+C9zmxP0YFY2rPHtT0exiE4v0gyAzVw/DH8TcI5pwolT6c=
=w+Oz
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: