[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1024286: lcm: reproducible-builds: Embedded build path and usrmerge paths in Makefile



Source: lcm
Severity: normal
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: buildpath usrmerge
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

The build path and binary paths are embedded in
/usr/share/doc/lcm-doc/examples/Makefile:

  https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/diffoscope-results/lcm.html

  ACLOCAL·=·${SHELL}·'/build/1st/lcm-1.3.1+repack1/missing'·aclocal-1.16
  vs.
  ACLOCAL·=·${SHELL}·'/build/2/lcm-1.3.1+repack1/2nd/missing'·aclocal-1.16

  EGREP·=·/bin/grep·-E
  vs.
  EGREP·=·/usr/bin/grep·-E

The attached patch fixes this by removing the example Makefile, which
would have to be regenerated anyways to match the system to run it on.

If removing the example Makefile is not viable, it might be possible to
sanitize the build paths, and all relevent arguments to configure
(e.g. EGREP='/bin/grep -e') to use the specified paths.

According to my local tests, With this patch applied lcm should build
reproducibly on tests.reproducible-builds.org!

Thanks for maintaining lcm!

live well,
  vagrant
From 65bc199c9a7bdb9f8a7fde7dc3aad441105394cf Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@reproducible-builds.org>
Date: Thu, 17 Nov 2022 00:25:41 +0000
Subject: [PATCH] debian/rules: Remove example Makefile that embedded build
 paths and binary paths.

---
 debian/rules | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/debian/rules b/debian/rules
index f29f30d..c9efc4e 100755
--- a/debian/rules
+++ b/debian/rules
@@ -13,6 +13,12 @@ override_dh_auto_install:
 # I build the docs after the 'make install' because the python docs require an installed lcm
 	cd docs; ./build-docs.sh
 
+override_dh_installdocs:
+	dh_installdocs
+	# Remove example makefile which contains build paths and
+	# binary paths
+	rm -vf debian/liblcm-doc/usr/share/doc/liblcm-doc/examples/Makefile
+
 override_dh_auto_clean:
 	dh_auto_clean
 	rm -rf docs/html
-- 
2.38.1

Attachment: signature.asc
Description: PGP signature


Reply to: