[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1021457: olpc-powerd: reproducible-builds: build path embedded in debugging symbols



Source: olpc-powerd
Severity: normal
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: buildpath
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

The build path is embedded in /usr/lib/debug/.dwz/x86_64-linux-gnu/olpc-powerd.debug:

  https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/diffoscope-results/olpc-powerd.html

  /build/1st/olpc-powerd-23
  vs.
  /build/2/olpc-powerd-23/2nd

The attached patch to the upstream Makefile fixes this by appending to
CFLAGS instead of overriding them, allowing the default CFLAGS to be
passed.

According to my local tests, with this patch applied, olpc-powerd should build
reproducibly on tests.reproducible-builds.org!

Thanks for maintaining olpc-powerd!

live well,
  vagrant
From 28c1a60abd0c8dd1c41cfe0d30f755441c941cff Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@reproducible-builds.org>
Date: Mon, 2 May 2022 16:18:08 +0000
Subject: [PATCH] Makefile: Append to CFLAGS.

This allows passing the default flags from dpkg-buildflags.
---
 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Makefile b/Makefile
index 5c0315a..bc1f3c7 100644
--- a/Makefile
+++ b/Makefile
@@ -35,7 +35,7 @@ OPT_FLAGS ?= -O2 -g
 
 PROGS = olpc-switchd pnmto565fb
 
-CFLAGS = -Wall $(OPT_FLAGS) -DVERSION=$(VERSION)
+CFLAGS += -Wall $(OPT_FLAGS) -DVERSION=$(VERSION)
 
 #####
 
-- 
2.37.2

Attachment: signature.asc
Description: PGP signature


Reply to: