[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#989063: marked as done (open-invaders: Sometimes segfaults during gameplay due to array overrun)

Your message dated Sat, 28 May 2022 11:20:49 +0000
with message-id <E1nuuUz-000Ge3-Go@fasolo.debian.org>
and subject line Bug#989063: fixed in open-invaders 0.3-8
has caused the Debian Bug report #989063,
regarding open-invaders: Sometimes segfaults during gameplay due to array overrun
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
989063: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=989063
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: open-invaders
Version: 0.3-4.3+b1
Severity: normal
Tags: patch

Dear Debian QA Team,

The program occasionally segfaults during gameplay. A core 
dump shows that the problem is caused by the collision 
detection routine writing out of bounds on an array.

Specifically, collision_detection() in collision.cc cycles 
through an array explosionbits[] of 500 particles, but does 
not check for wraparound every time it increments the 
current_particle counter. The attached patch fixes the bug 
by moving the wraparound check to immediately after the 
increment.

Thanks for considering,
John G.


-- System Information:
Debian Release: 10.9
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable-debug'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 4.19.0-16-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8), LANGUAGE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages open-invaders depends on:
ii  libaldmb1           1:0.9.3-6+b3
ii  liballegro4.4       2:4.4.2-13
ii  libc6               2.28-10
ii  libdumb1            1:0.9.3-6+b3
ii  libgcc1             1:8.3.0-6
ii  libstdc++6          8.3.0-6
ii  open-invaders-data  0.3-4.3

open-invaders recommends no packages.

open-invaders suggests no packages.

-- no debconf information

Attachment: fix-particle-array-bug.patch
Description: Binary data


--- End Message ---
--- Begin Message --- 
Source: open-invaders
Source-Version: 0.3-8
Done: Adam Borowski <kilobyte@angband.pl>

We believe that the bug you reported is fixed in the latest version of
open-invaders, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 989063@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Adam Borowski <kilobyte@angband.pl> (supplier of updated open-invaders package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sat, 28 May 2022 11:55:46 +0200
Source: open-invaders
Architecture: source
Version: 0.3-8
Distribution: unstable
Urgency: medium
Maintainer: Debian QA Group <packages@qa.debian.org>
Changed-By: Adam Borowski <kilobyte@angband.pl>
Closes: 989063 1011963
Changes:
 open-invaders (0.3-8) unstable; urgency=medium
 .
   * QA upload.
   * Drop 404-compliant git URLs to Salsa.
   * Fix FTBFS on new platforms in a future-proof way, closes: #1011963
   * Mark -data as MA:foreign.
   * Fix an occassional crash during gameplay, closes: #989063 [John G]
Checksums-Sha1:
 f3db3226a1047ed9366264dfaff587706cd52b56 1938 open-invaders_0.3-8.dsc
 2b33e750caf896f6a5dff1888365760ea0d2f7d4 7360 open-invaders_0.3-8.debian.tar.xz
 009932d8916e668cf470cb5672af8374fac7b450 6702 open-invaders_0.3-8_source.buildinfo
Checksums-Sha256:
 54354c6bd2cc0daab1cb1ad2d003fe4dd00cd4f6e6fc3403c323349895283ac3 1938 open-invaders_0.3-8.dsc
 0b8d68b2edb14e5f9a9a11abf414ce0ec382ffac666c5736c0db1285cf5fe519 7360 open-invaders_0.3-8.debian.tar.xz
 dd29660e5ca5e5ab9009dafe9a7052f4150e190e1ae1a7eedb2deee9e6ec88bd 6702 open-invaders_0.3-8_source.buildinfo
Files:
 7ed78f6d10d4004354164a6ba81b5ac8 1938 games optional open-invaders_0.3-8.dsc
 721e802c86637979405aca7b908bfe0c 7360 games optional open-invaders_0.3-8.debian.tar.xz
 26191b3e8a78a91de7459b17f952aa39 6702 games optional open-invaders_0.3-8_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEkjZVexcMh/iCHArDweDZLphvfH4FAmKR/9EACgkQweDZLphv
fH74ShAAoP/7czD2tHZW5iLAEiR3uYl9hzUmZvVl/Uy3dKnbtiFf2XHoaLzEb15P
ujcuJhqL0J5QF5mPqcTdtc2ont34qdRvnmAkwbOBVnh6VRWA2ECV/KBGLLT7Mxtr
Y+BBeeDPsEoc/X3fS2BeaSmhzKE+K5iP/xfcTXMif5kPjpC9gefFoWMiCh35CODw
oEptmd30JThIQpX4kSw27Mv9atX5qI13ECJz8AvxNRjpAoY90erwBOYF8bLOQiH/
qOcZ0Zrw3AbueTckkzyA13aGOTQteGjjeyqE60SPKQUjvEszQnBVYnQXvkTkzy2J
3ADQmLd+wElkCVgwgY8nPd/4frrK7SWBQMqLHIG/7k4TZpx7FYcbyPZqml182URX
i5EvsMGk8N2DfRM4W56+pA3LH8l+3gB1iS2/2fbp8Rpsnlr2q9ZnMIXbvFbWd3gY
JhBTmbKX5TEnd8g2/+4kG15bK6tUjc1ZgH4A2loxvpcw9+FUZK+LeCAjESY6Mo6v
y4hpqucY9bmSai032x/urWT6TabjjKUV9lxptCVCWkZHsjPQvhM33rugrSHp+Ptd
Lb/vl/+L/fchQcB6A4y/Nj53JNNZSGWRtJSFGnGo/5geBnYnmUtbt5Y6nhXrvW8t
q6QzKpB7GkOI+5CKQnMK4y9lDK3nRNy7atjnW0AwsGczPw8cn+c=
=oJKt
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: