[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#777410: marked as done (freecdb: please make the build reproducible)

Your message dated Mon, 23 May 2022 15:41:26 -0700
with message-id <87mtf7vpm1.fsf@contorta>
and subject line Re: Bug#777410: freecdb: please make the build reproducible
has caused the Debian Bug report #777410,
regarding freecdb: please make the build reproducible
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
777410: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=777410
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: freecdb
Version: 0.75
Severity: wishlist
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: timestamps
X-Debbugs-Cc: reproducible-builds@lists.alioth.debian.org

Hi,

While working on the "reproducible builds" effort [1], we have noticed
that freecdb could not be built reproducibly.

The attached patch removes timestamps from the build system. Once
applied, freecdb can be built reproducibly in our current experimental
framework.

 [1]: https://wiki.debian.org/ReproducibleBuilds


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

diff -urNad freecdb.orig/freecdb-0.75/debian/implicit freecdb/freecdb-0.75/debian/implicit
--- freecdb.orig/freecdb-0.75/debian/implicit	2015-02-07 23:31:54.379275616 +0000
+++ freecdb/freecdb-0.75/debian/implicit	2015-02-07 23:49:38.278123708 +0000
@@ -35,7 +35,7 @@
 	    debian/$*/usr/share/doc/$*/changelog'
 	@test -s debian/$*/usr/share/doc/$*/changelog || \
 	  sh -cx 'rm -f debian/$*/usr/share/doc/$*/changelog'
-	@gzip -9 debian/$*/usr/share/doc/$*/changelog*
+	@gzip -9n debian/$*/usr/share/doc/$*/changelog*
 %.deb-docs-docs:
 	@for i in `cat debian/$*.docs 2>/dev/null || :`; do \
 	  if test -d $$i; then \
@@ -54,7 +54,7 @@
 	@if test -r debian/$*.NEWS.Debian; then \
 	  sh -cx 'install -m0644 debian/$*.NEWS.Debian \
 	    debian/$*/usr/share/doc/$*/NEWS.Debian && \
-	      gzip -9 debian/$*/usr/share/doc/$*/NEWS.Debian'; \
+	      gzip -9n debian/$*/usr/share/doc/$*/NEWS.Debian'; \
 	fi
 %.deb-docs-examples:
 	@rm -rf debian/$*/usr/share/doc/$*/examples
diff -urNad freecdb.orig/freecdb-0.75/debian/rules freecdb/freecdb-0.75/debian/rules
--- freecdb.orig/freecdb-0.75/debian/rules	2015-02-07 23:31:54.379275616 +0000
+++ freecdb/freecdb-0.75/debian/rules	2015-02-07 23:49:30.689787988 +0000
@@ -33,7 +33,7 @@
 	install -d -m0755 '$(DIR)'/usr/share/man/man1
 	install -m0644 cdbdump.1 cdbget.1 cdbmake.1 cdbstats.1 \
 	  '$(DIR)'/usr/share/man/man1/
-	gzip -9 '$(DIR)'/usr/share/man/man1/*.1
+	gzip -9n '$(DIR)'/usr/share/man/man1/*.1
 
 binary-indep:

--- End Message ---
--- Begin Message --- 
Version: 0.76

On 2020-09-03, Chris Lamb wrote:
>> And can you please check again if it still has the problem?
>> d/rules has been completely rewritten with 0.76 version and so the
>> patch will not apply anymore.
>
> Rechecking.. okay, so there is now a different set of problem or
> problems that I can't immediately resolve, so I am removing the
> "patch" tag for now.

It looks like 0.76 switched to dh, which appears to have fixed the
timestamp issues caused by manual calls to gzip in debian/rules!

It appears freecdb *is* reproducible on bullseye and bookworm, where
build paths are not tested:

  https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/diffoscope-results/freecdb.html

Noticed this bug as I just submitted a patch to also fix the build path
issues... :)


live well,
  vagrant

Attachment: signature.asc
Description: PGP signature


--- End Message ---
Reply to: