[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1010414: marked as done (libcec: reproducible builds: Embeds kernel version in libcec.so.*)

Your message dated Sun, 01 May 2022 01:18:46 +0000
with message-id <E1nkyEY-0005Ja-SA@fasolo.debian.org>
and subject line Bug#1010414: fixed in libcec 6.0.2-4
has caused the Debian Bug report #1010414,
regarding libcec: reproducible builds: Embeds kernel version in libcec.so.*
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1010414: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1010414
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: libcec
Severity: normal
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: kernel
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

The running kernel of the build machine is embedded in libcec.so.*:

  https://tests.reproducible-builds.org/debian/rb-pkg/bookworm/amd64/diffoscope-results/libcec.html

  ./usr/lib/x86_64-linux-gnu/libcec.so.6.0.2

  compiled·on·Linux-5.16.0-0.bpo.4-amd64·...·,·features:·P8_USB,·DRM,·P8_detect,·randr,·Exynos,·Linux,·AOCEC
vs.
  compiled·on·Linux-5.10.0-13-amd64·...·,·features:·P8_USB,·DRM,·P8_detect,·randr,·Exynos,·Linux,·AOCEC


The attached patch updates the existing reproducible builds patch to use
CMAKE_SYSTEM_NAME instead of CMAKE_SYSTEM (which includes the running
kernel version).

With this patch applied, libcec should build reproducibly on
tests.reproducible-builds.org when it migrates to bookworm/testing!


To get it building reproducibly in unstable and experimental where
differing build paths are tested, it also needs to apply one of the
standard fixes mentioned here:

  https://tests.reproducible-builds.org/debian/issues/cmake_rpath_contains_build_path_issue.html


I intend to fix both issues shortly.


Thanks for maintaining libcec!


live well,
  vagrant

From 9f3a10d425e92281399a669effdb76e24d02b6ae Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@reproducible-builds.org>
Date: Sat, 30 Apr 2022 23:55:26 +0000
Subject: [PATCH 2/2] debian/patches: Update reproducible build patch to use
 Use CMAKE_SYSTEM_NAME instead of CMAKE_SYSTEM.

CMAKE_SYSTEM contains the running kernel version, which is likely to
be different between two builds.

https://tests.reproducible-builds.org/debian/issues/unstable/captures_kernel_version_via_CMAKE_SYSTEM_issue.html
---
 debian/patches/03_reproducible_build.patch | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/debian/patches/03_reproducible_build.patch b/debian/patches/03_reproducible_build.patch
index 8d995bb..3611c36 100644
--- a/debian/patches/03_reproducible_build.patch
+++ b/debian/patches/03_reproducible_build.patch
@@ -1,6 +1,7 @@
 Description: Remove non-determinism from build process
  .
 Author: Balint Reczey <balint@balintreczey.hu>
+Updated: Vagrant Cascadian <vagrant@reproducible-builds.org>
 Forwarded: not-needed
 --- a/src/libcec/CMakeLists.txt
 +++ b/src/libcec/CMakeLists.txt
@@ -9,7 +10,7 @@ Forwarded: not-needed
  
  # platform and device specific
 -include(cmake/SetBuildInfo.cmake)
-+set(LIB_INFO "compiled on ${CMAKE_SYSTEM} ... ")
++set(LIB_INFO "compiled on ${CMAKE_SYSTEM_NAME} ... ")
  include(cmake/CheckPlatformSupport.cmake)
  
  ## create project groups
-- 
2.30.2

Attachment: signature.asc
Description: PGP signature


--- End Message ---
--- Begin Message --- 
Source: libcec
Source-Version: 6.0.2-4
Done: Vagrant Cascadian <vagrant@debian.org>

We believe that the bug you reported is fixed in the latest version of
libcec, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1010414@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Vagrant Cascadian <vagrant@debian.org> (supplier of updated libcec package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sat, 30 Apr 2022 17:50:08 -0700
Source: libcec
Architecture: source
Version: 6.0.2-4
Distribution: unstable
Urgency: medium
Maintainer: Debian QA Group <packages@qa.debian.org>
Changed-By: Vagrant Cascadian <vagrant@debian.org>
Closes: 1010414
Changes:
 libcec (6.0.2-4) unstable; urgency=medium
 .
   * QA upload.
   * debian/rules: Pass -DCMAKE_BUILD_RPATH_USE_ORIGIN=ON via
     dh_auto_configure override.
   * debian/patches: Update reproducible build patch to use Use
     CMAKE_SYSTEM_NAME instead of CMAKE_SYSTEM. (Closes: #1010414)
   * debian/control: Set Rules-Requires-Root to "no".
   * Update to debhelper-compat 13.
   * debian/control: Update Standards-Version to 4.6.0.
Checksums-Sha1:
 95fb0675dd8f196ce175dd44c794e12f0cde2937 1547 libcec_6.0.2-4.dsc
 7c6186529334e6d6fb6fe2b3eac15c4cce47d8b2 7952 libcec_6.0.2-4.debian.tar.xz
 ee2903419ee3e4a507019edfb8b16a1287a3aeec 9347 libcec_6.0.2-4_arm64.buildinfo
Checksums-Sha256:
 b97f4640e035c1300d562d3bfcf114bf08511fbf6bb1841f7697ffa2b9292677 1547 libcec_6.0.2-4.dsc
 aaf363d7561d00d3697ece6a9fa467899c835f2b14a46c4f7ecd3535c04e51f7 7952 libcec_6.0.2-4.debian.tar.xz
 f93d7e76838eeab2c9eda89ce367219aa90804c43810cdae7c70e004eb105686 9347 libcec_6.0.2-4_arm64.buildinfo
Files:
 b0ea9f36443886abcb129999131f4990 1547 libs optional libcec_6.0.2-4.dsc
 4a9d2bb4e2d8c7695d4beca9dd7af889 7952 libs optional libcec_6.0.2-4.debian.tar.xz
 d88db387ba22924f62d30c66248326c2 9347 libs optional libcec_6.0.2-4_arm64.buildinfo

-----BEGIN PGP SIGNATURE-----

iIkEARYKADEWIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCYm3cSRMcdmFncmFudEBk
ZWJpYW4ub3JnAAoJENxRj8h/lxaqOf4A/3m3WkeC0pTnVkyOqCOrqf+2fE+RJhH9
TekdcnKqO5QrAP0XM4L52G+dhqNrE6XewtRWxvJmFZ5Q5gK7611chh6XBA==
=WJc5
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: