[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#994976: xtermcontrol: please make the build reproducible



On 2021-09-24, Chris Lamb wrote:
> Whilst working on the Reproducible Builds effort [0] we noticed that
> xtermcontrol could not be built reproducibly.
...
> --- a/debian/rules	2021-09-24 09:20:53.800313098 +0100
> --- b/debian/rules	2021-09-24 09:35:32.356026521 +0100
> @@ -5,9 +5,15 @@
>  
>  export DEB_BUILD_MAINT_OPTIONS=hardening=+all
>  
> +PACKAGE_YEAR = $(shell date --utc --date=@$(SOURCE_DATE_EPOCH) '+%Y')
> +PACKAGE_DATE = $(shell date --utc --date=@$(SOURCE_DATE_EPOCH) +'%B %d, %Y')

I think this should use %Y-%m-%d instead, as %B is a locale-dependent
month name.

> +
>  %:
>  	dh $@
>  
> +override_dh_auto_build:
> +	dh_auto_build -- PACKAGE_YEAR="$(PACKAGE_YEAR)" PACKAGE_DATE="$(PACKAGE_DATE)"
> +
>  override_dh_auto_test:
>  ifeq (,$(filter nocheck,$(DEB_BUILD_OPTIONS)))
>  	xvfb-run xterm -e '( dh_auto_test ; echo $$? ) | tee debian/xterm_dh_auto_test.log'

This package appears to be part of the QA team, so could be uploaded by
anyone... I'd consider uploading the fix, unless you'd like to do the
honors?


live well,
  vagrant

Attachment: signature.asc
Description: PGP signature


Reply to: