[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1010379: marked as done (snacc: reproducible builds: timestamp embedded in header files)

Your message dated Sat, 30 Apr 2022 01:48:44 +0000
with message-id <E1nkcE0-0009y0-At@fasolo.debian.org>
and subject line Bug#1010379: fixed in snacc 1.3.1-9
has caused the Debian Bug report #1010379,
regarding snacc: reproducible builds: timestamp embedded in header files
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1010379: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1010379
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: snacc
Severity: normal
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: timestamps
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

Various header files embed the timestamp when it was generated in
comments:

  https://tests.reproducible-builds.org/debian/rb-pkg/bookworm/amd64/diffoscope-results/snacc.html

  /usr/include/snacc/c/asn-useful.h

  ·*····This·.h·file·was·generated·by·snacc·on·Fri·May·19·17:42:30·2023
  vs.
  ·*····This·.h·file·was·generated·by·snacc·on·Sun·Apr·17·13:25:08·2022


The attached patch fixes this by removing the timestamps from the code
that generates the header files.


With this patch applied, snacc should become reproducible on
tests.reproducible-builds.org!


live well,
  vagrant

From d44bf7e4857b23f94319aabf0bd3124a9b11ce58 Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@reproducible-builds.org>
Date: Fri, 29 Apr 2022 23:05:46 +0000
Subject: [PATCH] reproducible builds: Remove timestamps from generated
 comments.

https://reproducible-builds.org/docs/timestamps/
---
 compiler/back-ends/c++-gen/gen-code.c | 4 ++--
 compiler/back-ends/c-gen/gen-code.c   | 4 ++--
 compiler/back-ends/idl-gen/gen-code.c | 2 +-
 compiler/core/snacc.c                 | 2 +-
 4 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/compiler/back-ends/c++-gen/gen-code.c b/compiler/back-ends/c++-gen/gen-code.c
index d3632dd..8d15682 100644
--- a/compiler/back-ends/c++-gen/gen-code.c
+++ b/compiler/back-ends/c++-gen/gen-code.c
@@ -170,7 +170,7 @@ PrintHdrComment PARAMS ((hdr, m),
     fprintf (hdr, "//\n");
     fprintf (hdr, "// %s - class definitions for ASN.1 module %s\n", m->cxxHdrFileName, m->modId->name);
     fprintf (hdr, "//\n");
-    fprintf (hdr, "//   This file was generated by snacc on %s", ctime (&now));
+    fprintf (hdr, "//   This file was generated by snacc");
     fprintf (hdr, "//   UBC snacc by Mike Sample\n");
     fprintf (hdr, "//   A couple of enhancements made by IBM European Networking Center\n"); /* 20.8.93 Thomas Meyer */
     fprintf (hdr, "\n");
@@ -188,7 +188,7 @@ PrintSrcComment PARAMS ((src, m),
     fprintf (src, "//\n");
     fprintf (src, "// %s - class member functions for ASN.1 module %s\n", m->cxxSrcFileName, m->modId->name);
     fprintf (src, "//\n");
-    fprintf (src, "//   This file was generated by snacc on %s", ctime (&now));
+    fprintf (src, "//   This file was generated by snacc");
     fprintf (src, "//   UBC snacc written by Mike Sample\n");
     fprintf (src, "//   A couple of enhancements made by IBM European Networking Center\n"); /* 20.8.93 Thomas Meyer */
     fprintf (src, "\n");
diff --git a/compiler/back-ends/c-gen/gen-code.c b/compiler/back-ends/c-gen/gen-code.c
index e5c94d9..a198676 100644
--- a/compiler/back-ends/c-gen/gen-code.c
+++ b/compiler/back-ends/c-gen/gen-code.c
@@ -182,7 +182,7 @@ PrintCSrcComment PARAMS ((src, m),
     fprintf (src, "/*\n");
     fprintf (src, " *    %s\n *\n", m->cSrcFileName);
     fprintf (src, " *    \"%s\" ASN.1 module encode/decode/print/free C src.\n *\n", m->modId->name);
-    fprintf (src, " *    This file was generated by snacc on %s *\n", ctime (&t));
+    fprintf (src, " *    This file was generated by snacc *\n");
     fprintf (src, " *    UBC snacc written by Mike Sample\n *\n");
     fprintf (src, " *    NOTE: This is a machine generated file - editing not recommended\n");
     fprintf (src, " */\n\n\n");
@@ -231,7 +231,7 @@ PrintCHdrComment PARAMS ((f, m),
     fprintf (f, "/*\n");
     fprintf (f, " *    %s\n *\n", m->cHdrFileName);
     fprintf (f, " *    \"%s\" ASN.1 module C type definitions and prototypes\n *\n", m->modId->name);
-    fprintf (f, " *    This .h file was generated by snacc on %s *\n", ctime (&t));
+    fprintf (f, " *    This .h file was generated by snacc *\n");
     fprintf (f, " *    UBC snacc written compiler by Mike Sample\n *\n");
     fprintf (f, " *    NOTE: This is a machine generated file--editing not recommended\n");
     fprintf (f, " */\n\n\n");
diff --git a/compiler/back-ends/idl-gen/gen-code.c b/compiler/back-ends/idl-gen/gen-code.c
index 9e4c9c2..978e5a6 100644
--- a/compiler/back-ends/idl-gen/gen-code.c
+++ b/compiler/back-ends/idl-gen/gen-code.c
@@ -70,7 +70,7 @@ PrintComment PARAMS ((idl, m),
     fprintf (idl, "//\n");
     fprintf (idl, "// %s -- IDL for ASN.1 module %s\n", m->idlFileName, m->modId->name);
     fprintf (idl, "//\n");
-    fprintf (idl, "//   This file was generated by snacc on %s", ctime (&t));
+    fprintf (idl, "//   This file was generated by snacc");
     fprintf (idl, "//   UBC snacc written by Mike Sample\n");
     fprintf (idl, "//   IDL generator written by Robert Joop\n");
     fprintf (idl, "\n");
diff --git a/compiler/core/snacc.c b/compiler/core/snacc.c
index 96b2683..9b86b9f 100644
--- a/compiler/core/snacc.c
+++ b/compiler/core/snacc.c
@@ -1125,7 +1125,7 @@ GenCxxCode PARAMS ((allMods, longJmpVal, genTypes, genValues, genEncoders, genDe
 	fprintf (meta.srcfp, "//\n");
 	fprintf (meta.srcfp, "// modules.C - reference to all modules and their types\n");
 	fprintf (meta.srcfp, "//\n");
-	fprintf (meta.srcfp, "// This file was generated by snacc on %s", ctime (&now));
+	fprintf (meta.srcfp, "// This file was generated by snacc");
     }
 #endif
     FOR_EACH_LIST_ELMT (currMod, allMods)
-- 
2.30.2

Attachment: signature.asc
Description: PGP signature


--- End Message ---
--- Begin Message --- 
Source: snacc
Source-Version: 1.3.1-9
Done: Vagrant Cascadian <vagrant@debian.org>

We believe that the bug you reported is fixed in the latest version of
snacc, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1010379@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Vagrant Cascadian <vagrant@debian.org> (supplier of updated snacc package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Fri, 29 Apr 2022 18:33:59 -0700
Source: snacc
Architecture: source
Version: 1.3.1-9
Distribution: unstable
Urgency: medium
Maintainer: Debian QA Group <packages@qa.debian.org>
Changed-By: Vagrant Cascadian <vagrant@debian.org>
Closes: 1010379
Changes:
 snacc (1.3.1-9) unstable; urgency=medium
 .
   * QA upload.
   * debian/patches: Remove timestamps from generated headers.
     (Closes: #1010379)
   * debian/control: Update Vcs-* headers.
   * debian/control: Set Rules-Requires-Root to "no".
   * debian/changelog: Remove trailing whitespace.
   * Update to debhelper-compat 13.
   * Remove dh-autoreconf, now the default with debhelper compat 13.
   * debian/rules: Pass --no-parallel to dh.
   * debian/rules: Add dh_missing override to pass --list-missing.
   * debian/control: Update Standards-Version to 4.6.0.
   * snacc-doc: Update location of snacc-a5.ps
   * debian/control: Drop Build-Depends on autotools-dev, now the default
     debhelper compat 13.
Checksums-Sha1:
 fd3a833a8d7c90decfca9283531009508c032280 1454 snacc_1.3.1-9.dsc
 87a7166b0d70cbd39241ee80d6145a4f6fb8f509 14440 snacc_1.3.1-9.debian.tar.xz
 dfd99cef7b72993cf90c8dd60ef6802c125a7598 6469 snacc_1.3.1-9_amd64.buildinfo
Checksums-Sha256:
 4ca98b3e058a323d2ab45f1502803af46340c7eb4eed8ae83c6a046b2d1be717 1454 snacc_1.3.1-9.dsc
 83f73ff023f2e5237c090a5e1b3dbff6654234fd443b326abe1715f7181a2423 14440 snacc_1.3.1-9.debian.tar.xz
 c11eff79b53269e3683dbb89dd25b1db42ec6fc38e39cd9a77229aef26f62ae8 6469 snacc_1.3.1-9_amd64.buildinfo
Files:
 8204e9b1569f82a9b3af68025295b589 1454 devel optional snacc_1.3.1-9.dsc
 cd7744838cd06a8e91d00fe85e6a4641 14440 devel optional snacc_1.3.1-9.debian.tar.xz
 042a898aa432a90b16423716e349540a 6469 devel optional snacc_1.3.1-9_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iIkEARYKADEWIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCYmyTVRMcdmFncmFudEBk
ZWJpYW4ub3JnAAoJENxRj8h/lxaqnTYA/it/w2a/s719mKJ4lBAeoLWkbzj7HwKT
/Zy05nm2aCOyAQDjMkI+7acq470e0QqmUqoN6yb1LfDk+c2G14tAfxg4Bw==
=LibX
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: