[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1003412: marked as done (9base build system always strips)

Your message dated Fri, 18 Mar 2022 03:04:44 +0000
with message-id <E1nV2uy-000IUS-84@fasolo.debian.org>
and subject line Bug#1003412: fixed in 9base 1:6-12
has caused the Debian Bug report #1003412,
regarding 9base build system always strips
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1003412: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1003412
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: 9base
Version: 1:6-11
Tags: patch
User: debian-cross@lists.debian.org
Usertags: ftcbfs

The 9base build system strips binaries unconditionally. This has
multiple consequences:
 * There is no -dbgsym package.
 * DEB_BUILD_OPTIONS=nostrip produces stripped binaries.
 * It fails using the build architecture strip during cross builds.

The solution to all of these is not letting the upstream build system
strip and rely on dh_strip. Please consider applying the attached patch.

Helmut

diff --minimal -Nru 9base-6/debian/changelog 9base-6/debian/changelog
--- 9base-6/debian/changelog	2021-02-28 09:30:20.000000000 +0100
+++ 9base-6/debian/changelog	2022-01-09 18:05:44.000000000 +0100
@@ -1,3 +1,9 @@
+9base (1:6-12) UNRELEASED; urgency=medium
+
+  * Don't let the build system strip. (Closes: #-1)
+
+ -- Helmut Grohne <helmut@subdivi.de>  Sun, 09 Jan 2022 18:05:44 +0100
+
 9base (1:6-11) unstable; urgency=medium
 
   * QA upload.
diff --minimal -Nru 9base-6/debian/patches/nostrip.patch 9base-6/debian/patches/nostrip.patch
--- 9base-6/debian/patches/nostrip.patch	1970-01-01 01:00:00.000000000 +0100
+++ 9base-6/debian/patches/nostrip.patch	2022-01-09 18:05:32.000000000 +0100
@@ -0,0 +1,40 @@
+--- 9base-6.orig/config.mk
++++ 9base-6/config.mk
+@@ -22,3 +22,4 @@
+ AR          = ar rc
+ CC          = cc
+ YACC        = ../yacc/9yacc
++STRIP       = strip
+--- 9base-6.orig/diff/Makefile
++++ 9base-6/diff/Makefile
+@@ -8,7 +8,7 @@
+ include ../config.mk
+ 
+ all: ${TARG}
+-	@strip ${TARG}
++	@$(STRIP) ${TARG}
+ 	@echo built ${TARG}
+ 
+ install: ${TARG}
+--- 9base-6.orig/sam/Makefile
++++ 9base-6/sam/Makefile
+@@ -10,7 +10,7 @@
+ include ../config.mk
+ 
+ all: ${TARG}
+-	@strip ${TARG}
++	@$(STRIP) ${TARG}
+ 	@echo built ${TARG}
+ 
+ install: ${TARG}
+--- 9base-6.orig/std.mk
++++ 9base-6/std.mk
+@@ -6,7 +6,7 @@
+ include ../config.mk
+ 
+ all: ${TARG}
+-	@strip ${TARG}
++	@$(STRIP) ${TARG}
+ 	@echo built ${TARG}
+ 
+ install: install-default post-install
diff --minimal -Nru 9base-6/debian/patches/series 9base-6/debian/patches/series
--- 9base-6/debian/patches/series	2021-02-28 09:15:00.000000000 +0100
+++ 9base-6/debian/patches/series	2022-01-09 18:04:19.000000000 +0100
@@ -8,3 +8,4 @@
 0008-rc-Default-to-a-traditional-prompt.patch
 0009-fix-non-verbose-build.patch
 0010-applied-Alexander-Clouter-s-9base-sha1sum-patch.patch
+nostrip.patch
diff --minimal -Nru 9base-6/debian/rules 9base-6/debian/rules
--- 9base-6/debian/rules	2021-02-28 08:38:39.000000000 +0100
+++ 9base-6/debian/rules	2022-01-09 18:05:42.000000000 +0100
@@ -28,7 +28,7 @@
 override_dh_auto_build:
 	dh_auto_build -- \
 		CFLAGS='$(CFLAGS) $(CPPFLAGS)' LDFLAGS='$(LDFLAGS)' \
-		PREFIX=$(PREFIX) MANPREFIX=$(MANDIR)
+		PREFIX=$(PREFIX) MANPREFIX=$(MANDIR) STRIP=true
 
 override_dh_auto_install:
 	dh_auto_install -- \

--- End Message ---
--- Begin Message --- 
Source: 9base
Source-Version: 1:6-12
Done: Joao Eriberto Mota Filho <eriberto@debian.org>

We believe that the bug you reported is fixed in the latest version of
9base, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1003412@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Joao Eriberto Mota Filho <eriberto@debian.org> (supplier of updated 9base package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Thu, 17 Mar 2022 17:15:01 -0300
Source: 9base
Architecture: source
Version: 1:6-12
Distribution: unstable
Urgency: medium
Maintainer: Debian QA Group <packages@qa.debian.org>
Changed-By: Joao Eriberto Mota Filho <eriberto@debian.org>
Closes: 1003412
Changes:
 9base (1:6-12) unstable; urgency=medium
 .
   * QA upload.
   * Changed the system to rely on dh_strip, avoiding an upstream build system
     strip. Thanks to Helmut Grohne <helmut@subdivi.de>. Consequently:
       - debian/patches/0011-nostrip.patch: created to make adjustments in
         upstream source code.
       - debian/rules: added a STRIP variable.
       - Closes: #1003412
   * debian/control: bumped Standards-Version to 4.6.0.
   * debian/copyright: updated packaging copyright data.
   * debian/lintian-overrides: updated some overrides to be compliant with the
     most recent lintian.
   * debian/tests/control: removed tests using ampersand to run in background.
   * debian/upstream/metadata: created.
Checksums-Sha1:
 6e89e1ef3fe9b08019f1d0389fdd20969b4c801c 1802 9base_6-12.dsc
 958085e5fc27dc8220ad9bb3acac32bc0b8e67dc 18516 9base_6-12.debian.tar.xz
 d22afb6b357f33022c9a8a761974367e05b10941 5609 9base_6-12_source.buildinfo
Checksums-Sha256:
 30c28063627f15e92045e53faa0a81a68ba858a572dc2339a19acb3591e3f486 1802 9base_6-12.dsc
 1711cb40f1f2f13c0d16430d9b2680f0519458a2f39a6bf120875a1900f27489 18516 9base_6-12.debian.tar.xz
 b1b63ee69ceece1816f44a4beaabd2214f0566fab9646b70eba56349d6e07f1d 5609 9base_6-12_source.buildinfo
Files:
 fbb896413f40bfedfd4cd9ec3b61c91f 1802 utils optional 9base_6-12.dsc
 96c1a94b992453365e1e5b3cd1e71d2f 18516 utils optional 9base_6-12.debian.tar.xz
 975499565c1440de9597062587f3fde9 5609 utils optional 9base_6-12_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEENX3LDuyVoBrrofDS3mO5xwTr6e8FAmIz7OAACgkQ3mO5xwTr
6e+oQxAAjUZMC9wA3GxsmPTPPXF/VTOlInM1b20xMvQQo9YCYT6O05Tz+Yhp8xRr
EOUerSzBJ5s3v0mJ4SX4A6ibYwtY9RhoTG3x/q+2B7ryEi63rQNqdKxchpLOVgWz
YYhnGEEl2j07I7Vz+MpkC7kYebk9LJevAQB4inJn7irGgXQMpPuGzI0gGWMfARow
Qe1CaH7rSeZh8+jqxnktrfrH/BoUErjjnka9kXIWfC+tq+UGDCmKUz4Q0rpEynvu
eJ4U6w8Z3wV7LSLDcsnonLFPK9+CDWDI+o91cOjRgiLdWxz8qr7jcWZhr3z//NbD
e3rkXBBgpwNGHAcmbncs1bXcelBn+DNVX6dOI3QqV8EjklPHR7T5lp1r0kWJIWXM
knRZIq30iesbdVS03dNiK2DwBrmz9HLxEv7UPRXQmg5VDlRnaUDlhhMGEh5PHUYm
I9/4bwdQjBS10yJv8/RZluy4RugZy8chtE6CRkMbwl9PpcqWdmrwomLC/r6ZFKGh
u90cjWs5EKMvJdM6QAkAyYFOSJlIx8T6Dj2Bs82d35K8FZgt3znmAWLF6lGFrhBM
UcMP++swBMY0+5BNLDvLVSyO6vJ1GxzbSAnAxjFJqasxf3qowT26jyr3UsoqdRXe
aARDICkuO7DzRIx57wkc/TwOeyP17145v0pp8AxFTDDFp/UpoTQ=
=ImA4
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: