Bug#996534: netkit-telnet: Specifying a port in telnetrc is not working
Package: netkit-telnet
Followup-For: Bug #996534
User: ubuntu-devel@lists.ubuntu.com
Usertags: origin-ubuntu ubuntu-patch
Dear Maintainer,
*** /tmp/tmpn1vxgjaz/bug_body
In Ubuntu, the attached patch was applied to achieve the following:
* Description: Fix Bug-Specifying a port in telnetrc is not working
telnetrc parsing routine ( readrc() function in telnet/command.cc )
has a flaw in comparing the port number of command-line with that
of telnetrc To proceed command processing, the result of string
compare MUST not negated
Thanks for considering the patch.
-- System Information:
Debian Release: bullseye/sid
APT prefers focal-updates
APT policy: (500, 'focal-updates'), (500, 'focal-security'), (500, 'focal'), (100, 'focal-backports')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 5.11.0-36-generic (SMP w/8 CPU cores)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
diff -Nru netkit-telnet-0.17/debian/patches/port-telnetrc netkit-telnet-0.17/debian/patches/port-telnetrc
--- netkit-telnet-0.17/debian/patches/port-telnetrc 1970-01-01 09:00:00.000000000 +0900
+++ netkit-telnet-0.17/debian/patches/port-telnetrc 2021-10-15 11:36:04.000000000 +0900
@@ -0,0 +1,32 @@
+Description: Fix Bug-Specifying a port in telnetrc is not working
+ telnetrc parsing routine ( readrc() function in telnet/command.cc )
+ has a flaw in comparing the port number of command-line with that
+ of telnetrc To proceed command processing, the result of string
+ compare MUST not negated
+ .
+ netkit-telnet (0.17-41.2ubuntu2) UNRELEASED; urgency=medium
+ .
+
+Author: Dongho Chang <dong579@gmail.com>
+
+---
+Bug-Debian: https://bugs.debian.org/996534
+Bug-Ubuntu: https://bugs.launchpad.net/bugs/1891021
+Last-Update: 2021-10-15
+
+--- netkit-telnet-0.17.orig/telnet/commands.cc
++++ netkit-telnet-0.17/telnet/commands.cc
+@@ -2135,7 +2135,7 @@ static void readrc(const char *m1, const
+ continue;
+
+ if (line[0] == ':') {
+- if (!strncasecmp(&line[1], port, lport))
++ if (strncasecmp(&line[1], port, lport))
+ continue;
+ strncpy(line, &line[lport + 1], sizeof(line) - lport - 1);
+ }
diff -Nru netkit-telnet-0.17/debian/patches/series netkit-telnet-0.17/debian/patches/series
--- netkit-telnet-0.17/debian/patches/series 2019-02-24 22:25:14.000000000 +0900
+++ netkit-telnet-0.17/debian/patches/series 2021-10-15 11:36:04.000000000 +0900
@@ -14,3 +14,4 @@
142-numeric_hosts.diff
use-cmake-as-buildsystem.patch
use-cmake-as-buildsystem-debian-extras.patch
+port-telnetrc
Reply to: