[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#901333: marked as done (mp3rename FTCBFS: does not pass cross tools to make)

Your message dated Wed, 16 Jun 2021 19:33:31 +0000
with message-id <E1ltbI3-00034I-7h@fasolo.debian.org>
and subject line Bug#901333: fixed in mp3rename 0.6-11
has caused the Debian Bug report #901333,
regarding mp3rename FTCBFS: does not pass cross tools to make
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
901333: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=901333
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: mp3rename
Version: 0.6-10
Tags: patch
User: helmutg@debian.org
Usertags: rebootstrap

mp3rename fails to cross build from source, because it does not pass
cross tools to make. The easiest way of fixing that is using
dh_auto_build. Unfortunately, it's not that easy as mp3rename uses
help2man. I really recommend using a proper manpage. In the presence of
help2man, we can build mp3rename twice: Once for help2man and then for
real. The attached patch implements that and makes mp3rename cross
buildable. Please consider applying the attached patch.

Helmut

diff -u mp3rename-0.6/debian/changelog mp3rename-0.6/debian/changelog
--- mp3rename-0.6/debian/changelog
+++ mp3rename-0.6/debian/changelog
@@ -1,3 +1,12 @@
+mp3rename (0.6-10.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Fix FTCBFS: (Closes: #-1)
+    + Build twice: once for help2man and once for real.
+    + Let dh_auto_build pass cross tools to make.
+
+ -- Helmut Grohne <helmut@subdivi.de>  Mon, 11 Jun 2018 16:52:27 +0200
+
 mp3rename (0.6-10) unstable; urgency=medium
 
   * QA upload.
diff -u mp3rename-0.6/debian/rules mp3rename-0.6/debian/rules
--- mp3rename-0.6/debian/rules
+++ mp3rename-0.6/debian/rules
@@ -8,6 +8,9 @@
 # This is the debhelper compatability version to use.
 #export DH_COMPAT=3
 
+include /usr/share/dpkg/architecture.mk
+export DEB_BUILD_MAINT_OPTIONS=hardening=-format
+
 configure: configure-stamp
 configure-stamp:
 	dh_testdir
@@ -20,12 +23,15 @@
 build-stamp:
 	dh_testdir
 
-	# Add here commands to compile the package.
-	$(MAKE)
+	dpkg-architecture -a$(DEB_BUILD_ARCH) -f -c dh_auto_build
 	#/usr/bin/docbook-to-man debian/mp3rename.sgml > mp3rename.1
 	/usr/bin/help2man -h -h -v '-s help' -S 'Debian GNU/Linux' \
 		-N -o mp3rename.1 -n 'Rename mp3 files based on id3tags' \
 		./mp3rename
+ifneq ($(DEB_BUILD_ARCH),$(DEB_HOST_ARCH))
+	dh_auto_clean
+	dh_auto_build
+endif
 
 	touch build-stamp

--- End Message ---
--- Begin Message --- 
Source: mp3rename
Source-Version: 0.6-11
Done: David da Silva Polverari <david.polverari@gmail.com>

We believe that the bug you reported is fixed in the latest version of
mp3rename, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 901333@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
David da Silva Polverari <david.polverari@gmail.com> (supplier of updated mp3rename package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Tue, 15 Jun 2021 17:06:54 +0000
Source: mp3rename
Architecture: source
Version: 0.6-11
Distribution: experimental
Urgency: medium
Maintainer: Debian QA Group <packages@qa.debian.org>
Changed-By: David da Silva Polverari <david.polverari@gmail.com>
Closes: 272221 431297 772199 901333
Changes:
 mp3rename (0.6-11) experimental; urgency=medium
 .
   * QA upload.
   * Migrations:
       - DH to new level format. Consequently:
           ~ debian/compat: removed.
           ~ debian/control: changed from 'debhelper' to 'debhelper-compat' in
             Build-Depends field and bumped level to 13.
       - DebSrc to 3.0.
       - debian/copyright to 1.0 format.
       - debian/rules to new (reduced) format.
   * Ran wrap-and-sort.
   * debian/changelog: removed trailing whitespace and cruft.
   * debian/clean: created to remove auto-generated manpage.
   * debian/control:
       - Added 'Rules-Requires-Root: no' to source stanza.
       - Added the Vcs-* fields.
       - Bumped Standards-Version to 4.5.1.
       - Removed help2man from Build-Depends, as it is no longer needed.
   * debian/copyright: updated upstream and packaging copyright information.
   * debian/manpages: created to install static manpage. Also, along with
     using dh sequencer in debian/rules, fixes FTCBFS. Thanks to Helmut Grohne
     <helmut@subdivi.de> (Closes: #901333).
   * debian/mp3rename.1: created by using help2man and formatted manually.
   * debian/patches/:
       - 010_old-makefile-diffs.patch:
           ~ Added to include all previous Makefile diffs from old Debian format
             packaging.
           ~ Included $(CPPFLAGS) and $(LDFLAGS) as compiler flags to allow
             hardening.
           ~ Using $(DESTDIR) to support staged installs.
       - 020_old-source-diffs.patch: added to include all previous mp3rename.c
         diffs from old Debian format packaging.
       - 030_fix-format-string.patch: added to fix a format string vulnerability.
       - 040_dont_open_rdwr.patch: added to avoid unnecessarily opening files
         RDWR. Thanks to Joey Hess <id@joeyh.name> (Closes: #772199).
       - 050_recognize_dashp_option.patch: added to recognize the -p option.
         Thanks to Shaun Jackman <sjackman@gmail.com> (Closes: #272221, #431297,
         LP: #199853).
   * debian/salsa-ci.yml: added to provide CI tests for Salsa.
   * debian/tests/control: created to perform CI tests.
   * debian/upstream/metadata: created.
Checksums-Sha1:
 a59c51413d8adac040534be3ea16e6172b49a809 1805 mp3rename_0.6-11.dsc
 460642ef762fee39803a4c269ae74bbf0dc2dcf5 6828 mp3rename_0.6-11.debian.tar.xz
 35a6bd810da421081cfde68b22abad183df49c58 5307 mp3rename_0.6-11_source.buildinfo
Checksums-Sha256:
 6302226f13395cf1e800851b930f2c97b4771276a4447236bb640e3d0a5c02d8 1805 mp3rename_0.6-11.dsc
 a3332308cce04372a912f6d426170e1eedd9dcfed345a8f3e9d365655b2950f1 6828 mp3rename_0.6-11.debian.tar.xz
 e3d448954ba3a12efa126bfd15582dd80a22dcad685cc229fe5a1f5a1089b34c 5307 mp3rename_0.6-11_source.buildinfo
Files:
 c1ae450b68d5306fc6afed764b72c116 1805 sound optional mp3rename_0.6-11.dsc
 786c10b2ee7a048034d0e69e3357fe56 6828 sound optional mp3rename_0.6-11.debian.tar.xz
 0754772bf1454481f47795b2299afede 5307 sound optional mp3rename_0.6-11_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEENX3LDuyVoBrrofDS3mO5xwTr6e8FAmDKTFsACgkQ3mO5xwTr
6e9M4g/9GoGOOWeOaJflegP9NdBsV1oz/68pQpcWhOuRnyeHqKdRA3fPCjMhTngo
hkkgEA8gKzxDeH6RKHm6onpb5RYxPzBOoElHz6HIeLSjMhtBU77HhbnQNKHyFMFE
Em4xgLWHW5b6CHN9l/TBq+XC3BeMJEBha7F30zrfsr8KxRyDgMM2oMreDRV5Abf9
679HX80lS6MDNhZvHu6pUy/aY4oQmT2nm+RGwnYgL/+rjZxqYvBNQYeOzVX2lyd7
a9dZzqZsQ9xwoWmB818LpoLez7mSFl/+TR4wnHXzyCSUJH5SRptHLfpwcUuKP7oy
gFP9Hug8aVHPJ173PBEsM/WGCBgnRYB0WO3Jy9VZq3eqw46VGb8Df90tyRXi9Y+v
sxeVbYH+5F08Pi7iqrR+OCGjEhDidcHMwe4aA0R9m24FzqHQSj+i+rxG8Ti8AQSC
0P6PZsLqRLlzQ/PrY5D3glm887r3QQaoIcb92LJuiQgFRVS2RwSjOrfDe3UAE7fR
C5l3AXOP2TaXC4d2lMq8F+d77WLIweASZKOqkXxND0ewr68JtrrCT09N8O4cr6G+
j+CPvpkwd6ARqJNKS95oHsnZVkljSHWEIFaseEuYhK+WAcagLsD+6f4Qu1xMUchO
zKg+J3Piq5PAKvA4Z+YVM0UEPgIBejWwvLwYfjyVYQZ0D7BIZ1k=
=Cpec
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: