[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#983087: sbuild-createchroot misses usr/libexec/qemu-binfmt/ directory



Quoting Michael Tokarev (2021-02-22 10:49:12)
> The thing is that since quite some time ago, there's no need to mess up with
> the qemu-user-static binfmt interpreter at all, it all just works without any
> additional setup/preparation due to the fix-binary binfmt-misc flag (which
> keeps the interpreter open in the main system, so it works fine within all
> chroots without being present there).  It works since kernel 4.8 and QEMU
> Debian package 2.12 (Apr-2018).

That's cool! Maybe there is a good query for codesearch.d.n to find other
remaining instances where packages are not away from this?

> > for emulator in $(update-binfmts --find "$shell"); do
> >      dst="${CHROOT_PATH}$emulator"
> >      if [ ! -e "$emulator" ]; then
> >          info "Missing emulator: $emulator; not enabling binfmt support"
> >      else
> >          if [ ! -e "$dst" ]; then
> >               mkdir -p "$(dirname "$dst")"
> >               touch "$dst"
> >       fi
> >          mount --bind "$emulator" "$dst"
> >          mount -o remount,ro,bind "$dst"
> >      fi
> > done
> > 
> > Thus, adding the tag "patch".
> 
> The whole thing isn't needed for qemu and all the binfmt handling can be removed
> now.

Great, time to remove it, then. :)

> > Michael, your change in qemu introduced this problem. Schroot is currently
> > orphaned. Since you are responsible for this change in qemu, could you make an
> > NMU of schroot with above fix? Thanks!
> 
> Oww.. orphan.. that's pity.

Indeed. On the plus side, it means we can just NMU things without waiting for
maintainer action. ;)

> Okay, I'll take a look at it.
> 
> Thank you for the analisys!

Thank you for looking into it! :)

cheers, josch

Attachment: signature.asc
Description: signature


Reply to: