[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#983126: iptotal: embeds path to "date"



Source: iptotal
Severity: normal
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: usrmerge
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

The configuration /etc/iptotal/iptotal.cfg embeds the path to the "date"
command, which may vary when built on a usrmerge vs. a non-usrmerge
systems.

https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/diffoscope-results/iptotal.html

  /etc/iptotal/iptotal.cfg

  DATECMD=/bin/date
  DATECMD=/usr/bin/date


Patch attached which fixes this in debian/rules.


live well,
  vagrant
From 4830bf04a5275f3ac69b7829c8481ba41fd76f6b Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@reproducible-builds.org>
Date: Fri, 19 Feb 2021 18:51:03 +0000
Subject: [PATCH 1/2] debian/rules: Set DATECMD from dh_auto_install.

The path to "date" is embedded in the binaries, which may be /bin/date
or /usr/bin/date depending on if the running system is a usrmerge
system or not. Consistently use /bin/date as this is the most
compatible path.

https://tests.reproducible-builds.org/debian/issues/paths_vary_due_to_usrmerge_issue.html
---
 debian/rules | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/debian/rules b/debian/rules
index a53df1d..5620fa6 100755
--- a/debian/rules
+++ b/debian/rules
@@ -15,3 +15,6 @@ override_dh_auto_install:
 	rm -f $(CURDIR)/debian/iptotal/var/lib/iptotal/*.png
 	rm -f $(CURDIR)/debian/iptotal/var/lib/iptotal/archive/*.png
 	rm -f $(CURDIR)/debian/iptotal/var/lib/iptotal/images/*.png
+	# Avoid embedding the path to date, by consistently using the
+	# most compatible path to date.
+	sed -i -e 's,^DATECMD=.*,DATECMD=/bin/date,g' $(CURDIR)/debian/iptotal/etc/iptotal/iptotal.cfg
-- 
2.20.1

Attachment: signature.asc
Description: PGP signature


Reply to: