[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#929345: marked as done (getstream FTCBFS: builds for the wrong architecture)

Your message dated Fri, 12 Feb 2021 18:48:38 +0000
with message-id <E1lAdUc-0001DA-04@fasolo.debian.org>
and subject line Bug#929345: fixed in getstream 20100616-2
has caused the Debian Bug report #929345,
regarding getstream FTCBFS: builds for the wrong architecture
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
929345: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=929345
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: getstream
Version: 20100616-1
Tags: patch
User: helmutg@debian.org
Usertags: rebootstrap

getstream fails to cross build from source, because it does not pass
cross tools to make. The easiest way of fixing that - using
dh_auto_build - does not entirely fix the issue, because the upstream
Makefile hard codes plain gcc and Makefile.defs.sh hard codes
pkg-config. Substituting the latter is a little difficult, because
dh_auto_build does not pass environment variables, but make variables.
So we need to supply PKG_CONFIG ourselves. The attached patch makes
getstream cross buildable. Please consider applying it.

Helmut

diff --minimal -Nru getstream-20100616/debian/changelog getstream-20100616/debian/changelog
--- getstream-20100616/debian/changelog	2017-01-21 20:32:23.000000000 +0100
+++ getstream-20100616/debian/changelog	2019-05-22 06:00:26.000000000 +0200
@@ -1,3 +1,12 @@
+getstream (20100616-2) UNRELEASED; urgency=medium
+
+  * Fix FTCBFS: (Closes: #-1)
+    + Let dh_auto_build supply cross tools to make.
+    + cross.patch: Make build tools substitutable.
+    + Additionally pass PKG_CONFIG as environment variable.
+
+ -- Helmut Grohne <helmut@subdivi.de>  Wed, 22 May 2019 06:00:26 +0200
+
 getstream (20100616-1) unstable; urgency=medium
 
   * QA upload.
diff --minimal -Nru getstream-20100616/debian/patches/cross.patch getstream-20100616/debian/patches/cross.patch
--- getstream-20100616/debian/patches/cross.patch	1970-01-01 01:00:00.000000000 +0100
+++ getstream-20100616/debian/patches/cross.patch	2019-05-22 06:00:26.000000000 +0200
@@ -0,0 +1,31 @@
+--- getstream-20100616.orig/Makefile.defs.sh
++++ getstream-20100616/Makefile.defs.sh
+@@ -1,8 +1,9 @@
+-echo CFLAGS+=`pkg-config --cflags glib-2.0`
+-echo LDFLAGS+=`pkg-config --libs glib-2.0`
++: "${PKG_CONFIG:=pkg-config}"
++echo CFLAGS+=`${PKG_CONFIG} --cflags glib-2.0`
++echo LDFLAGS+=`${PKG_CONFIG} --libs glib-2.0`
+ 
+-libeventlibs=`pkg-config --libs libevent 2>/dev/null`
+-libeventcflags=`pkg-config --cflags libevent 2>/dev/null`
++libeventlibs=`${PKG_CONFIG} --libs libevent 2>/dev/null`
++libeventcflags=`${PKG_CONFIG} --cflags libevent 2>/dev/null`
+ 
+ if [ -z "${libeventcflags}" ]; then
+ 	libeventcflags=
+--- getstream-20100616.orig/Makefile
++++ getstream-20100616/Makefile
+@@ -26,10 +26,10 @@
+ all: getstream tsdecode
+ 
+ tsdecode: $(OBJ-tsdecode)
+-	gcc -o $@ $+ $(LDFLAGS)
++	$(CC) -o $@ $+ $(LDFLAGS)
+ 
+ getstream: $(OBJ-getstream)
+-	gcc -o $@ $+ $(LDFLAGS) 
++	$(CC) -o $@ $+ $(LDFLAGS) 
+ 
+ clean:
+ 	-rm -f $(OBJ-getstream) $(OBJ-tsdecode)
diff --minimal -Nru getstream-20100616/debian/patches/series getstream-20100616/debian/patches/series
--- getstream-20100616/debian/patches/series	2017-01-21 20:32:23.000000000 +0100
+++ getstream-20100616/debian/patches/series	2019-05-22 06:00:26.000000000 +0200
@@ -2,3 +2,4 @@
 glib-single-include.patch
 0001-Makefile-fix-for-link-as-needed.patch
 0001-Make-building-easier-by-using-pkg-config.patch
+cross.patch
diff --minimal -Nru getstream-20100616/debian/rules getstream-20100616/debian/rules
--- getstream-20100616/debian/rules	2017-01-21 20:32:23.000000000 +0100
+++ getstream-20100616/debian/rules	2019-05-22 06:00:26.000000000 +0200
@@ -1,6 +1,8 @@
 #!/usr/bin/make -f
 #export DH_VERBOSE=1
 
+-include /usr/share/dpkg/buildtools.mk
+export PKG_CONFIG ?= pkg-config
 
 CFLAGS = -Wall -g
 
@@ -9,7 +11,7 @@
 build-stamp: $(DPATCH_STAMPFN)
 	dh_testdir
 
-	$(MAKE)
+	dh_auto_build
 
 	touch $@

--- End Message ---
--- Begin Message --- 
Source: getstream
Source-Version: 20100616-2
Done: Boyuan Yang <byang@debian.org>

We believe that the bug you reported is fixed in the latest version of
getstream, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 929345@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Boyuan Yang <byang@debian.org> (supplier of updated getstream package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Fri, 12 Feb 2021 13:20:39 -0500
Source: getstream
Architecture: source
Version: 20100616-2
Distribution: unstable
Urgency: medium
Maintainer: Debian QA Group <packages@qa.debian.org>
Changed-By: Boyuan Yang <byang@debian.org>
Closes: 929345
Changes:
 getstream (20100616-2) unstable; urgency=medium
 .
   * QA upload.
   * Apply "wrap-and-sort -abst".
   * debian/control: Use Priority: optional.
   * debian/control: Use debhelper compat 13.
   * debian/control: Update Vcs-* and Standards-Version.
   * debian/rules: use dh sequencer.
   * debian/patches/0001-pkgconfig: Make it suitable for cross compilation.
     (Closes: #929345)
Checksums-Sha1:
 dcd0d20e5583e8a5575de3da1da4375994bdf5ca 1915 getstream_20100616-2.dsc
 1144dc0180cedb494f6c7826e994fc3bcf7eebe4 58720 getstream_20100616.orig.tar.gz
 f125e99527216b407a599e2288ed584ede366ec1 4788 getstream_20100616-2.debian.tar.xz
 153f69f654d973e3cc6ba92e66946b2ddabe45ba 7304 getstream_20100616-2_amd64.buildinfo
Checksums-Sha256:
 f8df2d8e0af574720149be92c4f288a42e96d227d58c0490028dfd87b206bf12 1915 getstream_20100616-2.dsc
 4bf01c555e4434ba91b119687ddb587d2720ae119d708582a367542f4dfdce57 58720 getstream_20100616.orig.tar.gz
 dc43fc974d1a0b7109160b0a2c53e9de08040983f836303efbc85f512b740205 4788 getstream_20100616-2.debian.tar.xz
 4cd363af27b3b8ce1fdb92eb4ea9a6b4f5294768ea779d3e349dd716d09776d7 7304 getstream_20100616-2_amd64.buildinfo
Files:
 ec08b4b66610a679813caa998569fdb5 1915 net optional getstream_20100616-2.dsc
 5a3956f77902291cad09d15e5896d99f 58720 net optional getstream_20100616.orig.tar.gz
 570d0db76219bfa6c3ad30bccc0a6a5a 4788 net optional getstream_20100616-2.debian.tar.xz
 b6c7f30da08d8b4a5766914735fb4359 7304 net optional getstream_20100616-2_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEfncpR22H1vEdkazLwpPntGGCWs4FAmAmx5AACgkQwpPntGGC
Ws66yg/9FNXYsERuYo4pwLcDnLy1c78IoTbE60QEkld5LkC/4gttR6knLKj2xnnv
gpVWB1A8nhlsg92SHw3PS6UMaLIREYho1c9ELSrRJZSIobXOsANpN0HhhZK8uod6
yqAWtmHpTYsFN6PVKAjIfs6fQBfW6FoyOUllCloG5uuQzwXuiEu9NLJzUJ11t23n
D3HeFSMg/zyOdRBFifA06K+A3pTuKUwj163zrYG6ksLwhBdLseNP2Qh0jBAFjjfu
WCxNFlNtcnIhLcOGP5m32dZ22LdrRXiHToPov6o/WdadQzk5Yi1PZUuU15J14Sg7
iHWLnSh245wWmcwzYku//rLirxH5EXl2l7CwXIMzPzP9OlOxAv3S8Z8jQEDOxGGN
HsHKuJOI7t+d2/t5ljTLcDY8gEBQJrPkNtGFVWS5oCJQxemwf1oCazSc+NgD1IpL
2Tw25stA1N59/rl6Eue7RtHkiXLf8iVb+IO7NykRoPxBL5X7J94VGlMQZMMuuYdQ
RbggQ4GWqjj5y7erkGpaSsXr1oKwTR6DPMpK3Tr5+TR1ZWrtjcSt3NrHPgoTET10
ezY7xF1ZcUQPQ3guUmjhmw8P/SX0AE3U2MYygBK9P6/2eEkyf2eXG3bDlilMd4ZQ
7tv30Xg+nHRAjU51cMYg83c520eiKVGNZmqFMZs9V2YWB0U/l/I=
=ewYp
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: