[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#911255: marked as done (bandwidthd FTCBFS: multiple reasons)

Your message dated Fri, 12 Feb 2021 09:33:22 +0000
with message-id <E1lAUpG-000C4v-Tn@fasolo.debian.org>
and subject line Bug#911255: fixed in bandwidthd 2.0.1+cvs20090917-13
has caused the Debian Bug report #911255,
regarding bandwidthd FTCBFS: multiple reasons
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
911255: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=911255
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: bandwidthd
Version: 2.0.1+cvs20090917-11
Tags: patch
User: helmutg@debian.org
Usertags: rebootstrap

bandwidthd fails to cross build from source, for multiple reasons. It
doesn't pass --host to ./configure. dh_auto_configure can take care of
that. It uses AC_CHECK_FILE to check for directories on the build
machine, while AC_CHECK_FILE is only to be used for host files. Finally
it strips during make install with the wrong strip. The attached patch
fixes all of that. Please consider applying it.

Helmut

diff --minimal -Nru bandwidthd-2.0.1+cvs20090917/debian/changelog bandwidthd-2.0.1+cvs20090917/debian/changelog
--- bandwidthd-2.0.1+cvs20090917/debian/changelog	2017-09-15 10:41:04.000000000 +0200
+++ bandwidthd-2.0.1+cvs20090917/debian/changelog	2018-10-17 19:50:30.000000000 +0200
@@ -1,3 +1,13 @@
+bandwidthd (2.0.1+cvs20090917-11.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Fix FTCBFS: (Closes: #-1)
+    + Let dh_auto_configure pass --host to ./configure.
+    + cross.patch: Don't use AC_CHECK_FILE for build machine files.
+    + Don't strip during make install.
+
+ -- Helmut Grohne <helmut@subdivi.de>  Wed, 17 Oct 2018 19:50:30 +0200
+
 bandwidthd (2.0.1+cvs20090917-11) unstable; urgency=medium
 
   * Orphan package.
diff --minimal -Nru bandwidthd-2.0.1+cvs20090917/debian/patches/cross.patch bandwidthd-2.0.1+cvs20090917/debian/patches/cross.patch
--- bandwidthd-2.0.1+cvs20090917/debian/patches/cross.patch	1970-01-01 01:00:00.000000000 +0100
+++ bandwidthd-2.0.1+cvs20090917/debian/patches/cross.patch	2018-10-17 19:50:30.000000000 +0200
@@ -0,0 +1,19 @@
+--- bandwidthd-2.0.1+cvs20090917.orig/configure.in
++++ bandwidthd-2.0.1+cvs20090917/configure.in
+@@ -30,12 +30,12 @@
+ CPPFLAGS="$CPPFLAGS -I/usr/local/include"
+ 
+ #Check for Darwin sw directory
+-AC_CHECK_FILE(/sw/lib, LDFLAGS="$LDFLAGS -L/sw/lib")
+-AC_CHECK_FILE(/sw/include, CPPFLAGS="$CPPFLAGS -I/sw/include")
++test -d /sw/lib && LDFLAGS="$LDFLAGS -L/sw/lib"
++test -d /sw/include && CPPFLAGS="$CPPFLAGS -I/sw/include"
+ 
+ #Check for NetBSD usr/pkg directory
+-AC_CHECK_FILE(/usr/pkg/lib, LDFLAGS="$LDFLAGS -L/usr/pkg/lib")
+-AC_CHECK_FILE(/usr/pkg/include, CPPFLAGS="$CPPFLAGS -I/usr/pkg/include")
++test -d /usr/pkg/lib LDFLAGS="$LDFLAGS -L/usr/pkg/lib"
++test -d /usr/pkg/include CPPFLAGS="$CPPFLAGS -I/usr/pkg/include"
+ 
+ # Required for solaris
+ AC_CHECK_LIB(socket, connect)
diff --minimal -Nru bandwidthd-2.0.1+cvs20090917/debian/patches/series bandwidthd-2.0.1+cvs20090917/debian/patches/series
--- bandwidthd-2.0.1+cvs20090917/debian/patches/series	2015-07-06 07:47:40.000000000 +0200
+++ bandwidthd-2.0.1+cvs20090917/debian/patches/series	2018-10-17 19:50:30.000000000 +0200
@@ -12,3 +12,4 @@
 fix-gcc-5-ftbfs.patch
 convert_short_php_syntax_to_long.patch
 replace_depricated_HTTP_GET_VARS_by_GET.patch
+cross.patch
diff --minimal -Nru bandwidthd-2.0.1+cvs20090917/debian/rules bandwidthd-2.0.1+cvs20090917/debian/rules
--- bandwidthd-2.0.1+cvs20090917/debian/rules	2013-06-14 00:41:25.000000000 +0200
+++ bandwidthd-2.0.1+cvs20090917/debian/rules	2018-10-17 19:50:30.000000000 +0200
@@ -6,7 +6,7 @@
 # Uncomment this to turn on verbose mode.
 #export DH_VERBOSE=1
 
-configureoptions = --prefix=/usr --bindir=/usr/sbin/ --sysconfdir=/etc/bandwidthd/ --localstatedir=/var/lib/
+configureoptions = --bindir=/usr/sbin/ --sysconfdir=/etc/bandwidthd/ --localstatedir=/var/lib/
 
 p_bwdstatic = bandwidthd
 p_bwdpgsql = bandwidthd-pgsql
@@ -26,9 +26,6 @@
 else
 	CFLAGS += -O2
 endif
-ifeq (,$(findstring nostrip,$(DEB_BUILD_OPTIONS)))
-	INSTALL_PROGRAM += -s
-endif
 
 configure:
 
@@ -41,7 +38,7 @@
 	cp -f /usr/share/misc/config.sub config.sub
 	dh_autoreconf
 	chmod +x configure
-	./configure $(configureoptions) --disable-pgsql
+	INSTALL='install --strip-program=true' dh_auto_configure -- $(configureoptions) --disable-pgsql
 	touch $@
 	
 configure-bwdpgsql: configure-bwdpgsql-stamp
@@ -52,7 +49,7 @@
 	[ ! -f /usr/share/misc/config.guess ] || cp -f /usr/share/misc/config.guess config.guess
 	[ ! -f /usr/share/misc/config.sub ] || cp -f /usr/share/misc/config.sub config.sub
 	chmod +x configure
-	./configure $(configureoptions) --enable-pgsql
+	INSTALL='install --strip-program=true' dh_auto_configure -- $(configureoptions) --enable-pgsql
 	touch $@

--- End Message ---
--- Begin Message --- 
Source: bandwidthd
Source-Version: 2.0.1+cvs20090917-13
Done: Andreas Henriksson <andreas@fatal.se>

We believe that the bug you reported is fixed in the latest version of
bandwidthd, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 911255@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Andreas Henriksson <andreas@fatal.se> (supplier of updated bandwidthd package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Fri, 12 Feb 2021 09:43:10 +0100
Source: bandwidthd
Architecture: source
Version: 2.0.1+cvs20090917-13
Distribution: unstable
Urgency: medium
Maintainer: Debian QA Group <packages@qa.debian.org>
Changed-By: Andreas Henriksson <andreas@fatal.se>
Closes: 824055 911255 977576
Changes:
 bandwidthd (2.0.1+cvs20090917-13) unstable; urgency=medium
 .
   * QA upload.
 .
   [ Logan Rosen ]
   * Recommend to PHP 7 instead of no longer available PHP 5. (Closes: #977576)
 .
   [ Helmut Grohne ]
   * Fix FTCBFS: (Closes: #911255)
     + Let dh_auto_configure pass --host to ./configure.
     + cross.patch: Don't use AC_CHECK_FILE for build machine files.
     + Don't strip during make install.
 .
   [ Andy Lowther ]
   * Add debian/patches/vlan.patch to correctly capture vlan tagged traffic
     (Closes: #824055)
Checksums-Sha1:
 631e87d0374e37be745d302934b964c9bb481a33 2015 bandwidthd_2.0.1+cvs20090917-13.dsc
 c9889fabd2ce297d1a5c5fd5ba1b27edfa64dd4b 47348 bandwidthd_2.0.1+cvs20090917-13.debian.tar.xz
 6d730bc4ffe21e69c2f42e18c0294ad0004a6703 8856 bandwidthd_2.0.1+cvs20090917-13_amd64.buildinfo
Checksums-Sha256:
 80bd10dc26742b08619aea64de2a7762cc184f5d95fff27b971abff73e4676b2 2015 bandwidthd_2.0.1+cvs20090917-13.dsc
 3ef5c1465385e732068642bf1accf6731fdc4a360392dc359461129b3345550e 47348 bandwidthd_2.0.1+cvs20090917-13.debian.tar.xz
 e70a1e423ecd688fb82bec90886ad9df77fe7bccc4609937ddc9cab74c620768 8856 bandwidthd_2.0.1+cvs20090917-13_amd64.buildinfo
Files:
 7dc82afc7ada7e4d0999eb54e9c7c899 2015 net optional bandwidthd_2.0.1+cvs20090917-13.dsc
 55e9bdb0c6c0dd6e033614e6b121bc82 47348 net optional bandwidthd_2.0.1+cvs20090917-13.debian.tar.xz
 3f75a920100d3bb9c797b23565c46e33 8856 net optional bandwidthd_2.0.1+cvs20090917-13_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJFBAEBCgAvFiEE+uHltkZSvnmOJ4zCC8R9xk0TUwYFAmAmSDgRHGFuZHJlYXNA
ZmF0YWwuc2UACgkQC8R9xk0TUwb98g//S93BmVEKMkj3pH+AB8yW6t35Y3OhRX1b
5Dm3ZUP+p6MkY0bN6soN60shB3+S+ze5CA8UkLowO1LqZlKfrBtOpOas8x2Cw4U8
ATOjqoA/q4+mZ7r3l1Yvwu3aCuMPKQwbxULNEoA9CO8lp6Tl6ZOnrql4C+Mi07Qq
Qtgxfy34xmPAx26OoJGrVt4Jg6aGs8qmcCzFm8KUQ7vj2gkGx4kmDYs833WKnQuG
u1F6s8qjGQLCZqYRHq80zD4lcjiZLJDdNmVLLWUKA/Bq1Hf0c41ZgXzYNxPF+Vs7
uDU5aGCSOKALgTY8KK5G56K0ELTq0tl+q1MSySgBXTFjVpspx95inmjdySdIk+Gh
KxsHcNNqx68WpgleQ9QWlEUj6E0+2vwKWN1vvvXkoRmDcmlPCUYmFk5UDqvALMz9
uh/O1Rzd4TkgnlvnsC5b029E3B53EyLLrplz81flngdeEdIJZdK4vxfbgheR/H5q
NfaCStGsHPfRz3l+71E0PxlvLieBIhr77Ap7F2QQ5jQtPdiNJ+dqpu+KuFv8v2kH
YE6/3qm6FQlHuo638eHFeneS5ldG3fWWO8q6v0mamFnNQRfb1jbuMeKqI1W621ye
eKLg2JNDhiuRQ3PJr/ZNirmkL5UMVXCb6SRZtzsGiAQQkbV6sYiAZKjCmbTcseIc
VPrVVBUhUCA=
=S4u5
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: