Your message dated Wed, 16 Jun 2021 19:33:31 +0000 with message-id <E1ltbI3-00034E-6u@fasolo.debian.org> and subject line Bug#772199: fixed in mp3rename 0.6-11 has caused the Debian Bug report #772199, regarding opens files RDWR to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact owner@bugs.debian.org immediately.) -- 772199: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=772199 Debian Bug Tracking System Contact owner@bugs.debian.org with problems
--- Begin Message ---
- To: Debian Bug Tracking System <submit@bugs.debian.org>
- Subject: opens files RDWR
- From: Joey Hess <id@joeyh.name>
- Date: Fri, 5 Dec 2014 22:06:11 -0400
- Message-id: <20141206020611.GA25863@kitenet.net>
Package: mp3rename Version: 0.6-9 Severity: normal Tags: patch For some reason mp3rename opens files RDWR. I don't see why it does this, as it is not going to change the content of a file. open("www.archive.org_download_gd70_01_02.early_late.sbd.cotsman.18120.sbeok.shnf_gd70_01_02d1t01_vbr.mp3", O_RDWR) = 3 fstat(3, {st_mode=S_IFREG|0644, st_size=1633024, ...}) = 0 mmap(NULL, 4096, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x7fde14544000 read(3, "ID3\3\0\0\0\0\0xTIT2\0\0\0\31\0\0\0Zarathustra"..., 4096) = 4096 fstat(3, {st_mode=S_IFREG|0644, st_size=1633024, ...}) = 0 lseek(3, 1630208, SEEK_SET) = 1630208 read(3, "3\243\31(\342\3210X=\332\10\341\16(Y\250\247\0t\372\320stW\276=\377\10\33n\251Y"..., 4096) = 2816 fstat(3, {st_mode=S_IFREG|0644, st_size=1633024, ...}) = 0 lseek(3, 1633024, SEEK_SET) = 1633024 fstat(3, {st_mode=S_IFREG|0644, st_size=1633024, ...}) = 0 lseek(3, 1633024, SEEK_SET) = 1633024 close(3) = 0 munmap(0x7fde14544000, 4096) = 0 rename("www.archive.org_download_gd70_01_02.early_late.sbd.cotsman.18120.sbeok.shnf_gd70_01_02d1t01_vbr.mp3", "(Grateful Dead)-Zarathustra introduction.mp3") = 0 This is particularly annoying when using git-annex, or I suppose anything else that removes the write bit from files. Ok, seems that -f and -a modify the file to add a new tag. So, I suggest this patch: diff -ur x/mp3rename-0.6/mp3rename.c mp3rename-0.6/mp3rename.c --- x/mp3rename-0.6/mp3rename.c 2014-12-05 22:02:10.000000000 -0400 +++ mp3rename-0.6/mp3rename.c 2014-12-05 21:59:19.509943882 -0400 @@ -99,7 +99,12 @@ char title[31]="", artist[31]="", album[31]="", year[5]="", comment[31]="", fbuf[4], newfilename[160]="",nieuw[150]="",dir[150]="",dirsource[200],fullline[228]="", burnname[29]="", track; plaatsen = 0; - if ( !( fp=fopen(*argv,"rb+") ) ) /* If the file doesn exist */ + char mode[4]; + if ((forced) || (all)) + sprintf(mode, "rb+"); + else + sprintf(mode, "rb"); + if ( !( fp=fopen(*argv,mode) ) ) /* If the file doesn exist */ { perror("Error opening file"); ++argv; /* Prepare for the next file */Attachment: signature.asc
Description: Digital signature
--- End Message ---
--- Begin Message ---
- To: 772199-close@bugs.debian.org
- Subject: Bug#772199: fixed in mp3rename 0.6-11
- From: Debian FTP Masters <ftpmaster@ftp-master.debian.org>
- Date: Wed, 16 Jun 2021 19:33:31 +0000
- Message-id: <E1ltbI3-00034E-6u@fasolo.debian.org>
- Reply-to: David da Silva Polverari <david.polverari@gmail.com>
Source: mp3rename Source-Version: 0.6-11 Done: David da Silva Polverari <david.polverari@gmail.com> We believe that the bug you reported is fixed in the latest version of mp3rename, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to 772199@bugs.debian.org, and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. David da Silva Polverari <david.polverari@gmail.com> (supplier of updated mp3rename package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing ftpmaster@ftp-master.debian.org) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 Format: 1.8 Date: Tue, 15 Jun 2021 17:06:54 +0000 Source: mp3rename Architecture: source Version: 0.6-11 Distribution: experimental Urgency: medium Maintainer: Debian QA Group <packages@qa.debian.org> Changed-By: David da Silva Polverari <david.polverari@gmail.com> Closes: 272221 431297 772199 901333 Changes: mp3rename (0.6-11) experimental; urgency=medium . * QA upload. * Migrations: - DH to new level format. Consequently: ~ debian/compat: removed. ~ debian/control: changed from 'debhelper' to 'debhelper-compat' in Build-Depends field and bumped level to 13. - DebSrc to 3.0. - debian/copyright to 1.0 format. - debian/rules to new (reduced) format. * Ran wrap-and-sort. * debian/changelog: removed trailing whitespace and cruft. * debian/clean: created to remove auto-generated manpage. * debian/control: - Added 'Rules-Requires-Root: no' to source stanza. - Added the Vcs-* fields. - Bumped Standards-Version to 4.5.1. - Removed help2man from Build-Depends, as it is no longer needed. * debian/copyright: updated upstream and packaging copyright information. * debian/manpages: created to install static manpage. Also, along with using dh sequencer in debian/rules, fixes FTCBFS. Thanks to Helmut Grohne <helmut@subdivi.de> (Closes: #901333). * debian/mp3rename.1: created by using help2man and formatted manually. * debian/patches/: - 010_old-makefile-diffs.patch: ~ Added to include all previous Makefile diffs from old Debian format packaging. ~ Included $(CPPFLAGS) and $(LDFLAGS) as compiler flags to allow hardening. ~ Using $(DESTDIR) to support staged installs. - 020_old-source-diffs.patch: added to include all previous mp3rename.c diffs from old Debian format packaging. - 030_fix-format-string.patch: added to fix a format string vulnerability. - 040_dont_open_rdwr.patch: added to avoid unnecessarily opening files RDWR. Thanks to Joey Hess <id@joeyh.name> (Closes: #772199). - 050_recognize_dashp_option.patch: added to recognize the -p option. Thanks to Shaun Jackman <sjackman@gmail.com> (Closes: #272221, #431297, LP: #199853). * debian/salsa-ci.yml: added to provide CI tests for Salsa. * debian/tests/control: created to perform CI tests. * debian/upstream/metadata: created. Checksums-Sha1: a59c51413d8adac040534be3ea16e6172b49a809 1805 mp3rename_0.6-11.dsc 460642ef762fee39803a4c269ae74bbf0dc2dcf5 6828 mp3rename_0.6-11.debian.tar.xz 35a6bd810da421081cfde68b22abad183df49c58 5307 mp3rename_0.6-11_source.buildinfo Checksums-Sha256: 6302226f13395cf1e800851b930f2c97b4771276a4447236bb640e3d0a5c02d8 1805 mp3rename_0.6-11.dsc a3332308cce04372a912f6d426170e1eedd9dcfed345a8f3e9d365655b2950f1 6828 mp3rename_0.6-11.debian.tar.xz e3d448954ba3a12efa126bfd15582dd80a22dcad685cc229fe5a1f5a1089b34c 5307 mp3rename_0.6-11_source.buildinfo Files: c1ae450b68d5306fc6afed764b72c116 1805 sound optional mp3rename_0.6-11.dsc 786c10b2ee7a048034d0e69e3357fe56 6828 sound optional mp3rename_0.6-11.debian.tar.xz 0754772bf1454481f47795b2299afede 5307 sound optional mp3rename_0.6-11_source.buildinfo -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEENX3LDuyVoBrrofDS3mO5xwTr6e8FAmDKTFsACgkQ3mO5xwTr 6e9M4g/9GoGOOWeOaJflegP9NdBsV1oz/68pQpcWhOuRnyeHqKdRA3fPCjMhTngo hkkgEA8gKzxDeH6RKHm6onpb5RYxPzBOoElHz6HIeLSjMhtBU77HhbnQNKHyFMFE Em4xgLWHW5b6CHN9l/TBq+XC3BeMJEBha7F30zrfsr8KxRyDgMM2oMreDRV5Abf9 679HX80lS6MDNhZvHu6pUy/aY4oQmT2nm+RGwnYgL/+rjZxqYvBNQYeOzVX2lyd7 a9dZzqZsQ9xwoWmB818LpoLez7mSFl/+TR4wnHXzyCSUJH5SRptHLfpwcUuKP7oy gFP9Hug8aVHPJ173PBEsM/WGCBgnRYB0WO3Jy9VZq3eqw46VGb8Df90tyRXi9Y+v sxeVbYH+5F08Pi7iqrR+OCGjEhDidcHMwe4aA0R9m24FzqHQSj+i+rxG8Ti8AQSC 0P6PZsLqRLlzQ/PrY5D3glm887r3QQaoIcb92LJuiQgFRVS2RwSjOrfDe3UAE7fR C5l3AXOP2TaXC4d2lMq8F+d77WLIweASZKOqkXxND0ewr68JtrrCT09N8O4cr6G+ j+CPvpkwd6ARqJNKS95oHsnZVkljSHWEIFaseEuYhK+WAcagLsD+6f4Qu1xMUchO zKg+J3Piq5PAKvA4Z+YVM0UEPgIBejWwvLwYfjyVYQZ0D7BIZ1k= =Cpec -----END PGP SIGNATURE-----
--- End Message ---