Package: open-invaders Version: 0.3-4.3+b1 Severity: normal Tags: patch Dear Debian QA Team, The program occasionally segfaults during gameplay. A core dump shows that the problem is caused by the collision detection routine writing out of bounds on an array. Specifically, collision_detection() in collision.cc cycles through an array explosionbits[] of 500 particles, but does not check for wraparound every time it increments the current_particle counter. The attached patch fixes the bug by moving the wraparound check to immediately after the increment. Thanks for considering, John G. -- System Information: Debian Release: 10.9 APT prefers stable-updates APT policy: (500, 'stable-updates'), (500, 'stable-debug'), (500, 'stable') Architecture: amd64 (x86_64) Kernel: Linux 4.19.0-16-amd64 (SMP w/2 CPU cores) Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8), LANGUAGE=en_GB.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /usr/bin/dash Init: systemd (via /run/systemd/system) LSM: AppArmor: enabled Versions of packages open-invaders depends on: ii libaldmb1 1:0.9.3-6+b3 ii liballegro4.4 2:4.4.2-13 ii libc6 2.28-10 ii libdumb1 1:0.9.3-6+b3 ii libgcc1 1:8.3.0-6 ii libstdc++6 8.3.0-6 ii open-invaders-data 0.3-4.3 open-invaders recommends no packages. open-invaders suggests no packages. -- no debconf information
Attachment:
fix-particle-array-bug.patch
Description: Binary data