[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#905951: marked as done (rox FTCBFS: configures for the build architecture)

Your message dated Fri, 01 Jan 2021 04:04:32 +0000
with message-id <E1kvBg0-000EbG-Tm@fasolo.debian.org>
and subject line Bug#905951: fixed in rox 1:2.11-3
has caused the Debian Bug report #905951,
regarding rox FTCBFS: configures for the build architecture
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
905951: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=905951
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: rox
Version: 1:2.11-1
Tags: patch
User: helmutg@debian.org
Usertags: rebootstrap

rox fails to cross build from source, because it configures for the
build architecture. It uses a quite unusual shell script wrapper to
invoke the relevant configure script. Thus it cannot use
dh_auto_configure, which would have taken care of the relevant flags
automatically. Rather, we must pass the --host flag explicitly. The
upstream configure also avoids the well established PKG_PROG_PKG_CONFIG
macro that would have just worked and hand crafts its own check that
requires the maintainer to supply a working PKG_CONFIG. After doing
both, rox cross builds successfully. Please consider applying the
attached patch.

Helmut

diff --minimal -Nru rox-2.11/debian/changelog rox-2.11/debian/changelog
--- rox-2.11/debian/changelog	2014-03-09 15:31:58.000000000 +0100
+++ rox-2.11/debian/changelog	2018-08-12 08:16:54.000000000 +0200
@@ -1,3 +1,12 @@
+rox (1:2.11-1.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Fix FTCBFS: (Closes: #-1)
+    + Pass --host to the ./configure wrapper.
+    + Also export a suitable PKG_CONFIG.
+
+ -- Helmut Grohne <helmut@subdivi.de>  Sun, 12 Aug 2018 08:16:54 +0200
+
 rox (1:2.11-1) unstable; urgency=low
 
   [ Jari Aalto ]
diff --minimal -Nru rox-2.11/debian/rules rox-2.11/debian/rules
--- rox-2.11/debian/rules	2014-03-09 15:31:58.000000000 +0100
+++ rox-2.11/debian/rules	2018-08-12 08:16:54.000000000 +0200
@@ -4,10 +4,13 @@
 DESTDIR  := $(shell pwd)/debian/$(PACKAGE)
 BUILDDIR := $(shell pwd)
 
+include /usr/share/dpkg/architecture.mk
 export DEB_BUILD_MAINT_OPTIONS = hardening=+all
 export DEB_LDFLAGS_MAINT_APPEND = -Wl,--as-needed
 DPKG_EXPORT_BUILDFLAGS = 1
 include /usr/share/dpkg/buildflags.mk
+-include /usr/share/dpkg/buildtools.mk
+export PKG_CONFIG ?= pkg-config
 
 configure: configure-stamp
 configure-stamp:
@@ -25,7 +28,7 @@
 build-stamp:
 	dh_testdir
 
-	ROX-Filer/AppRun --compile
+	ROX-Filer/AppRun --compile --build=$(DEB_BUILD_GNU_TYPE) --host=$(DEB_HOST_GNU_TYPE)
 	(cd ROX-Filer/src/po && ./dist)
 
 	touch build-stamp

--- End Message ---
--- Begin Message --- 
Source: rox
Source-Version: 1:2.11-3
Done: Adam Borowski <kilobyte@angband.pl>

We believe that the bug you reported is fixed in the latest version of
rox, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 905951@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Adam Borowski <kilobyte@angband.pl> (supplier of updated rox package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Fri, 01 Jan 2021 04:39:36 +0100
Source: rox
Architecture: source
Version: 1:2.11-3
Distribution: unstable
Urgency: medium
Maintainer: Debian QA Group <packages@qa.debian.org>
Changed-By: Adam Borowski <kilobyte@angband.pl>
Closes: 541976 546907 647377 860844 905951
Changes:
 rox (1:2.11-3) unstable; urgency=medium
 .
   * QA upload.
   * Comment out outdated and down VCS.
   * Replace menu entry with .desktop (Closes: #647377, #541976)
   * Depend on sensible-utils.
   * Don't invoke update-mime-info manually (Closes: #860844)
   * Convert README-es to UTF-8.
   * Fix FTCBFS: (Closes: #905951, Helmut Grohne)
     + Pass --host to the ./configure wrapper.
     + Also export a suitable PKG_CONFIG.
   * Install Templates.ui (Closes: #546907)
Checksums-Sha1:
 3e38c06fbf260b8362bcda9e195d83ba1e76ca60 2014 rox_2.11-3.dsc
 d5012edf7f1759f5e4d48a2c384e378b1003e6ac 11080 rox_2.11-3.debian.tar.xz
 b4d20dce39d2db81eff722831525483482c02b45 10845 rox_2.11-3_source.buildinfo
Checksums-Sha256:
 2e853d6f82990ced072669bdc5cee6cc07e7df4274ad915ed1e97fba209b4acb 2014 rox_2.11-3.dsc
 e42886db01c44b817bb28fe40feef1ec0640fdf1a7210b4a3608110ebfebe570 11080 rox_2.11-3.debian.tar.xz
 885b8ad0289edc333a4b83b6665ba4a1be9271965a6b3812501241b0df154aea 10845 rox_2.11-3_source.buildinfo
Files:
 3d5dda4554876add00d1489343a5dc96 2014 x11 optional rox_2.11-3.dsc
 ad742898365ba68b08ae8338046fdad6 11080 x11 optional rox_2.11-3.debian.tar.xz
 d78a00afe60a0427ae613012857f12eb 10845 x11 optional rox_2.11-3_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEkjZVexcMh/iCHArDweDZLphvfH4FAl/umnAACgkQweDZLphv
fH6seg/9FZnQUgEdgkFfzRzUe2hvbS76gc4NGsTyqIq84tmW6Obp+ZiZJh5WJ8xV
y1ayrK/lJvgpMXAgmakeAlm5sRD9IfS7z/yjY1ZK/oZAl5gpFiYewLwZgeUMg7C/
Cw/xvw1tzXfteIgXdp523jU+vFemKsLoOpfCHIdjuWRGXMYoNMYTlk/w6PH1RXEp
b9lwsALyRv30FkB/1PFeVdVSTICYzZi78mYzNfJsTdfeYvC1//gykc/aqDd+nlFv
vMGgMOh30Aux0l3tUw1jFOltOez3XSGzBdEA0guhvq/BqHSgbGzyiLdi8TdPcINK
udSgLu7u+hkJT+WSPOYT77Y5RSZ6JDh2B/WVXDFxd76Fg7HeAmz9Yu+Bsb/bbhpJ
QtwcWAiOJThFjJbjHjABXgq1DFOFElfgj4SNEoZQsMxU7Oldn6HT02K3eZ605E5Y
xAv89y89hFNTHZRSae+nw8uhsG8tmUZiEY0lzlatDHIJEVDTzmPxeTwi9qH3Y3WE
5xRYEEa5DzmV1CvDqNYjpaqQf9FURC3Dtxd82FqPMszM6qvTbNBdpyQIo2scbrXj
FiVr7sU3O2VI/y43oY2tP2LHxIcFWkhZ9Qn+p9fvZvcQf0Rzj+Kn6VAd1L799OlC
r+Nm1dMHhp/mkHZgRg03+9O/tFjPhQkZxgUud1tygrUacjS0Lkk=
=EsYk
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: