[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#541976: marked as done (rox: Bashism (uses "source") on menu-methods hook)

Your message dated Fri, 1 Jan 2021 03:38:07 +0100
with message-id <20210101023807.GA14995@angband.pl>
and subject line menu-methods are gone
has caused the Debian Bug report #541976,
regarding rox: Bashism (uses "source") on menu-methods hook
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
541976: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=541976
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: rox
Version: 2.0.1-1
Severity: normal
Tags: patch


When using dash or other non-bash shell as "sh" the menu trigger complains
about "source" being used.

I tracked down the problem and it's because the /etc/menu-methods/rox
method uses "source".

The fix for this is as easy as replacing "source" with "." on that file.
I've tested it and works just fine.

-- System Information:
Debian Release: squeeze/sid
  APT prefers unstable
  APT policy: (990, 'unstable'), (99, 'experimental'), (50, 'testing'), (9, 'stable')
Architecture: i386 (i686)

Kernel: Linux 2.6.30.4
Locale: LANG=es_AR.UTF-8, LC_CTYPE=es_AR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages rox depends on:
ii  libatk1.0-0            1.26.0-1          The ATK accessibility toolkit
ii  libc6                  2.9-24            GNU C Library: Shared libraries
ii  libglib2.0-0           2.20.4-1          The GLib library of C routines
ii  libgtk2.0-0            2.16.5-1          The GTK+ graphical user interface 
ii  libpango1.0-0          1.24.5-1          Layout and rendering of internatio
ii  libxml2                2.7.3.dfsg-2+b1   GNOME XML library
ii  shared-mime-info       0.60-2            FreeDesktop.org shared MIME databa
ii  xlibs                  6.9.0.dfsg.1-6    X Window System client libraries m
ii  zlib1g                 1:1.2.3.3.dfsg-15 compression library - runtime

rox recommends no packages.

Versions of packages rox suggests:
ii  file                          5.03-1     Determines file type using "magic"
pn  rox-session                   <none>     (no description available)

-- no debconf information

--- /tmp/rox.orig	2009-08-17 02:05:46.002028314 -0300
+++ /etc/menu-methods/rox	2009-08-17 01:58:28.751034975 -0300
@@ -45,7 +45,7 @@
 
 # Command to run at end.
 postrun="mkdir -p /usr/share/apps/Debian ; rm -r /usr/share/apps/Debian ; " \
-        "source /etc/roxmenu ; rm /etc/roxmenu"
+        ". /etc/roxmenu ; rm /etc/roxmenu"

--- End Message ---
--- Begin Message --- 
The package hasn't shipped with the menu-methods hook for a while.
I'm about to rip out the rest of menu support, thus closing.

-- 
⢀⣴⠾⠻⢶⣦⠀ .--[ Makefile ]
⣾⠁⢠⠒⠀⣿⡁ # beware of races
⢿⡄⠘⠷⠚⠋⠀ all: pillage burn
⠈⠳⣄⠀⠀⠀⠀ `----

--- End Message ---
Reply to: