[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#739465: marked as done (systemd support for milter-greylist)



Your message dated Thu, 31 Dec 2020 20:49:23 +0000
with message-id <E1kv4st-0009tZ-HW@fasolo.debian.org>
and subject line Bug#739465: fixed in milter-greylist 4.6.2-2
has caused the Debian Bug report #739465,
regarding systemd support for milter-greylist
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
739465: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=739465
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: milter-greylist
Version: 4.3.9-1
Severity: wishlist
Tags: patch
User: pkg-systemd-maintainers@lists.alioth.debian.org
Usertags: systemd-units
X-Debbugs-CC: pkg-systemd-maintainers@lists.alioth.debian.org


Hi,

the attached patch adds support for systemd. There is a notable change
compared to the init script. The service file will not use the values in
/etc/default/milter-greylist, because I believe, that this file is not
needed. A user can change some settings there that can also be changed
in the main configuration file (e.g pidfile, socketfile, user, etc.).

The patch changes the init script, so that it sources
/lib/lsb/init-functions. This is needed for invoking the init script
under systemd directly.

I would also recommend to upgrade the package to 4.4.3, because it fixes
the duplicate logging, when running milter-greylist in the foreground
(-D parameter). This mode is used by the service file.

If desired, I could also write some paragraphs for README.Debian, that
gives some pointers how to run milter-greylist with postfix under
systemd, so that users do not have the problem as described in #554239.

Best regards
Christian
diff -Nru milter-greylist-4.3.9/debian/control milter-greylist-4.3.9/debian/control
--- milter-greylist-4.3.9/debian/control	2011-06-22 15:17:35.000000000 +0200
+++ milter-greylist-4.3.9/debian/control	2014-02-16 22:38:16.000000000 +0100
@@ -2,7 +2,7 @@
 Section: mail
 Priority: extra
 Maintainer: Paul Martin <pm@debian.org>
-Build-Depends: quilt, debhelper (>= 8), autotools-dev, libmilter-dev, bison, flex, libspf2-dev
+Build-Depends: quilt, debhelper (>= 8), autotools-dev, libmilter-dev, bison, flex, libspf2-dev, dh-systemd
 Standards-Version: 3.9.2
 
 Package: milter-greylist
diff -Nru milter-greylist-4.3.9/debian/milter-greylist.service milter-greylist-4.3.9/debian/milter-greylist.service
--- milter-greylist-4.3.9/debian/milter-greylist.service	1970-01-01 01:00:00.000000000 +0100
+++ milter-greylist-4.3.9/debian/milter-greylist.service	2014-02-17 00:00:35.000000000 +0100
@@ -0,0 +1,13 @@
+[Unit]
+Description=Greylist Mail Filter Daemon
+Before=sendmail.service
+Before=postfix.service
+
+[Service]
+Type=simple
+ExecStart=/usr/sbin/milter-greylist -D
+Restart=on-failure
+PrivateTmp=true
+
+[Install]
+WantedBy=multi-user.target
diff -Nru milter-greylist-4.3.9/debian/milter-greylist.tmpfile milter-greylist-4.3.9/debian/milter-greylist.tmpfile
--- milter-greylist-4.3.9/debian/milter-greylist.tmpfile	1970-01-01 01:00:00.000000000 +0100
+++ milter-greylist-4.3.9/debian/milter-greylist.tmpfile	2014-02-19 00:19:37.000000000 +0100
@@ -0,0 +1 @@
+d /run/milter-greylist 0755 greylist greylist
diff -Nru milter-greylist-4.3.9/debian/patches/initfile.lsbfunctions milter-greylist-4.3.9/debian/patches/initfile.lsbfunctions
--- milter-greylist-4.3.9/debian/patches/initfile.lsbfunctions	1970-01-01 01:00:00.000000000 +0100
+++ milter-greylist-4.3.9/debian/patches/initfile.lsbfunctions	2014-02-16 22:39:23.000000000 +0100
@@ -0,0 +1,13 @@
+Index: milter-greylist-4.3.9/rc-debian.sh.in
+===================================================================
+--- milter-greylist-4.3.9.orig/rc-debian.sh.in	2014-02-16 22:38:03.000000000 +0100
++++ milter-greylist-4.3.9/rc-debian.sh.in	2014-02-16 22:39:20.572000000 +0100
+@@ -16,7 +16,7 @@
+ # Description: another spam-defense service
+ ### END INIT INFO
+ 
+-
++. /lib/lsb/init-functions
+ 
+ # Based on skeleton by Miquel van Smoorenburg and Ian Murdock
+ 
diff -Nru milter-greylist-4.3.9/debian/patches/series milter-greylist-4.3.9/debian/patches/series
--- milter-greylist-4.3.9/debian/patches/series	2010-03-15 14:55:46.000000000 +0100
+++ milter-greylist-4.3.9/debian/patches/series	2014-02-16 22:38:44.000000000 +0100
@@ -6,3 +6,4 @@
 tempfs.508122
 initfile.mountall
 573936-dump_lex
+initfile.lsbfunctions
diff -Nru milter-greylist-4.3.9/debian/rules milter-greylist-4.3.9/debian/rules
--- milter-greylist-4.3.9/debian/rules	2011-06-22 15:18:16.000000000 +0200
+++ milter-greylist-4.3.9/debian/rules	2014-02-16 22:38:19.000000000 +0100
@@ -1,6 +1,6 @@
 #!/usr/bin/make -f
 %:
-	dh $@ --with quilt,autotools_dev
+	dh $@ --with quilt,autotools_dev,systemd
 
 override_dh_auto_configure:
 	dh_auto_configure -- \

--- End Message ---
--- Begin Message ---
Source: milter-greylist
Source-Version: 4.6.2-2
Done: Vagrant Cascadian <vagrant@reproducible-builds.org>

We believe that the bug you reported is fixed in the latest version of
milter-greylist, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 739465@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Vagrant Cascadian <vagrant@reproducible-builds.org> (supplier of updated milter-greylist package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Thu, 31 Dec 2020 12:42:59 -0800
Source: milter-greylist
Architecture: source
Version: 4.6.2-2
Distribution: unstable
Urgency: medium
Maintainer: Debian QA Group <packages@qa.debian.org>
Changed-By: Vagrant Cascadian <vagrant@reproducible-builds.org>
Closes: 739465 784408 978751
Changes:
 milter-greylist (4.6.2-2) unstable; urgency=medium
 .
   * QA upload.
 .
   [ Debian Janitor ]
   * Use secure URI in debian/watch.
   * Set Homepage field in Source rather than Binary package.
   * Update standards version to 4.5.0, no changes needed.
 .
   [ Vagrant Cascadian ]
   * debian/patches: Adjust configure.ac to avoid embedding hostname,
     username, build time and build path in the binaries. (Closes: #978751)
   * debian/control: Set Rules-Requires-Root to "no".
   * debian/control: Update to debhelper-compat 13.
   * debian/control: Update Standards-Version to 4.5.1.
 .
   [ Christian Dröge ]
   * systemd support for milter-greylist (Closes: #739465)
 .
   [ Vagrant Cascadian ]
   * debian/patches: initfile.nosudo: Fix typo in patch to use "su" instead
     of "sudo". (Closes: #784408)
Checksums-Sha1:
 2848290db00f14ec574434bae36a3f89d0ae3b8e 1471 milter-greylist_4.6.2-2.dsc
 be2d91837bfd99b9291dc8a8473db9d8e01a22f4 12520 milter-greylist_4.6.2-2.debian.tar.xz
 d4ceca3f3c81808e62efa85449c0fb13dcc4c413 6641 milter-greylist_4.6.2-2_amd64.buildinfo
Checksums-Sha256:
 4c6dc8821dc9c6ce88ba3ef7091b02f03eb3f4710267a104f1c27e8849dd7eac 1471 milter-greylist_4.6.2-2.dsc
 f32a59bfb72df6c7d1300bdc7efb8a04e3834e4ecf9f9e07b4063e1e6de2342a 12520 milter-greylist_4.6.2-2.debian.tar.xz
 10e80c49ff889de2a80f8158d2909ae21eba0695cacab6058106356cf3b89406 6641 milter-greylist_4.6.2-2_amd64.buildinfo
Files:
 f1978f395e1aa0b57e9303ed9047d47d 1471 mail optional milter-greylist_4.6.2-2.dsc
 9f13fd329dcd53541563c2643a2822ee 12520 mail optional milter-greylist_4.6.2-2.debian.tar.xz
 bdd64272b999792f0d771df7d5e9f983 6641 mail optional milter-greylist_4.6.2-2_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iJYEARYKAD4WIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCX+44tyAcdmFncmFudEBy
ZXByb2R1Y2libGUtYnVpbGRzLm9yZwAKCRDcUY/If5cWqhawAP9KM26N9XT4hIRR
XQGKvfxS2GKcbkRTK64d98s1Zkw3WAEA+GDkpJ6nyxXjn/z1Nv9Vfx1loiRV5laP
PkuMUswOug0=
=3nHV
-----END PGP SIGNATURE-----

--- End Message ---

Reply to: