[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#977783: marked as done (magicfilter: reproducible builds: buildid changes with different build path)



Your message dated Sun, 20 Dec 2020 21:33:34 +0000
with message-id <E1kr6Kc-00058Z-7D@fasolo.debian.org>
and subject line Bug#977783: fixed in magicfilter 1.2-66
has caused the Debian Bug report #977783,
regarding magicfilter: reproducible builds: buildid changes with different build path
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
977783: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=977783
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Source: magicfilter
Version: 1.2-65
Severity: normal
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: buildpath
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org


The file /usr/sbin/magicfilter has a different buildid when the build
path changes:

  https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/diffoscope-results/magicfilter.html

  GNU 0x00000014» NT_GNU_BUILD_ID·(unique·build·ID·bitstring)» Build·ID:·c89260c14a143b70d63d924b4712c4b35c03a23c
  vs.
  GNU 0x00000014» NT_GNU_BUILD_ID·(unique·build·ID·bitstring)» Build·ID:·487f927ccc177675cac6867f716c97792fc359c4

The attached patch fixes this in debian/rules by passing
-ffile-prefix-map via CFLAGS.


live well,
  vagrant
From 668483cdcf842b4b0f36c0f4b58a98db6baec202 Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@reproducible-builds.org>
Date: Sun, 20 Dec 2020 19:32:03 +0000
Subject: [PATCH 3/4] debian/rules: Use -ffile-prefix-map in CFLAGS to ensure
 reproducible builds.

https://tests.reproducible-builds.org/debian/issues/unstable/gcc_captures_build_path_issue.html
---
 debian/rules | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/debian/rules b/debian/rules
index 12bce98..572fedc 100755
--- a/debian/rules
+++ b/debian/rules
@@ -18,6 +18,9 @@ else
   CFLAGS += -Os
 endif
 
+# Set -ffile-prefix-map for reproducible builds regardless of build path
+CFLAGS += -ffile-prefix-map=$(CURDIR)=.
+
 build:
 	ln -sf /usr/share/misc/config.sub .
 	ln -sf /usr/share/misc/config.guess .
-- 
2.20.1

Attachment: signature.asc
Description: PGP signature


--- End Message ---
--- Begin Message ---
Source: magicfilter
Source-Version: 1.2-66
Done: Vagrant Cascadian <vagrant@reproducible-builds.org>

We believe that the bug you reported is fixed in the latest version of
magicfilter, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 977783@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Vagrant Cascadian <vagrant@reproducible-builds.org> (supplier of updated magicfilter package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sun, 20 Dec 2020 13:18:12 -0800
Source: magicfilter
Architecture: source
Version: 1.2-66
Distribution: unstable
Urgency: medium
Maintainer: Debian QA Group <packages@qa.debian.org>
Changed-By: Vagrant Cascadian <vagrant@reproducible-builds.org>
Closes: 847016 974767 977783 977784
Changes:
 magicfilter (1.2-66) unstable; urgency=medium
 .
   * QA upload.
 .
   [ Valerie R Young ]
   * Make the build reproducible (fileordering) (Closes: #847016)
 .
   [ Helmut Grohne ]
   * Fix failure to cross-build from source. (Closes: #974767)
 .
   [ Vagrant Cascadian ]
   * debian/rules: Use -ffile-prefix-map in CFLAGS. (Closes: #977783)
   * debian/rules: Pass GZIP and BZIP2 to configure. (Closes: #977784)
   * debian/control: Update Vcs-* headers.
   * debian/changelog: Remove trailing whitespace.
   * debian/control: Set Rules-Requires-Root to no.
   * debian/rules: Do not call chown for Rules-Requires-Root support.
   * debian/rules: Use dpkg-deb with --root-owner-group to support
     Rules-Requires-Root.
   * debian/control: Update Standards-Version to 4.5.1.
Checksums-Sha1:
 7562c8e16f88e3e1e1199f73edb20b2998dc43e4 1445 magicfilter_1.2-66.dsc
 47e1f5085cc2c6544d1d3dfbe3230079aaf0250c 35316 magicfilter_1.2-66.debian.tar.xz
 0e494655812514536ca041ec0a4b9cf2f9ca835d 7087 magicfilter_1.2-66_amd64.buildinfo
Checksums-Sha256:
 1c9c7f63a87965162e0470022aa7f21a2b0287a64363e544163d1be3917fbc0b 1445 magicfilter_1.2-66.dsc
 f2312a4b098df28cd4b61139f6ed2785eafa07b023ce33910306a51c5e9e8878 35316 magicfilter_1.2-66.debian.tar.xz
 4920c7ae49eff366c4e2bd3b042d1003d263e10567baee325b6299e5de8f6797 7087 magicfilter_1.2-66_amd64.buildinfo
Files:
 4515cd12e39f5dd4193a9851c579f575 1445 text optional magicfilter_1.2-66.dsc
 f4cb146f2bb4a73a2fe870a18570512f 35316 text optional magicfilter_1.2-66.debian.tar.xz
 2e9c1ed1e654d9d0e731d5b732080eae 7087 text optional magicfilter_1.2-66_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iJYEARYKAD4WIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCX9/AQiAcdmFncmFudEBy
ZXByb2R1Y2libGUtYnVpbGRzLm9yZwAKCRDcUY/If5cWqiUcAQCaQpsceTUlXS5b
qRf3JnqNfNcgJ8HCmexe3qH6ICuWbQD/Y2eTah/E+D7azvmkqVOQBICqdCf0GPf4
kZxtrYwQYws=
=MZ7+
-----END PGP SIGNATURE-----

--- End Message ---

Reply to: