On 2020-05-28, Vagrant Cascadian wrote: > Files generated by texi2html often embed the build user and build date. It turns out the build date used respects SOURCE_DATE_EPOCH, so the date is not a big issue. > The attached patch removes the code which embeds the build date and > build user in order to achieve reproducible builds for the texi2html > package itself, as well as several other packages identified by the > reproducible builds project: > > https://tests.reproducible-builds.org/debian/issues/unstable/texi2html_captures_users_gecos_issue.html > > Maybe additional packages would benefit from this patch as well. I've tested the attached a simpler one-line patch that removes the default user value rather than the entire code handling user and date. I've read: https://wiki.debian.org/qa.debian.org But did not see anything about what the process for a QA upload was... As this fixes reproducibility issues in several packages, it would be nice to see this included in time for bullseye! Thanks for your review, and please let me know if I should proceed with the upload, or any changes to make, or process to follow, etc. live well, vagrant
diff -Nru texi2html-1.82+dfsg1/debian/changelog texi2html-1.82+dfsg1/debian/changelog
--- texi2html-1.82+dfsg1/debian/changelog 2015-12-23 10:06:38.000000000 -0800
+++ texi2html-1.82+dfsg1/debian/changelog 2020-11-15 16:42:38.000000000 -0800
@@ -1,3 +1,10 @@
+texi2html (1.82+dfsg1-6) unstable; urgency=medium
+
+ * QA upload.
+ * Do not embed the build user in html files (Closes: #961764).
+
+ -- Vagrant Cascadian <vagrant@reproducible-builds.org> Sun, 15 Nov 2020 16:42:38 -0800
+
texi2html (1.82+dfsg1-5) unstable; urgency=medium
* QA upload.
diff -Nru texi2html-1.82+dfsg1/debian/patches/do-not-embed-the-build-user-in-html-file.patch texi2html-1.82+dfsg1/debian/patches/do-not-embed-the-build-user-in-html-file.patch
--- texi2html-1.82+dfsg1/debian/patches/do-not-embed-the-build-user-in-html-file.patch 1969-12-31 16:00:00.000000000 -0800
+++ texi2html-1.82+dfsg1/debian/patches/do-not-embed-the-build-user-in-html-file.patch 2020-11-15 16:42:38.000000000 -0800
@@ -0,0 +1,21 @@
+From: Vagrant Cascadian <vagrant@reproducible-builds.org>
+Date: Sun, 15 Nov 2020 19:26:28 +0000
+X-Dgit-Generated: 1.82+dfsg1-6 914779331fe9fed1dfd59830fa18994884c00368
+Subject: Do not embed the build user in html files (Closes: #961764).
+
+Bug-Debian: https://bugs.debian.org/961764
+Forwarded: no
+Last-Update: 2020-11-15
+
+---
+
+--- texi2html-1.82+dfsg1.orig/texi2html.pl
++++ texi2html-1.82+dfsg1/texi2html.pl
+@@ -7164,7 +7164,6 @@ sub pass_text($$)
+ $Texi2HTML::THISDOC{'program'} = $THISPROG;
+ $Texi2HTML::THISDOC{'program_homepage'} = $T2H_HOMEPAGE;
+ $Texi2HTML::THISDOC{'program_authors'} = $T2H_AUTHORS;
+- $Texi2HTML::THISDOC{'user'} = $T2H_USER;
+ $Texi2HTML::THISDOC{'user'} = $Texi2HTML::Config::USER if (defined($Texi2HTML::Config::USER));
+ $Texi2HTML::THISDOC{'authors'} = [] if (!defined($Texi2HTML::THISDOC{'authors'}));
+ $Texi2HTML::THISDOC{'subtitles'} = [] if (!defined($Texi2HTML::THISDOC{'subtitles'}));
diff -Nru texi2html-1.82+dfsg1/debian/patches/series texi2html-1.82+dfsg1/debian/patches/series
--- texi2html-1.82+dfsg1/debian/patches/series 2015-12-23 09:33:22.000000000 -0800
+++ texi2html-1.82+dfsg1/debian/patches/series 2020-11-15 16:42:38.000000000 -0800
@@ -3,3 +3,4 @@
03_add_build-date_param.patch
04_sort-perl-hash
05_reproducible-build
+do-not-embed-the-build-user-in-html-file.patch
Attachment:
signature.asc
Description: PGP signature