--- Begin Message ---
- To: Debian Bug Tracking System <submit@bugs.debian.org>
- Subject: BlockingQueue.h: virtual bool add() wrong parameter type
- From: Thomas Merkel <tm+debian@core.io>
- Date: Thu, 09 Apr 2020 11:16:19 +0000
- Message-id: <158643097986.639.11083771838085393543.reportbug@4831842b5948>
Package: libzthread-dev
Version: 2.3.2-8
Severity: important
Based from the `zthread` documentation the correct paramter for
Queue::add() should be 'const T& item' and not 'T item'.
As upstream does not responde to any reports a patch has already been
applied to FreeBSD for example. I think it would be the best to also
patch it on Debian.
A patch has been attached.
-- System Information:
Debian Release: 10.3
APT prefers stable-updates
APT policy: (500, 'stable-updates'), (500, 'stable')
Architecture: amd64 (x86_64)
Kernel: Linux 5.5.10-gentoo-x86_64 (SMP w/8 CPU cores)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=C, LC_CTYPE=C.UTF-8 (charmap=UTF-8), LANGUAGE=C (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: unable to detect
Versions of packages libzthread-dev depends on:
ii libzthread-2.3-2 2.3.2-8
libzthread-dev recommends no packages.
libzthread-dev suggests no packages.
-- no debconf information
--- usr/include/zthread/BlockingQueue.h.orig 2005-03-13 02:04:18 UTC
+++ usr/include/zthread/BlockingQueue.h
@@ -83,7 +83,7 @@ namespace ZThread {
/**
* @see Queue::add(const T& item, unsigned long timeout)
*/
- virtual bool add(T item, unsigned long timeout) {
+ virtual bool add(const T& item, unsigned long timeout) {
try {
--- End Message ---
--- Begin Message ---
Source: zthreads
Source-Version: 2.3.2-9
Done: Fabio Augusto De Muzio Tobich <ftobich@gmail.com>
We believe that the bug you reported is fixed in the latest version of
zthreads, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 956291@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Fabio Augusto De Muzio Tobich <ftobich@gmail.com> (supplier of updated zthreads package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Sat, 18 Jul 2020 18:52:50 -0300
Source: zthreads
Architecture: source
Version: 2.3.2-9
Distribution: experimental
Urgency: medium
Maintainer: Debian QA Group <packages@qa.debian.org>
Changed-By: Fabio Augusto De Muzio Tobich <ftobich@gmail.com>
Closes: 956291
Changes:
zthreads (2.3.2-9) experimental; urgency=medium
.
* QA upload.
* Using new DH level format. Consequently:
- debian/compat: removed.
- debian/control: changed from 'debhelper' to 'debhelper-compat' in
Build-Depends field and bumped level to 13.
* debian/control:
- Added 'Rules-Requires-Root: no' in source stanza.
- Added Vcs-* fields to source stanza.
- Bumped Standards-Version to 4.5.0.
- Updated Priority field in source stanza to optional.
- Updated short and long descriptions in both package stanzas.
* debian/copyright:
- Migrated to 1.0 format.
- Updated all data.
* debian/libzthread-2.3-2.symbols: created.
* debian/not-installed: added to list files that won't be installed.
* debian/patches/:
- All patches renamed to follow a numeric prefix system.
- All patches headers updated Description, Author and Last-Update
fields.
- Some patches had Bug* fields added.
- 080_wrong-parameter-type.patch: added to fix virtual bool add() wrong
parameter type. Thanks to Thomas Merkel. (Closes: #956291, LP: #1842421)
* debian/rules:
- Added command to provide unversioned link to shared library in
override_dh_auto_install.
- Added the DEB_BUILD_MAINT_OPTIONS variable to improve the GCC
hardening.
- Removed some unnecessary stuff.
* debian/salsa-ci.yml: added.
* debian/upstream/metadata: created.
* debian/watch: bumped version to 4.
Checksums-Sha1:
5129bf934788cde90039134c8630bf4695d3fc5d 1907 zthreads_2.3.2-9.dsc
386751c2c4c2b5ef8135a5194d497d6607fb9381 11600 zthreads_2.3.2-9.debian.tar.xz
8df2cc8ac6db1c690ce44ec78032316952a6f687 5287 zthreads_2.3.2-9_source.buildinfo
Checksums-Sha256:
4c3ce865a376d570d859f16b87661b5aaa4d1c999b4e36f5b1529290437ed8d4 1907 zthreads_2.3.2-9.dsc
15e0febb856624e58dd2eabf4e7d0896d1c4eed0e3f6c7bcb86726eacb1c7bb8 11600 zthreads_2.3.2-9.debian.tar.xz
ea57f0b106de62b58e20efc0705209cddcaa89c0a02dcd964415d623c2ce0f4f 5287 zthreads_2.3.2-9_source.buildinfo
Files:
45f417e2b89e4835dd2d5ef101025af5 1907 libs optional zthreads_2.3.2-9.dsc
cf049afbc9caa4f7cf82a4a125d3fb43 11600 libs optional zthreads_2.3.2-9.debian.tar.xz
216af02318a67540297df87637798658 5287 libs optional zthreads_2.3.2-9_source.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCAAdFiEEHTjuPGJPlVzh+jyFWjA1kfjNsIsFAl8Z8A0ACgkQWjA1kfjN
sIvtbQ/+OLiW2e/at1tGCDpNEWRJcB83LbwJva+IWQBXPEP9tcKGJJUyeW89CW4f
hiSFEALQGj6ReNvbe2cxwBSLFhmH/+euU4MJFyNhON1YDqnT54UaAbpD3R2hMw8q
SwyCHEchJGjiteId076SzmMqGWLO8MkP5sNhTMchS7NUldnctSmNycA3zwJf+hBc
wTg/kTyum3avAYAKE48COmU+gPziwJNzFpC3Vl/FTF33vfO8ieRvF6i64PrEm0Sv
3d+Hpx+WsFX7ZnyhVIHKSNp71j05RRNwG3QKAc7rq68vYFG2iUegeYCkxaazt2tG
4TRlvK3zgH9ku9ict4bsJGcQHO0nXxG4wVIvDy0GbHMDgIf0xZUS1BnjBUxxtITo
vh8u/chy1JOnS6A425NxgT1eVZ+eOdNqX+XvWIYm08X/IbeEMYZZTnoyzD8e7yEz
GGVOFGuwlr0LWZiZZCqE6s8mLCod75Q+0ffOoPZ1/taYC9myC6l6u8rsz/7jJcue
jJmDjm1gC9gTZPq7YcbM5ubGDH5JDGH28vo5PJcIMob4tbEhTvYw8OWVRyOFuCyS
ilp28rxntHljiSj3NCtMYLx9u3dg313T5kEIFzk2plX11oGFS5E8ZZAoBRAE+yBb
UFPKQ33WiHDM5ghDsz79s1AZvc1V+QDOdVIvQ9DueeGJXiflRqw=
=ghAU
-----END PGP SIGNATURE-----
--- End Message ---