[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#831021: marked as done (cfingerd: please make the build reproducible)



Your message dated Wed, 23 Sep 2020 11:33:30 +0000
with message-id <E1kL31e-000A9u-0H@fasolo.debian.org>
and subject line Bug#831021: fixed in cfingerd 1.4.3-5
has caused the Debian Bug report #831021,
regarding cfingerd: please make the build reproducible
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
831021: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=831021
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Source: cfingerd
Version: 1.4.3-3.1
Severity: wishlist
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: timestamps
X-Debbugs-Cc: reproducible-builds@lists.alioth.debian.org

Hi,

Whilst working on the "reproducible builds" effort [0], we noticed
that cfingerd could not be built reproducibly.

Patch attached. The changes to ./Configure can be sen upstream.

 [0] https://wiki.debian.org/ReproducibleBuilds


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-
--- a/Configure	2016-07-13 19:42:47.435630485 +0200
--- b/Configure	2016-07-13 20:35:04.337361253 +0200
@@ -17,6 +17,8 @@
 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 # GNU General Public License for more details.
 
+use POSIX qw(strftime);
+
 require 'perl/question.pl';
 require 'perl/filemagic.pl';
 require 'perl/gethost.pl';
@@ -63,7 +65,7 @@
 	print "Creating src/config.h ... ";
 
 	$ENV{'LC_TIME'} = "C";
-	local($dateandtime) = `date`;
+	local($dateandtime) = strftime("%a %b %e %H:%M:%S UTC %Y", gmtime($ENV{SOURCE_DATE_EPOCH} || time));
 	chop($dateandtime);
 
 	open(CF, "src/config.h.in");
--- a/debian/rules	2016-07-13 19:42:47.435630485 +0200
--- b/debian/rules	2016-07-13 19:44:10.195595285 +0200
@@ -69,8 +69,8 @@
 	$(installdoc) CREDITS FAQ RECOMMEND TODO debian/tmp/usr/share/doc/$(package)
 	$(installdoc) CHANGES debian/tmp/usr/share/doc/$(package)/changelog
 	$(installdoc) README debian/tmp/usr/share/doc/$(package)/readme
-	gzip -9f debian/tmp/usr/share/doc/$(package)/{changelog.Debian,changelog}
-	gzip -9f debian/tmp/usr/share/doc/$(package)/{readme,CREDITS,FAQ,RECOMMEND,TODO}
+	gzip -9nf debian/tmp/usr/share/doc/$(package)/{changelog.Debian,changelog}
+	gzip -9nf debian/tmp/usr/share/doc/$(package)/{readme,CREDITS,FAQ,RECOMMEND,TODO}
 	#
 	$(installbin) -d debian/tmp/usr/sbin
 	$(installbin) $(STRIP) src/cfingerd debian/tmp/usr/sbin
@@ -79,7 +79,7 @@
 	$(installbin) -d debian/tmp/usr/share/man/man{5,8}
 	cd docs && $(MAKE) MANDIR=../debian/tmp/usr/share/man install
 	$(installdoc) userlist/userlist.1 debian/tmp/usr/share/man/man8/userlist.8
-	gzip -9 debian/tmp/usr/share/man/man?/*
+	gzip -9n debian/tmp/usr/share/man/man?/*
 	#
 	$(installbin) -d debian/tmp/etc/cfingerd{,/scripts}
 	$(installdoc) debian/{top_finger,bottom_finger}.txt debian/tmp/etc/cfingerd

--- End Message ---
--- Begin Message ---
Source: cfingerd
Source-Version: 1.4.3-5
Done: Chris Lamb <lamby@debian.org>

We believe that the bug you reported is fixed in the latest version of
cfingerd, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 831021@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Chris Lamb <lamby@debian.org> (supplier of updated cfingerd package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Wed, 23 Sep 2020 12:12:44 +0100
Source: cfingerd
Architecture: source
Version: 1.4.3-5
Distribution: unstable
Urgency: medium
Maintainer: Debian QA Group <packages@qa.debian.org>
Changed-By: Chris Lamb <lamby@debian.org>
Closes: 831021 956826
Changes:
 cfingerd (1.4.3-5) unstable; urgency=medium
 .
   * QA upload.
   * Make the build reproducible (Closes: #831021)
     - Update upstream's Configure script to not embed the build time.
     - Avoid timestamped gzip files in binary packages.
   * Call dh_auto_build over $(MAKE) to pass cross-building tools to upstream
     build system. Thanks, Helmut Grohne. (Closes: #956826)
   * Unapply patches in debian/patches from main source tree.
   * debian/rules:
     - Set Rules-Requires-Root to "binary-targets".
     - Correct location of Homepage field.
     - Move Homepage field to HTTPS.
     - Drop unnecessary "source", "version" and "revision" assignments in
       debian/rules.
     - Drop outdated "source diff", "dsc" and "dist" targets.
   * Fix the syntax in a large number of debian/changelog entries.
Checksums-Sha1:
 e68efbd0941932eb9361f987a969ba1bb33a0414 1836 cfingerd_1.4.3-5.dsc
 81fa6816e0f64418f0c410ceba92f34c2829ee4f 21972 cfingerd_1.4.3-5.debian.tar.xz
 4e9b368ec464981fed58fa84ed4389c5e9457667 5252 cfingerd_1.4.3-5_amd64.buildinfo
Checksums-Sha256:
 6328f2a667c3ba8d5effdc8f9798a174a6dff8518d219c77ba8402ee01ebd680 1836 cfingerd_1.4.3-5.dsc
 8f1498f587d27f82004b6f2ef7efef46fb37ab79729f27f40f64f9f2014e1227 21972 cfingerd_1.4.3-5.debian.tar.xz
 3e074908ccd5addc303a7e75c406f786de1a5674865eee0a7ba2fccd863e3d49 5252 cfingerd_1.4.3-5_amd64.buildinfo
Files:
 093420057dc552a767074d2f605b4034 1836 net optional cfingerd_1.4.3-5.dsc
 54cb91d4d74f1f37cb7f3f6c9bec3e81 21972 net optional cfingerd_1.4.3-5.debian.tar.xz
 d02fc5184e85ada1d92ce0615f4f0f32 5252 net optional cfingerd_1.4.3-5_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEwv5L0nHBObhsUz5GHpU+J9QxHlgFAl9rLqYACgkQHpU+J9Qx
HlhOnA//ZNjmWt9Pf7iz+8Xznyh8FFi75Amfer4Wn0CXEXYoWtu8qHjbNavbNnPm
MuoCr1ZPVb8j5MybxH6I+LI+y+98gTH/QfIFgMDiE67QAtxoMrn9bBg79owpdt1A
fXgl2P3/WF2HEKnLDB0mfGFL/7ngXOx8z916ly4aFd6mGIPTRVc7z0WepU+9FdhA
J7Y/mgqW8wbqJYfYvJ5SkxmPXCmJQe6ODhxiQatF8GzRcO/xCO+H9E8eZtKnFCu1
pt7pWpLY2nJtJcefrzMbgfJUkP/NlwaJZjUD49rek85pHlJQZEnJ/Et3Tz2yHetW
IH/vjmzSUp61xjfjYtdIpC9zjqNBQjQoBenFMQmxvq4vYRCZxdq70aXf39iIXGab
ajCyhcULxqn8bMBJuuqfSG4USXFJ/L5DgeHDwU9XM9J5+Dd/wN0Mzof9yD33aj10
f9hbZC1qCwoj8QLmHAHataFideHuM2aQzdTxhNRPZDQ8Peoay7Bxn+dweipgDMBH
M1VcwvVVz4cEuB6yDEUILvtgfXzeCSJ5aco1acqhnnVJQdc8qIwyPXapNXEbhY3g
3GdcRLY3gln0S+Sugi9zGucIHEhXYDmv3XUuVZtqkBe13nNNu5Fnve4za3EfInL6
Wf4EA+lGf8lPLuWL081SIAa/8BNZh8Hj3B0OAZifedMgRTl0SAs=
=8lWY
-----END PGP SIGNATURE-----

--- End Message ---

Reply to: