[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#870573: marked as done (grap: please make the build reproducible)

Your message dated Mon, 21 Sep 2020 10:03:32 +0000
with message-id <E1kKIfU-0000TX-AH@fasolo.debian.org>
and subject line Bug#870573: fixed in grap 1.45-2
has caused the Debian Bug report #870573,
regarding grap: please make the build reproducible
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
870573: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=870573
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: grap
Version: 1.45-1
Severity: wishlist
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: uname
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

Hi,

Whilst working on the Reproducible Builds effort [0], we noticed
that grap could not be built reproducibly as it includes the output
of `uname -sr` in the binary.

This results in a different checksum when built on, say i386 with
running a 686 kernel and running an an amd64 kernel (again, on
i386).

Patch attached.

 [0] https://reproducible-builds.org/


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb, Debian Project Leader
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

--- a/debian/patches/reproducible_build.patch	1969-12-31 19:00:00.000000000 -0500
--- b/debian/patches/reproducible_build.patch	2017-08-02 20:05:34.337104563 -0400
@@ -0,0 +1,16 @@
+Description: Make the build reproducible
+Author: Chris Lamb <lamby@debian.org>
+Last-Update: 2017-08-02
+
+--- grap-1.45.orig/grap_parse.cc
++++ grap-1.45/grap_parse.cc
+@@ -877,8 +877,7 @@ void usage() {
+ }
+ 
+ inline void version() {
+-    cout << "grap " << PACKAGE_VERSION << " compiled under " 
+-	 << OS_VERSION << endl;
++    cout << "grap " << PACKAGE_VERSION << endl;
+     cerr << "Fine comparsion limit: " << FINE_EPSILON << endl;
+     cerr << "Fine minimum value: " << FINE_MIN_DOUBLE << endl;
+     cerr << "Coarse comparsion limit: " << COARSE_EPSILON << endl;
--- a/debian/patches/series	1969-12-31 19:00:00.000000000 -0500
--- b/debian/patches/series	2017-08-02 20:05:33.233096268 -0400
@@ -0,0 +1 @@
+reproducible_build.patch

--- End Message ---
--- Begin Message --- 
Source: grap
Source-Version: 1.45-2
Done: Chris Lamb <lamby@debian.org>

We believe that the bug you reported is fixed in the latest version of
grap, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 870573@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Chris Lamb <lamby@debian.org> (supplier of updated grap package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Wed, 16 Sep 2020 10:26:17 +0100
Source: grap
Binary: grap grap-dbgsym
Architecture: source amd64
Version: 1.45-2
Distribution: unstable
Urgency: medium
Maintainer: Debian QA Group <packages@qa.debian.org>
Changed-By: Chris Lamb <lamby@debian.org>
Description:
 grap       - program for typesetting graphs
Closes: 870573
Changes:
 grap (1.45-2) unstable; urgency=medium
 .
   * QA upload.
   * Make the build reproducible. (Closes: #870573)
   * Bump Standards-Version to 4.5.0.
   * Move to HTTPS homepage URL and in debian/watch.
Checksums-Sha1:
 4aa651aecaeb462e5a1926eca591192a23b29f20 1702 grap_1.45-2.dsc
 c7a22dcbc1a745a8fba74a888c3e857cd39832b6 189829 grap_1.45.orig.tar.gz
 30b0d288010c75c261ee855f4a136507abdbcabc 4936 grap_1.45-2.debian.tar.xz
 5f8b8c63d034415b11108b5c8162abac2eca0d51 1441344 grap-dbgsym_1.45-2_amd64.deb
 a63aa8843ea0fcbe42a86ef3e1929c2873ff98c8 5485 grap_1.45-2_amd64.buildinfo
 afcb3003a2318ee6036f4460345a24c57fcf7ee4 142996 grap_1.45-2_amd64.deb
Checksums-Sha256:
 2883256a3ee9f8867bf6de2a3723a14e60f4835e545fee8cb389ce0fea310a16 1702 grap_1.45-2.dsc
 906743cdccd029eee88a4a81718f9d0777149a3dc548672b3ef0ceaaf36a4ae0 189829 grap_1.45.orig.tar.gz
 666c261b44c0b5abcd848b0437650c9274361c3e8b63a33048336bada92f94ab 4936 grap_1.45-2.debian.tar.xz
 8d6dc81dc9ad0802e2d74052d7b1bc0e350a039f93e48b878024832319e5f635 1441344 grap-dbgsym_1.45-2_amd64.deb
 f92e784a681fc4b543c0d17ec651bc3140c4f6a07380170c86b5d04d1e4fcf38 5485 grap_1.45-2_amd64.buildinfo
 93aa9e8c13e6a2d0447a727e6d0fa6fbe4632822d1e1604a7af1ec32beb15cbe 142996 grap_1.45-2_amd64.deb
Files:
 d67a221fd214adba42249b6e28247f9a 1702 text optional grap_1.45-2.dsc
 2952abad9fa4b456be3814eabfaf544e 189829 text optional grap_1.45.orig.tar.gz
 fe193c76ef33cd2af8972a473a07bf61 4936 text optional grap_1.45-2.debian.tar.xz
 807d2b78df47aae6af4f9bd3825a13e6 1441344 debug optional grap-dbgsym_1.45-2_amd64.deb
 a763353e1cd88b0f8a60d778e97ecf70 5485 text optional grap_1.45-2_amd64.buildinfo
 cd0031ff1a59f92345367f05d12c4618 142996 text optional grap_1.45-2_amd64.deb

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEwv5L0nHBObhsUz5GHpU+J9QxHlgFAl9h3eoACgkQHpU+J9Qx
Hlj31A//cBJf27i0lELbfE5uW9DYrYpYIu9QMYonzgDBWq/oQ8f0uMnyS/Ep3DtC
HndqEZqIk1rKaHCdnmPVWoxpouKRDvS+SQDAwEmFuXTIAt/RF4IKymE9cFfIo+AG
f9HkMde7SttiWL24D3bWplSh6uhD/6j6QCGhb+wIz8cpWpWHVbT0a4RbTFvEhoZA
/O1xhjR9eZnIdb5wKcqL7gcFBouIWdh3XC/QqnvVWF8lrr59rLy6rBAn2J2mQUlm
BK7trsNIuSmo0ZVqaYTdVdUbdGzScgQOM9+zjIL9jz84JpnttWCctM79N3ZXFVQ6
/7q7pw7zdb7FqoBnU2V06lDYVmxRUicypP/8zHvPBMSlz+GtmH+/Hk0RWsm3Dr72
fS4TP5rMgBMxon8Otq30CGJYtHwL8M4amXrZi7JHYBzmioY+SZmBZeNRcHc9SJGq
wOSTedyKX3+JRmuC3xYfUTvnPQjAbTk5cCap4hsa70Bhq0Na4RfXvTt/9nUqjkxk
4Eutx1OsJRZlS4BHBZSrc+98QzyJ9bt5WJkR17mUYjTnMmSovZ4i9Q63EC7ig0yQ
Nt1TUlMv2IVx8TjboBDJsSqaS+Za38vf8i6ZFTLS6W+0356R+XhBfA4RG/gly0uD
v6v8KufBwNZN+O1b+2ydAbCJLhUeAhDI+B+2RK5QMPodVhsJhSQ=
=9dvb
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: