[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#866472: Playing with a different approach for the color profiles



El Mon, Jul 29, 2019 at 02:46:14PM +0200, Agustin Martin deia:
> I am attaching a couple of files with current state of my experiments. I am
> also not fluent with python (that is why I did not adopt or sponsored this
> or any other python package), so my changes would definitely need review, if
> considered.
>

I've tried your packaging and it works in my very limited use case. 
But it still seems to install the files

dpkg -L python-uniconvertor
/usr/lib/python2.7/dist-packages/uniconvertor-2.0rc4/uc2/cms/cmyk_profile_rc.py
/usr/lib/python2.7/dist-packages/uniconvertor-2.0rc4/uc2/cms/display_profile_rc.py
/usr/lib/python2.7/dist-packages/uniconvertor-2.0rc4/uc2/cms/gray_profile_rc.py
/usr/lib/python2.7/dist-packages/uniconvertor-2.0rc4/uc2/cms/lab_profile_rc.py
/usr/lib/python2.7/dist-packages/uniconvertor-2.0rc4/uc2/cms/srgb_profile_rc.py

 
> A DEP5 copyright with file exclusion line is included, which should make
> easier to create a DFSG free tarball.
>

But I think
Files-Excluded: */src/uc2/cms/*_profile.py
should be 
Files-Excluded: */src/uc2/cms/*_profile_rc.py

With that it no longer installs the dubious files.

Neither your debian/watch nor mine worked for me this time for some
reason (the version 2.0~rc4 instead of 2.0rc4 maybe among others), I
ended up with

version=4
opts=compression=gz,repack,uversionmangle=s/rc/~rc/,filenamemangle=s/^.*uniconvertor-(\d.*)\.(tgz|tbz2|tar\.(?:gz|bz2|xz)).*$/python-uniconvertor-$1.$2/ https://sk1project.net/modules.php?name=Products&product=uniconvertor&op=download .*=uniconvertor-(\d.*)\.(?:tgz|tbz2|tar\.(?:gz|bz2|xz))

(compression=gz is not really necessary, I guess) 

now uscan is happier (it detected the upstream as always newer before)
and deletes the excluded files from the orig.tar.gz archive. 
I hope it stays so the next time I try it, must have tested it wrong before. 

Another nitpick, in debian/copyright  the text 

On Debian systems, the complete text of the GNU General
 Public License version 3 can be found in
 "/usr/share/common-licenses/GPL-2".

should list the correct path for GPLv3:

On Debian systems, the complete text of the GNU General
 Public License version 3 can be found in
 "/usr/share/common-licenses/GPL-3".

Thank you very much for your work. Let's hope it's useful for whoever
ends up being maintainer and they can return python-uniconvertor to
debian.


Reply to: