[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#600968: marked as done (blackbox crashes on certain applications that disable minimize/maximize)



Your message dated Wed, 17 Jul 2019 20:47:52 +0000
with message-id <E1hnqq8-0000C0-3u@fasolo.debian.org>
and subject line Bug#600968: fixed in blackbox 0.70.1-37
has caused the Debian Bug report #600968,
regarding blackbox crashes on certain applications that disable minimize/maximize
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
600968: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=600968
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: blackbox
Version: 0.70.1-2.2
Severity: normal
Tags: patch

blackbox crashes on applications that disable minimize/maximize wm functions
but leave minimize/maximize wm decorations enabled. (Shouldn't happen, but
also shouldn't crash the window manager.)

Crash happens when clicking on the minimize or maximize button.

I suggest, instead of using an assert, to ignore these button events.
Alternatively, the buttons could be decorated but crayed out.


--- src/Window.cc~	2005-10-18 10:01:41.000000000 +0200
+++ src/Window.cc	2010-10-21 20:50:32.000000000 +0200
@@ -2319,7 +2319,9 @@
       }
     }
   } else {
-    assert(hasWindowFunction(WindowFunctionIconify));
+    if (!hasWindowFunction(WindowFunctionIconify)) {
+      return;
+    }
   }
 
   _screen->addIcon(this);
@@ -2338,7 +2340,9 @@
 
 
 void BlackboxWindow::maximize(unsigned int button) {
-  assert(hasWindowFunction(WindowFunctionMaximize));
+  if (!hasWindowFunction(WindowFunctionMaximize)) {
+    return;
+  }
 
   // any maximize operation always unshades
   client.ewmh.shaded = false;


---------------------------------------

-- System Information:
Debian Release: 5.0.6
  APT prefers stable
  APT policy: (500, 'stable')
Architecture: i386 (i686)

Kernel: Linux 2.6.34 (SMP w/2 CPU cores; PREEMPT)
Locale: LANG=de_DE@euro, LC_CTYPE=de_DE@euro (charmap=ISO-8859-15)
Shell: /bin/sh linked to /bin/bash

Versions of packages blackbox depends on:
ii  libbt                       0.70.1-2.2   Blackbox - shared library
ii  libc6                       2.7-18lenny4 GNU C Library: Shared libraries
ii  libfontconfig1              2.6.0-3      generic font configuration library
ii  libgcc1                     1:4.3.2-1.1  GCC support library
ii  libstdc++6                  4.3.2-1.1    The GNU Standard C++ Library v3
ii  libx11-6                    2:1.1.5-2    X11 client-side library
ii  libxext6                    2:1.0.4-2    X11 miscellaneous extension librar
ii  libxft2                     2.1.12-3     FreeType-based font drawing librar

blackbox recommends no packages.

Versions of packages blackbox suggests:
pn  bbkeys                        <none>     (no description available)
ii  menu                          2.1.41     generates programs menu for all me

-- no debconf information



--- End Message ---
--- Begin Message ---
Source: blackbox
Source-Version: 0.70.1-37

We believe that the bug you reported is fixed in the latest version of
blackbox, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 600968@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Boyuan Yang <byang@debian.org> (supplier of updated blackbox package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Wed, 17 Jul 2019 15:01:26 -0400
Source: blackbox
Architecture: source
Version: 0.70.1-37
Distribution: unstable
Urgency: medium
Maintainer: Debian QA Group <packages@qa.debian.org>
Changed-By: Boyuan Yang <byang@debian.org>
Closes: 600968
Changes:
 blackbox (0.70.1-37) unstable; urgency=medium
 .
   * QA upload.
   * debian/control:
     + Bump Standards-Version to 4.4.0.
     + Bump debhelper compat to v12.
     + Replace empty homepage with development site on sf.net.
     + Update Vcs-* fields to use git packaging repo on salsa.d.o.
   * debian/patches: Add patch to fix crash with certain apps that
     disable minimize/maximize. (Closes: #600968)
   * debian/libbt0.symbols: Update symbols caused by the patch
     accordingly.
   * debian/changelog: Remove trailing spaces.
   * debian/copyright: Update Homepage and use secure URI.
Checksums-Sha1:
 3a86b3e2b6371e4e7fec24ee54f0bd7c1fbb38ac 1983 blackbox_0.70.1-37.dsc
 1c882f1eaa49e42f6aa64188bc42d96a23ad7172 21992 blackbox_0.70.1-37.debian.tar.xz
 a629aa4e9095169b4a3fb7b586395cfbe356bc38 7705 blackbox_0.70.1-37_amd64.buildinfo
Checksums-Sha256:
 f201a933e8764e9271da7858a173afe233d70c55823d9c0e2b30e3617c323bd4 1983 blackbox_0.70.1-37.dsc
 5208b4d5ca195f15d7e65fde1a361d6fe71050a5bee205ae27c166503fab581d 21992 blackbox_0.70.1-37.debian.tar.xz
 559686ff6ae48d1d05c9a2548bc99bf8cb6d0eef912e376aafc436cdc79b1ecb 7705 blackbox_0.70.1-37_amd64.buildinfo
Files:
 b6db35a9ef7a5d127b45af961228f081 1983 x11 optional blackbox_0.70.1-37.dsc
 a8265076f228bdb41dacf78a737e7eb6 21992 x11 optional blackbox_0.70.1-37.debian.tar.xz
 6a02ca0e18cdad588c4ef951250ab979 7705 x11 optional blackbox_0.70.1-37_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEfncpR22H1vEdkazLwpPntGGCWs4FAl0vcm0ACgkQwpPntGGC
Ws7vMg/+Mv4LghFEK/bwaqQJzZ8WqypWstAXt42qfiJGeLVZFfDavIG5bx4Ejr5n
jStSNAq5wO5UqCIVy2pcVPwCE8N3AmjW97R+6CpksT5r7+d6BtdECi0aDSl2+2ae
XhylWZYPQT5T0rXTtwO+jeQ/vlsw71Fidozu6jWnX4UvdI84GQ3BIn4IOVSmseNr
q3SM+klx0B8VPRj1dKGeZfJZnjwaOH0cJSU2fYp88E/LvL41OvX7GlA6qR7TCqrY
TvNgjo5754xWUxW+iT2reM3+FmcAclxMzGWawONDEndvdwD8fR2NmTWNBp/r+6XV
VK93h/Tblw2s972dcaUgwvcbps8stdo/nBuOnM6w4fdiuN+EgXWRrDEYSwffUR2W
lVfIQPNtA5cCFFLDjHFaGEWW4RHC1z0MAjLm4nscoheovfNKCWJA56C7HNcbbXQ+
ni/55S+oerpwoz8LzjO1Wg0aXN0NEPSs/vtDarYjyJxmhdFDC6TlSFjcMGrhtGbK
bEajNz9ueiGdpnI9o8YlEL5oO8a1ud2F120p/DCjFCTJFLL43BTsml9VHUXXNsMN
B9Ycbu4cAUnqcEenNYUp196R/2RjUUGhNSLiJl4ZTGrGyvCZ1Ih/dbApkAZP13oB
chD5kwfnLkCsWoBHFfBA5P8B/4viratg3y3J00wUd/clj/zHiO8=
=eGaz
-----END PGP SIGNATURE-----

--- End Message ---

Reply to: