[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#866472: copyright extract script



El Thu, Jul 11, 2019 at 05:28:30PM +0200, Agustin Martin deia:
> On Thu, Jul 11, 2019 at 04:17:30PM +0200, Agustin Martin wrote:
> > On Thu, Jul 11, 2019 at 04:02:13PM +0200, Xavi Drudis Ferran wrote:
> > > 
> > > I attach the script. It prints some (c) info on the *_rc.py files. 
> > > You might need to change the uniconvertor directory in the script. 
> > > And you may not really find it too enlightening...
> > 
> > Thanks a lot,
> > 
> > I was already looking at the files generated under
> > ~/.config/uc2/profiles/ where those strings can also be guessed. I will look
> > more carefully, but at least one of the color profiles seems non free (the
> > HP one).
> 
> Hi again, Xavi
> 
> I was looking at the color profiles. Here goes a summary of what I found:
>

that was the intention of this code in my debian/rules (probably misplaced) 

	python src/uc2/utils/rcc2py/rcc2py.py /usr/share/color/icc/ghostscript/default_cmyk.icc src/uc2/cms/cmyk_profile_rc.py
	python src/uc2/utils/rcc2py/rcc2py.py /usr/share/color/icc/Gray.icc src/uc2/cms/gray_profile_rc.py
	python src/uc2/utils/rcc2py/rcc2py.py /usr/share/color/icc/sRGB.icc src/uc2/cms/srgb_profile_rc.py
#	python src/uc2/utils/rcc2py/rcc2py.py ? src/uc2/cms/display_profile_rc.py
	python src/uc2/utils/rcc2py/rcc2py.py /usr/share/color/icc/ghostscript/lab.icc src/uc2/cms/lab_profile_rc.py
 
>   * cmyk_profile_rc.py -> built-in_CMYK.icm
> 
>     (Fogra27L.icc) Fogra27L CMYK Coated Press
>     (C) Richard Hughes <richard@hughsie.com>
>     Public Domain
>

I replaced it from /usr/share/color/icc/ghostscript/default_cmyk.icc

But I think I found it had a different checksum to the original. 

The problem is despite beliving the attribution and license of the
original, can I be saying to distribute the source code if I only have
src/uc2/cms/cmyk_profile_rc.py ?  or should I add the file that file
was generated from, which I'm not sure which was?  So to avoid the
doubt, I just removed it, and regenerated from _another_ icc profile,
that I hope is good enough but I can't tell.

Maybe it would be enough to just ship the py or the rcc2py and the
.icc binary decoded from the *_rc.py so people can regenerate the
*_rc.py (but this seems backwards? is it really the binary obtained
from *_rc.py a source for *_rc.py?)
 
To know what counts as source, I should know what is the prefered
format for people modifying icc profiles ?  .icc ? *_rc.py ? something
else ? I've never used an .icc file (conciously).

>   * display_profile_rc.py -> built-in_Display.icm
> 
>     Contains this string:
>     No copyright. Created with dispcalGUI 1.1.2.9 and Argyll CMS 1.4.0 -M P244W -A Acer Technologies
> 
>     Could get no more info about this profile
> 

Yes, I'm in the dark too. 

>   * gray_profile_rc.py -> built-in_Grayscale.icm
> 
>     This is the same as /usr/share/color/icc/Gray.icc, shipped in
>     icc-profiles-free package
>  
>     Copyright (C) 2005-2008 Kai-Uwe Behrmann <www.behrmann.name>
>     License: zlib/libpng License
> 

Yes, but I seem to recall the checksum did not match the base64
decoded file from the _rc.py .  I don't remember well, I should
recheck, maybe some of the files matched, my impression was that most
or all didn't.

Like the first case, I generated it from a debian file
/usr/share/color/icc/Gray.icc
and I don't know if this is a good enough substitute. 

>   * lab_profile_rc.py -> built-in_LAB.icm
> 
>     Seems similar (but not exact) to /usr/share/color/icc/LCMSXYZI.ICM,
>     shipped in icc-profiles-free package
> 
>     Copyright (C) Marti Maria Saguer 1999
>     License: zlib/libpng License
>

 Could be, I tried 
/usr/share/color/icc/ghostscript/lab.icc

>   * srgb_profile_rc.py -> built-in_RGB.icm
> 
>     Copyright (c) 1998 Hewlett-Packard Company
> 
>     $ md5sum built-in_RGB.icm 
>     1d3fda2edb4a89ab60a23c5f7c7d81dd  built-in_RGB.icm
>
>     If you look at https://bugs.debian.org/699301 this is exactly the same
>     file that was reported as non-free. It is shipped as 
>     /usr/share/color/icc/sRGB.icm in non-free icc-profiles package.
>

I tried /usr/share/color/icc/sRGB.icc hoping it is free. But is it a
good enough substitute ?  I mean does it work like the original ? How
do I know ?
 
> Some Debian packages are currently shipping free color profiles, at least
> 
> icc-profiles-free
> colord-data
> libgs9-common
> 

I added to build-depends : 
 libgs9-common,
 icc-profiles-free
But I didn't use colord-data

> I wonder if some profile in those packages could help. I have no idea about
> color profiles and such.
> 

Yes. What does one do here ? Ask the maintainers from libgs9-common,
icc-profiles-free for any ideas on source ? the legal team ? ask
nobody until one has something tested that looks useful ?


Reply to: