[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#898410: marked as done (btrfs-progs: Please build with ZSTD support)

Your message dated Tue, 19 Mar 2019 16:53:07 -0600
with message-id <20190319225305.GA4522@navis>
and subject line Re: Bug#898410: btrfs-progs: Please build with ZSTD support
has caused the Debian Bug report #898410,
regarding btrfs-progs: Please build with ZSTD support
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
898410: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=898410
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: btrfs-progs
Version: 4.15.1-2
Severity: wishlist

Dear Dmitry,

Today I wanted switch from LZO to ZSTD support. But I stumbled upon:

 btrfs-progs (4.15.1-2) unstable; urgency=medium
 .
   * If libzstd is provided in both deb & udeb variants (such as Ubuntu
     bionic) enable zstd support. If libzstd is not provided with both deb
     & udeb variants (such as current Debian unstable) disable zstd
     support. If and when libzstd is provided in both deb & udeb variants,
     a binNMU of this package is sufficient to enable zstd support. Closes:
     #886968

I skimmed through that bug report, but I did not get what it will mean
for ZSTD support in Debian.

Also your changelog entry looks like it could happen never or at any time
("If and when").

So I open this wishlist report to state that I like to see ZSTD support
in btrfs-progs as being packaged in Debian. As it reads as tough you chose
not be the one deciding upon it, feel free to reassign this to whoever is in
charge (Debian installer team probably).

I wonder about just compiling it myself. It should be safe, cause even when
update-initramfs still stuffes the packaged tools into the inital ram disk,
the kernel will be available to use zstd compression files.

Thank you.
Martin

-- System Information:
Debian Release: buster/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (200, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.17.0-rc4-tp520-btrfstrim+ (SMP w/4 CPU cores; PREEMPT)
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8), LANGUAGE=de (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages btrfs-progs depends on:
ii  libblkid1  2.32-0.1
ii  libc6      2.27-3
ii  liblzo2-2  2.08-1.2+b2
ii  libuuid1   2.32-0.1
ii  zlib1g     1:1.2.11.dfsg-1

btrfs-progs recommends no packages.

Versions of packages btrfs-progs suggests:
ii  duperemove  0.11-1

-- no debconf information

--- End Message ---
--- Begin Message --- 
Hi Martin,

On Sat, May 12, 2018 at 12:06:10PM +0200, Martin Steigerwald wrote:
> Hi Dimitri.
> 
> Dimitri John Ledkov - 12.05.18, 11:00:
> > On 11 May 2018 at 11:24, Martin Steigerwald <Martin@lichtvoll.de> 
> > wrote:
> > > Package: btrfs-progs
> > > Version: 4.15.1-2
> > > Severity: wishlist
> […]
> > > Today I wanted switch from LZO to ZSTD support. But I stumbled upon:
> > >  btrfs-progs (4.15.1-2) unstable; urgency=medium
> > >  .
> > >  
> > >    * If libzstd is provided in both deb & udeb variants (such as
> > >    Ubuntu
> > >    
> > >      bionic) enable zstd support. If libzstd is not provided with
> > >      both deb
> > >      & udeb variants (such as current Debian unstable) disable zstd
> > >      support. If and when libzstd is provided in both deb & udeb
> > >      variants,
> > >      a binNMU of this package is sufficient to enable zstd support.
> > >      Closes: #886968
> > > 
> > > I skimmed through that bug report, but I did not get what it will
> > > mean for ZSTD support in Debian.
> > > 
> > > Also your changelog entry looks like it could happen never or at any
> > > time ("If and when").
> > > 
> > > So I open this wishlist report to state that I like to see ZSTD
> > > support in btrfs-progs as being packaged in Debian. As it reads as
> > > tough you chose not be the one deciding upon it, feel free to
> > > reassign this to whoever is in charge (Debian installer team
> > > probably).
> > > 
> > > I wonder about just compiling it myself. It should be safe, cause
> > > even when update-initramfs still stuffes the packaged tools into
> > > the inital ram disk, the kernel will be available to use zstd
> > > compression files.
> > 
> > I uploaded udeb support for libzstd, which got rejected by an FTP
> > Trainee without any reason given. Thus I lost interest in working on
> > that, hence the upload to btrfs-progs to disable zstd support.
> > Introducing a second compilation of btrfs, with/without zstd, for
> > deb/udeb respectively, is doable - for Debian only builds. And I'd be
> > willing to take a patch which does that, but not interested in writing
> > that myself.
> 
> Thank you for the explaination.
> 
> > This bug report is thus effectively duplicate of #886968 / reopening
> > of it.
> > 
> > I guess I can reassign this to the libzstd package?!
> 
> Well sounds about right to me, as I agree with:
> 
> > Ideally, kernel, btrfs-progs, and d-i would all support the same
> > features set, like it is the case in Ubuntu...
> 
> I just like to see zstd support in btrfs-progs, and as the other bug was 
> closed… I am currently not sure whether I´d work on a patch myself for 
> anything, especially as your udeb got rejected without providing a 
> reason.
> 

We succeeded in enabling this for buster :-)

Closing this bug now.  Please note that you might not want to use any
transparent compression supported by btrfs, due to corruption caused
by copying in sparse or hole-punched files. (present in VM images and
some databases).  See the linux-btrfs thread titled as follows for
more info:

  Reproducer for "compressed data + hole data corruption bug, 2018
  edition" still works on 4.20.7


Cheers,
Nicholas

Attachment: signature.asc
Description: PGP signature


--- End Message ---
Reply to: