[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#860941: marked as done (adequate: buildinfo support breaks adequate testsuite (patch attached))

Your message dated Fri, 1 Mar 2019 13:05:14 +0100
with message-id <20190301120514.GA30758@sym.noone.org>
and subject line Re: Bug#860941: adequate: buildinfo support breaks adequate testsuite (patch attached)
has caused the Debian Bug report #860941,
regarding adequate: buildinfo support breaks adequate testsuite (patch attached)
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
860941: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=860941
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: adequate
Version: 0.15.1
Severity: normal
Tags: patch
User: ubuntu-devel@lists.ubuntu.com
Usertags: origin-ubuntu artful ubuntu-patch



In Ubuntu, the attached patch was applied to achieve the following:

  * debian/tests/run-test: Skip over non-deb members in changes files.

Essentially, when built with a recent dpkg-dev, your test packages
end up with .buildinfo files generated, and included in .changes.

This patch just skips over any changes member that doesn't end in
'deb', so you would process all udebs, debs, and ddebs, but not any
other non-deb files, like buildinfo.

... Adam

-- System Information:
Debian Release: stretch/sid
  APT prefers artful
  APT policy: (500, 'artful')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.10.0-19-lowlatency (SMP w/4 CPU cores; PREEMPT)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

diff -Nru adequate-0.15.1ubuntu2/tests/run-tests adequate-0.15.1ubuntu3/tests/run-tests
--- adequate-0.15.1ubuntu2/tests/run-tests	2015-10-15 16:38:34.000000000 -0600
+++ adequate-0.15.1ubuntu3/tests/run-tests	2017-04-22 00:50:41.000000000 -0600
@@ -145,8 +145,9 @@
                 for para in apt_pkg.TagFile(file):
                     for line in para['Files'].splitlines():
                         md5, size, section, priority, path = line.split()
-                        debpkg = DebPkg(path)
-                        packages[debpkg.name] += [debpkg]
+                        if path.endswith('deb'):
+                            debpkg = DebPkg(path)
+                            packages[debpkg.name] += [debpkg]
         elif path.endswith('.deb'):
             debpkg = DebPkg(path)
             packages[debpkg.name] += [debpkg]

--- End Message ---
--- Begin Message --- 
Version: 0.15.2

Hi Adam,

Adam Conrad wrote:
> In Ubuntu, the attached patch was applied to achieve the following:
> 
>   * debian/tests/run-test: Skip over non-deb members in changes files.
> 
> Essentially, when built with a recent dpkg-dev, your test packages
> end up with .buildinfo files generated, and included in .changes.
> 
> This patch just skips over any changes member that doesn't end in
> 'deb', so you would process all udebs, debs, and ddebs, but not any
> other non-deb files, like buildinfo.

This is fixed in the upload from last night. Unfortunately I seem to
have been too tired to remember to look through the open bug reports
besides the RC bug I wanted to fix.

But I noticed the failing autopkgtests, came to the same conclusion
and actually developed the exactly same patch despite it would have
been already available and tested.

So thanks for the patch and sorry for not mentioning you in the
changelog entry.

Will update the changelog entry accordingly for the next upload,
whenever that will happen.

		Regards, Axel
-- 
 ,''`.  |  Axel Beckert <abe@debian.org>, https://people.debian.org/~abe/
: :' :  |  Debian Developer, ftp.ch.debian.org Admin
`. `'   |  4096R: 2517 B724 C5F6 CA99 5329  6E61 2FF9 CD59 6126 16B5
  `-    |  1024D: F067 EA27 26B9 C3FC 1486  202E C09E 1D89 9593 0EDE

Attachment: signature.asc
Description: Digital signature


--- End Message ---
Reply to: