[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#919204: marked as done (irqbalance FTBFS on hppa)

Your message dated Mon, 04 Feb 2019 20:54:39 +0000
with message-id <E1gqlGJ-000DaS-JM@fasolo.debian.org>
and subject line Bug#919204: fixed in irqbalance 1.5.0-3
has caused the Debian Bug report #919204,
regarding irqbalance FTBFS on hppa
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
919204: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=919204
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: irqbalance
Version: 1.5.0-2
Severity: important
Tag: patch

irqbalance fails to build on hppa because of two reasons:

1.) irqbalance fails to correctly detect the actual CPU count, this is because on parisc file like 
/sys/devices/system/cpu/cpu0/online don't exist, instead 
/sys/devices/system/cpu/cpu0/hotplug/state needs to be examimend.

2.) On newer kernels you can't echo 0xfffffff into the files like /proc/irq/100/smp_affinity.
This returns EOVERFLOW on newer kernels, which is probably why it fails on parisc (we run latest
kernels on the buildd), while other architectures have older kernels.

Attached patch fixes both issues, and it should generate no issues on other architectures (instead
it fixes them too if their kernels gets updated),

Please apply for next upload,
Thanks!
Helge


diff -up ./activate.c.org ./activate.c
--- ./activate.c.org	2018-12-29 11:38:19.399024158 +0100
+++ ./activate.c	2018-12-29 11:49:51.929217483 +0100
@@ -88,6 +88,9 @@ static void activate_mapping(struct irq_
 	if (!file)
 		return;
 
+	/* mask only possible cpus, otherwise writing to procfs returns EOVERFLOW */
+	cpus_and(applied_mask, applied_mask, cpu_possible_map);
+
 	cpumask_scnprintf(buf, PATH_MAX, applied_mask);
 	fprintf(file, "%s", buf);
 	fclose(file);
diff -up ./classify.c.org ./classify.c
diff -up ./cputree.c.org ./cputree.c
--- ./cputree.c.org	2018-12-29 03:32:26.269546669 +0100
+++ ./cputree.c	2018-12-29 11:28:06.316150924 +0100
@@ -259,6 +259,10 @@ static void do_one_cpu(char *path)
 	/* skip offline cpus */
 	snprintf(new_path, ADJ_SIZE(path,"/online"), "%s/online", path);
 	file = fopen(new_path, "r");
+	if (!file) {
+		snprintf(new_path, ADJ_SIZE(path,"/hotplug/state"), "%s/hotplug/state", path);
+		file = fopen(new_path, "r");
+	}
 	if (file) {
 		char *line = NULL;
 		size_t size = 0;

--- End Message ---
--- Begin Message --- 
Source: irqbalance
Source-Version: 1.5.0-3

We believe that the bug you reported is fixed in the latest version of
irqbalance, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 919204@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Dmitry Bogatov <KAction@debian.org> (supplier of updated irqbalance package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Mon, 04 Feb 2019 20:06:08 +0000
Source: irqbalance
Binary: irqbalance
Architecture: source
Version: 1.5.0-3
Distribution: unstable
Urgency: medium
Maintainer: Debian QA Group <packages@qa.debian.org>
Changed-By: Dmitry Bogatov <KAction@debian.org>
Description:
 irqbalance - Daemon to balance interrupts for SMP systems
Closes: 919204
Changes:
 irqbalance (1.5.0-3) unstable; urgency=medium
 .
   * QA upload.
   * Fix FTBFS on hppa architecture (Closes: #919204)
   * Trim trailing whitespace.
   * wrap-and-sort -sta
   * Bump debhelper version to 10
   * Include runit script
Checksums-Sha1:
 fb70d4a2edbbc752e3f56c546fad49e2625b6651 2183 irqbalance_1.5.0-3.dsc
 6a2d354f2455dbf6c7be9a03256994e6136e3655 19416 irqbalance_1.5.0-3.debian.tar.xz
 299045470b97b088e271f20d1ffa774bbdf79e99 6528 irqbalance_1.5.0-3_source.buildinfo
Checksums-Sha256:
 3d199205606c4bd7b3e05191a0b29985605c0ab62a1ee10540be68466aaa101a 2183 irqbalance_1.5.0-3.dsc
 73651d1d8f50d45b1fce39816464797163cd5e8a526c89d8f0d605efc8a89109 19416 irqbalance_1.5.0-3.debian.tar.xz
 badbb94e2a760185efffb2b06fa82103e47d903f9ade8762c2d5880f91f19b62 6528 irqbalance_1.5.0-3_source.buildinfo
Files:
 d415fa4cdc8dda52df29efa013ac2efe 2183 utils optional irqbalance_1.5.0-3.dsc
 da3841d61e8b0c48747d71d9d0944bca 19416 utils optional irqbalance_1.5.0-3.debian.tar.xz
 2b7a52df99a2c10f50d3fe7965278999 6528 utils optional irqbalance_1.5.0-3_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJHBAEBCgAxFiEEhnHVzDbtdH7ktKj4SBLY3qgmEeYFAlxYnSgTHGthY3Rpb25A
ZGViaWFuLm9yZwAKCRBIEtjeqCYR5h46D/9CTuA7Db9pX7wMBk5QHTZ96gaZjigF
k6o/QFdVjzgfA0JsFsCBy2235Touh/lXNpdllZ+hfjLHSQtbFxYYGnhKnB95XiPw
1Z+PtDxIUI1ZQnyfcEjHUvZUtE19CdGIan3bd83Uvhy/xaJwtFi22cbM06TKaifG
m4W1q90IcwYCa4xaoxRZB/kmxgU8lAa9wUFnYKHSRqhBCf/Hqtk3sHyyuHsNqVGk
FJb4WNlCSXA0xDeax+NH8lXLPyAEbWmpBCqBIOfB3F2CwrH7ZI5wMdw1nOUZ0ifl
rd2wqTNfmfj/60YB+UuqFVaCUgZqgz5aeP194hk70WORZBaxQuUPNkRx+SFbYiF/
5ZWnyFh8uydzsg1YvNj0qfGmPtCQqyz5Pyybtl1VnHQHGhhG8JB3OWuW3d3UYEd4
f4MEgNnqVOPisKDxNsEVo8W6smpJCuEsrI4Fgp/hBgmnS7C7KyxxkNpJwDimsGSi
kwSv+kZzmrZcQ8bySgrE8n4iu3rNiJZGduLOAN0cHGnSna9a4EJNA9X3XSsHmbjA
B3wHhAWUbYAUTKSqznOVlr5QvRjXJyT3Gl7fiioe9qiY72w+LGwCL8Bz75ETt6Sh
QHakuFuHmiQy9HJORprItOIo3HwVtvWWGxNmXo9smoi1s12cwYKg2KsREXBlVytW
RamJ10dkBd4fkg==
=EvP9
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: