Bug#921237: bcfg2-server does not properly shutdown
Package: bcfg2-server
Version: 1.4.0~pre2+git141-g6d40dace6358-1
Severity: normal
Tags: patch upstream
Dear Maintainer,
bcfg2-server cannot be properly shutdown by systemd. Instead it runs
into a timeout and has to be killed by systemd. This is inconvent and
severly slows down the shutdown of the entire system.
This is an upstream bug that has been fixed in git by now:
https://github.com/Bcfg2/bcfg2/commit/020b8cfd398de6730f5767abbc1f587c899138f5
Is it possible to include this as a patch in the Debian package? I
assume it affects not only stretch but buster and sid as well.
-- System Information:
Debian Release: 9.7
APT prefers stable-updates
APT policy: (500, 'stable-updates'), (500, 'stable')
Architecture: amd64 (x86_64)
Kernel: Linux 4.9.0-8-amd64 (SMP w/1 CPU core)
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8), LANGUAGE=de_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
Versions of packages bcfg2-server depends on:
pn bcfg2 <none>
ii init-system-helpers 1.48
pn libxml2-utils <none>
ii lsb-base 9.20161125
ii openssl 1.1.0j-1~deb9u1
ii python 2.7.13-2
pn python-daemon <none>
pn python-genshi <none>
pn python-lxml <none>
pn python-pyinotify | python-gamin <none>
ii ucf 3.0036
Versions of packages bcfg2-server recommends:
pn graphviz <none>
ii patch 2.7.5-1+deb9u1
Versions of packages bcfg2-server suggests:
pn bcfg2-doc <none>
ii exim4-daemon-light [mail-transport-agent] 4.89-2+deb9u3
ii python [python-profiler] 2.7.13-2
pn python-cheetah <none>
pn python-django <none>
>From 020b8cfd398de6730f5767abbc1f587c899138f5 Mon Sep 17 00:00:00 2001
From: Alexander Sulfrian <alexander.sulfrian@fu-berlin.de>
Date: Fri, 12 Oct 2018 18:02:50 +0200
Subject: [PATCH] Fix server shutdown
---
src/lib/Bcfg2/Server/Core.py | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/src/lib/Bcfg2/Server/Core.py b/src/lib/Bcfg2/Server/Core.py
index 445bc17b5..a1ee24e18 100644
--- a/src/lib/Bcfg2/Server/Core.py
+++ b/src/lib/Bcfg2/Server/Core.py
@@ -331,6 +331,10 @@ def _file_monitor_thread(self):
select.select([famfd], [], [], 2)
elif not self.fam.pending():
terminate.wait(15)
+
+ if self.terminate.isSet():
+ break
+
if self.fam.pending():
try:
self._update_vcs_revision()
>From 020b8cfd398de6730f5767abbc1f587c899138f5 Mon Sep 17 00:00:00 2001
From: Alexander Sulfrian <alexander.sulfrian@fu-berlin.de>
Date: Fri, 12 Oct 2018 18:02:50 +0200
Subject: [PATCH] Fix server shutdown
---
src/lib/Bcfg2/Server/Core.py | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/src/lib/Bcfg2/Server/Core.py b/src/lib/Bcfg2/Server/Core.py
index 445bc17b5..a1ee24e18 100644
--- a/src/lib/Bcfg2/Server/Core.py
+++ b/src/lib/Bcfg2/Server/Core.py
@@ -331,6 +331,10 @@ def _file_monitor_thread(self):
select.select([famfd], [], [], 2)
elif not self.fam.pending():
terminate.wait(15)
+
+ if self.terminate.isSet():
+ break
+
if self.fam.pending():
try:
self._update_vcs_revision()
Reply to: