--- Begin Message ---
Source: libantlr3c
Version: 3.4+dfsg-2
Severity: serious
Justification: policy 4.6
Tags: patch
libantlr3c fails to cross build from source, because it does not pass
--host to ./configure. The easiest way of doing so is using
dh_auto_configure. That is sufficient for making libantlr3c cross
buildable.
While preparing the patch, I noticed that debian/rules is chaining build
command (configure and ln) with ";". Doing so is prohibited by Debian
policy section 4.6, because it can result in silent misbuilds.
Therefore, I bumped the severity to serious.
The attached patch fixes both issues as they really affect the same
lines. Merging these issues felt simpler that filing two bugs with
conflicting patches.
Helmut
diff --minimal -Nru libantlr3c-3.4+dfsg/debian/changelog libantlr3c-3.4+dfsg/debian/changelog
--- libantlr3c-3.4+dfsg/debian/changelog 2018-06-21 12:38:06.000000000 +0200
+++ libantlr3c-3.4+dfsg/debian/changelog 2019-01-25 06:33:12.000000000 +0100
@@ -1,3 +1,10 @@
+libantlr3c (3.4+dfsg-2.1) UNRELEASED; urgency=medium
+
+ * Non-maintainer upload.
+ * Use dh_auto_configure. (Closes: #-1)
+
+ -- Helmut Grohne <helmut@subdivi.de> Fri, 25 Jan 2019 06:33:12 +0100
+
libantlr3c (3.4+dfsg-2) unstable; urgency=medium
* QA upload.
diff --minimal -Nru libantlr3c-3.4+dfsg/debian/rules libantlr3c-3.4+dfsg/debian/rules
--- libantlr3c-3.4+dfsg/debian/rules 2018-06-16 22:18:36.000000000 +0200
+++ libantlr3c-3.4+dfsg/debian/rules 2019-01-25 06:33:10.000000000 +0100
@@ -16,22 +16,16 @@
override_dh_auto_configure:
# Configure with ANTLR remote debugger enabled
- mkdir build-dbg
- ( cd build-dbg; \
- ../configure $(CROSS) --prefix=/usr \
- --libdir=\$${prefix}/lib/$(DEB_HOST_MULTIARCH) \
+ dh_auto_configure --builddirectory=build-dbg --
--enable-debuginfo --disable-abiflags --enable-antlrdebug \
- $(ENABLE_64BIT); \
- ln -s ../include )
+ $(ENABLE_64BIT)
+ ln -s ../include build-dbg/
# Configure with ANTLR remote debugger disabled
- mkdir build-nodbg
- ( cd build-nodbg; \
- ../configure $(CROSS) --prefix=/usr \
- --libdir=\$${prefix}/lib/$(DEB_HOST_MULTIARCH) \
+ dh_auto_configure --builddirectory=build-nodbg --
--enable-debuginfo --disable-abiflags --disable-antlrdebug \
- $(ENABLE_64BIT); \
- ln -s ../include )
+ $(ENABLE_64BIT)
+ ln -s ../include build-nodbg/
override_dh_auto_build:
( cd build-dbg; $(MAKE) )
--- End Message ---
--- Begin Message ---
Source: libantlr3c
Source-Version: 3.4+dfsg-3
We believe that the bug you reported is fixed in the latest version of
libantlr3c, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 920403@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Andreas Beckmann <anbe@debian.org> (supplier of updated libantlr3c package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Sat, 26 Jan 2019 16:22:40 +0100
Source: libantlr3c
Architecture: source
Version: 3.4+dfsg-3
Distribution: unstable
Urgency: medium
Maintainer: Debian QA Group <packages@qa.debian.org>
Changed-By: Andreas Beckmann <anbe@debian.org>
Closes: 920403
Changes:
libantlr3c (3.4+dfsg-3) unstable; urgency=medium
.
[ Andreas Beckmann ]
* QA upload.
* Switch to debhelper-compat (= 12).
* Bump Standards-Version to 4.3.0 (no changes needed).
.
[ Helmut Grohne ]
* Use dh_auto_configure. (Closes: #920403)
Checksums-Sha1:
b4a04d4ec4110202646cf755758286a1363ec1aa 2057 libantlr3c_3.4+dfsg-3.dsc
85c724a24fe7b816735bddf65c0faa4a4263f05a 6232 libantlr3c_3.4+dfsg-3.debian.tar.xz
de861fab606f8ce5cefc7c9a4129d58ad77735e7 5381 libantlr3c_3.4+dfsg-3_source.buildinfo
Checksums-Sha256:
2a5ba58a8ba534158c5f42a997ac6901bef57cbee2b26076acf1f839d2a6c170 2057 libantlr3c_3.4+dfsg-3.dsc
5c5eaf80ed30c25241cd336ffed12c1f142975902ddba8297975729e72233be0 6232 libantlr3c_3.4+dfsg-3.debian.tar.xz
fe878d389861818abc8e566c5a9e24b056e89aa5a013d4af0c64e8d9fc280f11 5381 libantlr3c_3.4+dfsg-3_source.buildinfo
Files:
ab63b42461234a492f94cfc321bf96be 2057 libs optional libantlr3c_3.4+dfsg-3.dsc
7fb2141f9b05db7fc467baed271486ce 6232 libs optional libantlr3c_3.4+dfsg-3.debian.tar.xz
2291575f25446b6065bd1a905bba569b 5381 libs optional libantlr3c_3.4+dfsg-3_source.buildinfo
-----BEGIN PGP SIGNATURE-----
iQJEBAEBCAAuFiEE6/MKMKjZxjvaRMaUX7M/k1np7QgFAlxMfSgQHGFuYmVAZGVi
aWFuLm9yZwAKCRBfsz+TWentCDcHD/9ir/W8onYlV30vGqYUjscFsj9GvBlod+4v
jxjGhPh0v2cJEu6e+mLkdPAlnvxpLNXSk7XvyRVSY/el9vvrDt4I8a+uTPeJKD5q
psNlSU4YvcnXy/vNTbSUs9Jt3/JKqb7MIp2iRpSkc+sOmcKbOYjcMV5yUFUk0dOg
mwG0dnD7OJc0n2ivYfFYLNRmHzNTWX8MRcd2U9jkIz6DC0TsfsCb5m/OkL4p4U7M
F6J5CPDfvweSe8GA++9LhFz5IqdZrnq2AhxdnLxH5yggG2codmW9Siavy+7oDT3b
TxL/lqZA4hhNWDYol/tMw/lyaOb2i8tE4Gad73ZOdFK4hL6jGoda6qVMcEVvBX1+
TJWBaJwG7e7+03D88sWEuQJdgkXIGjAVf82TUp7WAcZ9s+D7MJqusvfwxv/fgseH
Hgf/7vxLbMC/ACdY+sFxpqEkqyjV5UUhilqGnTj6idQxZKFxaaoGiii22KWAE0RN
M5pjP9hNnnKvrUAtWzRy0W/9TFWTMqSWyyjyg2hipITXTs9t9ejIQrSdD6eAZrw8
BJBWIEGQPIIYGRLqAO/OGQk9tfIv1wEe+O08t2tdpMg/bfsEtBEdDnEUkZ2tLUSx
rh/AJNHoO5QH4zyyfXe4cDzb54dHTraQtBgGsUfhMLKxS6MWhHcqM2/e2ke5+46N
AB5SdfVk8A==
=zQXK
-----END PGP SIGNATURE-----
--- End Message ---