[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#891556: marked as done (ifhp: FTBFS with GCC 8 - error: 'strncpy' specified bound 128 equals destination size)

Your message dated Sun, 05 Aug 2018 11:19:21 +0000
with message-id <E1fmH4D-0008wD-MU@fasolo.debian.org>
and subject line Bug#891556: fixed in ifhp 3.5.20-16
has caused the Debian Bug report #891556,
regarding ifhp: FTBFS with GCC 8 - error: 'strncpy' specified bound 128 equals destination size
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
891556: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=891556
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: ifhp
Version: 3.5.20-15
Severity: important
User: debian-gcc@lists.debian.org
Usertag: ftbfs-gcc-8

Hi,

I recently performed an (unofficial) archive rebuild with GCC 8 on
mips64el. The main purpose of the rebuild was to discover mips toolchain
regressions, however I noticed this error in the logs which might be
interesting to you:

> ifhp.c: In function 'Find_sub_value':
> ifhp.c:2803:3: error: 'strncpy' specified bound 128 equals destination size [-Werror=stringop-truncation]
>    strncpy(copy,id+1,sizeof(copy));
>    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> cc1: all warnings being treated as errors
> <builtin>: recipe for target 'ifhp.o' failed
> make[2]: *** [ifhp.o] Error 1
> make[2]: Leaving directory '/<<PKGBUILDDIR>>/src'
> Makefile:51: recipe for target 'src' failed
> make[1]: *** [src] Error 2
> make[1]: Leaving directory '/<<PKGBUILDDIR>>'
> debian/rules:32: recipe for target 'build-stamp' failed
> make: *** [build-stamp] Error 2
> dpkg-buildpackage: error: debian/rules build-arch subprocess returned exit status 2

As you probably know, you need to be careful using strncpy.

Instead of:
 char out[SIZE];
 strncpy(out, in, SIZE);

You need to do:
 char out[SIZE]
 strncpy(out, in, SIZE - 1);
 out[SIZE - 1] = '\0';

See strcpy(3)

James

Attachment: signature.asc
Description: OpenPGP digital signature


--- End Message ---
--- Begin Message --- 
Source: ifhp
Source-Version: 3.5.20-16

We believe that the bug you reported is fixed in the latest version of
ifhp, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 891556@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Adam Borowski <kilobyte@angband.pl> (supplier of updated ifhp package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sun, 05 Aug 2018 12:44:49 +0200
Source: ifhp
Binary: ifhp
Architecture: source
Version: 3.5.20-16
Distribution: unstable
Urgency: medium
Maintainer: Debian QA Group <packages@qa.debian.org>
Changed-By: Adam Borowski <kilobyte@angband.pl>
Description:
 ifhp       - Printer filter for HP LaserJet printers
Closes: 891556
Changes:
 ifhp (3.5.20-16) unstable; urgency=medium
 .
   * QA upload.
   * Fix FTBFS due to strncpy. Closes: #891556.
Checksums-Sha1:
 d05f72d2a892cef1312dc3f06e2c8a47028ea022 1771 ifhp_3.5.20-16.dsc
 70f2205de69b386f2f9ae447be3b9e3801c068b0 89536 ifhp_3.5.20-16.debian.tar.xz
 dc73874be5a5b5e57ac6e15f3bc6492a4ff31f65 6725 ifhp_3.5.20-16_source.buildinfo
Checksums-Sha256:
 000016aa6072ef99d062db01b39418c44818cbcc7b50593ce1ed05cee98fd801 1771 ifhp_3.5.20-16.dsc
 fe8309a2d990234b8e6b21ce67017105b84a84a984f3e1b7f73fde9d7c9aa8ae 89536 ifhp_3.5.20-16.debian.tar.xz
 96a29416257b1607d0586838c27937559e27542b4eae5aca82d21dfe39a80af9 6725 ifhp_3.5.20-16_source.buildinfo
Files:
 7bd999a9bf9ac43fd9b6751bba356a25 1771 net extra ifhp_3.5.20-16.dsc
 4d26d9d5d61b421301d5c465589e3751 89536 net extra ifhp_3.5.20-16.debian.tar.xz
 0b1ab18fc730b17443dbe3867f8f91e6 6725 net extra ifhp_3.5.20-16_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJIBAEBCgAyFiEEkjZVexcMh/iCHArDweDZLphvfH4FAltm1aEUHGtpbG9ieXRl
QGFuZ2JhbmQucGwACgkQweDZLphvfH72OxAAum23djskMcRlzOZI8+yhyWeK6I0t
wbNGJ0arUuQQcZKWFypZFPpIccclpAWVbv8AJW7XIzY7sNy2Arqtauq0oYke76QW
59f7tz5jL0l6CdkYnXiKAuqQ49Ighs/yoT9beL3NI4Us880VD81wNnJQ4Vo6g9Wt
Jteib6cuP2suUIF00QN0Dy1XEbnwvBqaOqdROyNt6VmmRp3eBYLTP3CwcDwxpYN2
gkgMNYoim9+88caV1Eis/JXvrwagSJCoqv9VSE7Z3b0nT/zCfiaoX613GzP3KZdu
OU7GUBaCFQnSk/2wlmFU4rhNFJ6qvhreFw310omwzw217T0eq1L8e6gaGDIGrw1G
L0rsCzKNu0Vjari/MC0nDJXUQCe8r2/TZ0DMEhQduwh+0HovoB7mrRyRII5MS0ks
wvLVl/HYKzd9BBnfLiL1nZoxQlYBUcRaTTgRkqLNGjX3BtYXhEXSntiBhcGQ8Wgj
njS9JwqROqPestZNl0Gx3uTOjclyF3zFslMpEmc8YhlosCJV8VKp+HnxeRh785kr
xGVDbEN5ywc4N2/E6u7VeZKMByTBsrrcAL38UgEvim0oGk8AVQ7/HqYu/yWq9qAW
+ra/2sgDByNiKaLfJ3/xh/MpPd4eYFdOtiPbx4uhIUCAt4+RbjfY0ZYhYyTVczSX
GM1O1A22orD2QzA=
=U2sw
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: