Bug#897771: ifhp: ftbfs with GCC-8

[Matthias Klose <doko@debian.org>]

Package: src:ifhp
Version: 3.5.20-15
Severity: normal
Tags: sid buster
User: debian-gcc@lists.debian.org
Usertags: ftbfs-gcc-8

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-8/g++-8, but succeeds to build with gcc-7/g++-7. The
severity of this report will be raised before the buster release.

The full build log can be found at:
http://aws-logs.debian.net/2018/05/01/gcc8/ifhp_3.5.20-15_unstable_gcc8.log.gz
The last lines of the build log are at the end of this report.

To build with GCC 8, either set CC=gcc-8 CXX=g++-8 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

Common build failures are new warnings resulting in build failures with
-Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-8/porting_to.html

[...]
config.status: creating config.h
./config.status: 1: cd: can't cd to /sbuild-nonexistent
config.status: executing default-1 commands
config.status: creating po/POTFILES
config.status: creating po/Makefile
touch configure-stamp
dh_testdir
/usr/bin/make LDFLAGS=`dpkg-buildflags --get LDFLAGS`
make[1]: Entering directory '/<<PKGBUILDDIR>>'
rm -f ifhp.conf
sed \
	-e "s,.CAT@,/bin/cat,g" \
	-e "s,.FILTER_DIR@,/usr/lib/ifhp,g" \
	-e "s,.A2PS@,/usr/bin/a2ps,g" \
	-e "s,.GS@,/usr/bin/gs,g" \
	-e "s,.GZIP@,/bin/gzip,g" \
	-e "s,.FILEUTIL@,/usr/bin/file,g" \
	-e "s,.PAGE_SIZE@,letter,g" \
	-e "s,.FONT_DIR@,/usr/libexec/filters/fonts,g" \
	-e "s,.DEVFD3@,/dev/fd/3,g" \
	-e "s,.FOOMATIC@,1,g" \
	-e "s,.FOOMATIC_RIP@,/usr/bin/foomatic-rip,g" \
		./ifhp.conf.in >ifhp.conf
if [ "src" = po ] ; then \
    for i in po/Makefile* ; do \
	if [ -f "$i" ] ; then \
	    if grep '^mkinstalldirs.*=.*case' $i ; then \
		echo "fixing broken $i which causes wrong path to mkinstalldirs to be used"; \
		perl -spi -e 's:^mkinstalldirs\s*=\s*.*:mkinstalldirs = \$(SHELL) \$(MKINSTALLDIRS):' $i; \
	    fi \
	fi \
    done \
fi
if [ "src" != po -o "no" != "no" ] ; then \
	cd src; /usr/bin/make localedir=/usr/share/locale \
	DESTDIR= all ; \
fi
make[2]: Entering directory '/<<PKGBUILDDIR>>/src'
gcc -g -W -Wall -Werror -Wno-unused  -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -Wno-unused-parameter -Wno-implicit-fallthrough -g -W -Wall -Werror -Wno-unused  -DHAVE_CONFIG_H -I. -I.. -I.  -DIFHP_CONF=\"/etc/ifhp.conf\" -DLOCALEDIR=\"/usr/share/locale\"   -c -o ifhp.o ifhp.c
ifhp.c: In function 'Find_sub_value':
ifhp.c:2803:3: error: 'strncpy' specified bound 128 equals destination size [-Werror=stringop-truncation]
   strncpy(copy,id+1,sizeof(copy));
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
make[2]: *** [<builtin>: ifhp.o] Error 1
make[2]: Leaving directory '/<<PKGBUILDDIR>>/src'
make[1]: *** [Makefile:52: src] Error 2
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
make: *** [debian/rules:33: build-stamp] Error 2
dpkg-buildpackage: error: debian/rules build-arch subprocess returned exit status 2