Bug#387793: aumix: segfaults on console when resolution changes

[Samuel Thibault <sthibault@debian.org>]

Control: clone -1 -2
Control: reassign -2 gpm
Control: retitle -2 libgpm crashes on calling syslog

Hello,

Ricardo Fabian Peliquero, on dim. 28 janv. 2018 19:35:22 -0300, wrote:
> Aumix is showing segmentation fault if invoked within an X terminal
> emulator (e.g. stterm). This only happens when using the ncurses
> user interface; then 'aumix -v 100' will work as expected.
> 
> Besides, it works OK from ordinary tty (e.g. tty1-6).

Well, this is not related with bug 387793 then :)

Looking more into the backtrace

Program terminated with signal SIGSEGV, Segmentation fault.
#0  __strchrnul_avx2 () at ../sysdeps/x86_64/multiarch/strchr-avx2.S:76
76	../sysdeps/x86_64/multiarch/strchr-avx2.S: Aucun fichier ou dossier de ce type.
(gdb) bt
#0  __strchrnul_avx2 () at ../sysdeps/x86_64/multiarch/strchr-avx2.S:76
#1  0x00007f88711cbb52 in __find_specmb (
    format=0x2573 <error: Cannot access memory at address 0x2573>) at printf-parse.h:108
#2  _IO_vfprintf_internal (s=s@entry=0x557eed6c76d0, 
    format=format@entry=0x2573 <error: Cannot access memory at address 0x2573>, 
    ap=0x7ffff2a3bbf0) at vfprintf.c:1320
#3  0x00007f8871283428 in ___vfprintf_chk (fp=fp@entry=0x557eed6c76d0, flag=flag@entry=1, 
    format=format@entry=0x2573 <error: Cannot access memory at address 0x2573>, 
    ap=ap@entry=0x7ffff2a3bbf0) at vfprintf_chk.c:33
#4  0x00007f887126e777 in __GI___vsyslog_chk (pri=<optimized out>, flag=1, 
    fmt=0x2573 <error: Cannot access memory at address 0x2573>, ap=ap@entry=0x7ffff2a3bbf0)
    at ../misc/syslog.c:222
#5  0x00007f887126ecbf in __syslog_chk (pri=pri@entry=6, flag=flag@entry=1, 
    fmt=fmt@entry=0x2573 <error: Cannot access memory at address 0x2573>)
    at ../misc/syslog.c:129
#6  0x00007f8871992cdf in syslog (
    __fmt=0x2573 <error: Cannot access memory at address 0x2573>, __pri=6)
    at /usr/include/x86_64-linux-gnu/bits/syslog.h:31
#7  gpm_report (line=line@entry=478, file=file@entry=0x7f88719934b1 "lib/liblow.c", 
    stat=stat@entry=3, text=text@entry=0x7f8871993539 "Warning: closing connection")
    at lib/report-lib.c:50
#8  0x00007f8871991b67 in Gpm_GetEvent (event=event@entry=0x7f8871b95420 <ev>)
    at lib/liblow.c:478
#9  0x00007f8871992fe8 in Gpm_Wgetch (win=0x557eed6b1cb0) at lib/libcurses.c:87
#10 0x0000557eeb879247 in Inter () at ../../../src/curses.c:366
#11 0x0000557eeb876db7 in main (argc=1, argv=0x7ffff2a3c028) at ../../../src/common.c:283

I saw this gpm patch
debian/patches/092_fix-format-not-a-string-literal-and-no-format-arguments.patch

-   syslog(log_level, string);
+   syslog(log_level, '%s', string);


That should obviously rather be

+   syslog(log_level, "%s", string);

:)

Samuel